From patchwork Wed Sep 27 08:10:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 145246 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp2472545vqu; Wed, 27 Sep 2023 01:25:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHoZ1haNNbgq+uEX2e60TJ1YVdCAq11otAhoVXW5p2LeBzYuwKy2u270QV/Qo6BIKEtvWyc X-Received: by 2002:a05:6358:2921:b0:134:c37f:4b64 with SMTP id y33-20020a056358292100b00134c37f4b64mr1345350rwb.30.1695803118045; Wed, 27 Sep 2023 01:25:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695803118; cv=none; d=google.com; s=arc-20160816; b=bbz+gRbOix1TMWZVhQdmwQPvb/cEhx2+ChmbBtCrNWPbq2p+q6gJRzbQQSlZ+UgBi6 SGCsdWZ5QMWyTf7VHuW23EKqrMs/cM4tAwwZFr8emTylapB+m5obcb4Eg2rKDVOjFQz8 OLTSZSwSPmoXIgDZVQWDmJaddfCWADMr0gIam44s6urU/NVO0RwdxofaavrDQjdKRUVU k6cnGEb0/L7AiPFVD5jgzYDKY6GHTbsO6BnThiLqLdDzRh1c3w8av+1xr6RDl7+jpg7O y+epbDQI+8QNRfGLYM3RE4lLZL1kiWQdeLAFZ6CdJyxcvavsNO0Swt7HEIiktLy5jcUT O/RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=EBGUtQMo2I6jw3VmHLSQ5Vw5C1inbGoj/EftrChnD5M=; fh=Dlo1odEjcRtH1BJ+R8/KYHyn3hjJitJ8wbI0kHiiB+U=; b=PaiNb7rxjehPGYvsUZkgUyABa0pn+hgRweHqdWyDzJ6K7pP3xdbHFGeKfMrjazxbRP UIY5qd6GhKVfNnY7d0NpHL+8mb8B6L5XM5qnTMqohSti6DxYwdMQA9XsPplbWTZojrNg da/fQvT+bnSn2r7UkeEWhUXM26/rXWYiPe9CG3T5EHtTzg0BHHeZ+MczsK34PgsUAzD9 ZIKsBzbm6Xzhwe9pd/i0Kk/9Zxd5z65Qj2Zm4p2BGq7mgfLKNQw/cB2OMT07k/xbaFYc aSFoGgqriQRCIIk4f6GBHVzGHkn003C+iinV82kdo3O/W4j+/Jk9uAYb8KNRhsv9P4fa DCtA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id v1-20020a654601000000b0056a290addadsi15314107pgq.787.2023.09.27.01.25.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 01:25:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 1CE33801D770; Wed, 27 Sep 2023 01:13:49 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230452AbjI0IMW (ORCPT + 23 others); Wed, 27 Sep 2023 04:12:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230236AbjI0ILE (ORCPT ); Wed, 27 Sep 2023 04:11:04 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A5A4192 for ; Wed, 27 Sep 2023 01:11:00 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qlPdB-00084H-Vo; Wed, 27 Sep 2023 10:10:49 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qlPdA-009I7h-W5; Wed, 27 Sep 2023 10:10:49 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qlPdA-005BR0-Mr; Wed, 27 Sep 2023 10:10:48 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Mark Gross , Vadim Pasternak Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 15/27] platform/mellanox: mlxbf-tmfifo: Convert to platform remove callback returning void Date: Wed, 27 Sep 2023 10:10:28 +0200 Message-Id: <20230927081040.2198742-16-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230927081040.2198742-1-u.kleine-koenig@pengutronix.de> References: <20230927081040.2198742-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1870; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=CxjrzFzEkM6O7z80cNwT5EXT0bqldk5XDjLUTnuR0Y0=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlE+NuMm1KeBgObA5wqP/oMc1QGazphFC29+aTn seP42tD4gqJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZRPjbgAKCRCPgPtYfRL+ TjIwB/4xndkYpQ+BvWFG8bVLBguRWGmAkFUJDqI5N74Z2ObmukEKyraFnnmO1r1lJ2ii9Nk2lnn X8s7u/n9zMb41hlp5UfsvtmoW1yN2xj69NFrf0GL+7xtzlEHzdTgkSPQbT1nxfLIOzgfJlQiVzJ iONvs33bN909TfnUw0Ecg1J1X9kLNSCvMM5g97kzdJVqMPzTcvSRy8beyb/rA3yXWrUYVqmz7Yr qYvPnxl5RmgTAHmednfhLnZTYXJNO5jlMQU9IAaNiRwr7LrnXo/wy88P2/Y5IkYrIk31EktNflg tt95oGMo2opbb9SjOW7YpYGafkmHQXbcbFboYwjA23AcBh74 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 27 Sep 2023 01:13:49 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778178450318776565 X-GMAIL-MSGID: 1778178450318776565 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/mellanox/mlxbf-tmfifo.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/platform/mellanox/mlxbf-tmfifo.c b/drivers/platform/mellanox/mlxbf-tmfifo.c index f3696a54a2bd..69729ba8f505 100644 --- a/drivers/platform/mellanox/mlxbf-tmfifo.c +++ b/drivers/platform/mellanox/mlxbf-tmfifo.c @@ -1361,13 +1361,11 @@ static int mlxbf_tmfifo_probe(struct platform_device *pdev) } /* Device remove function. */ -static int mlxbf_tmfifo_remove(struct platform_device *pdev) +static void mlxbf_tmfifo_remove(struct platform_device *pdev) { struct mlxbf_tmfifo *fifo = platform_get_drvdata(pdev); mlxbf_tmfifo_cleanup(fifo); - - return 0; } static const struct acpi_device_id mlxbf_tmfifo_acpi_match[] = { @@ -1378,7 +1376,7 @@ MODULE_DEVICE_TABLE(acpi, mlxbf_tmfifo_acpi_match); static struct platform_driver mlxbf_tmfifo_driver = { .probe = mlxbf_tmfifo_probe, - .remove = mlxbf_tmfifo_remove, + .remove_new = mlxbf_tmfifo_remove, .driver = { .name = "bf-tmfifo", .acpi_match_table = mlxbf_tmfifo_acpi_match,