[1/2] dt-bindings: display: panel: Add Raydium RM692E5

Message ID 20230927-topic-fp5_disp-v1-1-a6aabd68199f@linaro.org
State New
Headers
Series Raydium RM692E5-based BOE panel driver |

Commit Message

Konrad Dybcio Sept. 27, 2023, 1:19 p.m. UTC
  Raydium RM692E5 is a display driver IC used to drive AMOLED DSI panels.
Describe it.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 .../bindings/display/panel/raydium,rm692e5.yaml    | 73 ++++++++++++++++++++++
 1 file changed, 73 insertions(+)
  

Comments

Conor Dooley Sept. 28, 2023, 5:09 p.m. UTC | #1
On Wed, Sep 27, 2023 at 03:19:01PM +0200, Konrad Dybcio wrote:
> Raydium RM692E5 is a display driver IC used to drive AMOLED DSI panels.
> Describe it.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>  .../bindings/display/panel/raydium,rm692e5.yaml    | 73 ++++++++++++++++++++++
>  1 file changed, 73 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/raydium,rm692e5.yaml b/Documentation/devicetree/bindings/display/panel/raydium,rm692e5.yaml
> new file mode 100644
> index 000000000000..423a85616c1c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/raydium,rm692e5.yaml
> @@ -0,0 +1,73 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/raydium,rm692e5.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Raydium RM692E5 based DSI display Panels

The capitalisation here drives me crazy, but I can live with it...

> +
> +maintainers:
> +  - Konrad Dybcio <konradybcio@kernel.org>

In case it's a typo, you sharing the d between first and surnames in
your email addr?

> +
> +description: |

This | should not be needed.

Otherwise, this seems fine to me.
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> +  The Raydium RM692E5 is a generic DSI Panel IC used to control
> +  AMOLED panels.
> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +  compatible:
> +    items:
> +      - const: fairphone,fp5-rm692e5-boe
> +      - const: raydium,rm692e5
> +
> +  dvdd-supply:
> +    description: Digital voltage rail
> +
> +  vci-supply:
> +    description: Analog voltage rail
> +
> +  vddio-supply:
> +    description: I/O voltage rail
> +
> +  reg: true
> +  port: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - reset-gpios
> +  - dvdd-supply
> +  - vci-supply
> +  - vddio-supply
> +  - port
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    dsi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        panel@0 {
> +            compatible = "fairphone,fp5-rm692e5-boe", "raydium,rm692e5";
> +            reg = <0>;
> +
> +            reset-gpios = <&tlmm 44 GPIO_ACTIVE_LOW>;
> +            dvdd-supply = <&vreg_oled_vci>;
> +            vci-supply = <&vreg_l12c>;
> +            vddio-supply = <&vreg_oled_dvdd>;
> +
> +            port {
> +                panel_in_0: endpoint {
> +                    remote-endpoint = <&dsi0_out>;
> +                };
> +            };
> +        };
> +    };
> +
> +...
> 
> -- 
> 2.42.0
>
  
Konrad Dybcio Sept. 28, 2023, 5:24 p.m. UTC | #2
On 28.09.2023 19:09, Conor Dooley wrote:
> On Wed, Sep 27, 2023 at 03:19:01PM +0200, Konrad Dybcio wrote:
>> Raydium RM692E5 is a display driver IC used to drive AMOLED DSI panels.
>> Describe it.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>>  .../bindings/display/panel/raydium,rm692e5.yaml    | 73 ++++++++++++++++++++++
>>  1 file changed, 73 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/panel/raydium,rm692e5.yaml b/Documentation/devicetree/bindings/display/panel/raydium,rm692e5.yaml
>> new file mode 100644
>> index 000000000000..423a85616c1c
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/panel/raydium,rm692e5.yaml
>> @@ -0,0 +1,73 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/display/panel/raydium,rm692e5.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Raydium RM692E5 based DSI display Panels
> 
> The capitalisation here drives me crazy, but I can live with it...
Oh that's what I get for copypasting a different yaml as template :D
willfix

> 
>> +
>> +maintainers:
>> +  - Konrad Dybcio <konradybcio@kernel.org>
> 
> In case it's a typo, you sharing the d between first and surnames in
> your email addr?
Intentional design decision!

> 
>> +
>> +description: |
> 
> This | should not be needed.
Ack

> 
> Otherwise, this seems fine to me.
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks!

Konrad
  

Patch

diff --git a/Documentation/devicetree/bindings/display/panel/raydium,rm692e5.yaml b/Documentation/devicetree/bindings/display/panel/raydium,rm692e5.yaml
new file mode 100644
index 000000000000..423a85616c1c
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/raydium,rm692e5.yaml
@@ -0,0 +1,73 @@ 
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/raydium,rm692e5.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Raydium RM692E5 based DSI display Panels
+
+maintainers:
+  - Konrad Dybcio <konradybcio@kernel.org>
+
+description: |
+  The Raydium RM692E5 is a generic DSI Panel IC used to control
+  AMOLED panels.
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    items:
+      - const: fairphone,fp5-rm692e5-boe
+      - const: raydium,rm692e5
+
+  dvdd-supply:
+    description: Digital voltage rail
+
+  vci-supply:
+    description: Analog voltage rail
+
+  vddio-supply:
+    description: I/O voltage rail
+
+  reg: true
+  port: true
+
+required:
+  - compatible
+  - reg
+  - reset-gpios
+  - dvdd-supply
+  - vci-supply
+  - vddio-supply
+  - port
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    dsi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        panel@0 {
+            compatible = "fairphone,fp5-rm692e5-boe", "raydium,rm692e5";
+            reg = <0>;
+
+            reset-gpios = <&tlmm 44 GPIO_ACTIVE_LOW>;
+            dvdd-supply = <&vreg_oled_vci>;
+            vci-supply = <&vreg_l12c>;
+            vddio-supply = <&vreg_oled_dvdd>;
+
+            port {
+                panel_in_0: endpoint {
+                    remote-endpoint = <&dsi0_out>;
+                };
+            };
+        };
+    };
+
+...