Message ID | 20230926204204.2120316-1-andreas@kemnade.info |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp2187099vqu; Tue, 26 Sep 2023 13:55:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFg5w+Q9vYwLv6qL+qmTdzjzWv1qUTrQnN7ze7cGONy8rYJ27motTOyIFrjNc7Vi23EUsgh X-Received: by 2002:a17:90a:f016:b0:26d:3ad:7c83 with SMTP id bt22-20020a17090af01600b0026d03ad7c83mr7915146pjb.13.1695761754192; Tue, 26 Sep 2023 13:55:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695761754; cv=none; d=google.com; s=arc-20160816; b=eKE5x8u5+I4HuW9YUtjDMY2VUyu55a5lotaG6ZHLMeAXM8LskxFC996JUqpkq63MVl lzDWoxh9fXwC9i6P+XaZ7bH4HCk+Nj8M9uvUyGYZA+tp2m7qptela15vNx+/TfqRVvGW KJgQKYjk0Y1xYDf3twXPSYac4AyDDOYCwYyqZDDHntUxHBXoEVVIzFWfMHpWkQrR7f+z Ie3ZWQhsPh417YJWgz5lViwK8JRAzo362skQvkUjb41ZUt840TKQ4IKEVsmvkeeMrmtq 8C5Dq1P9lvaiWzVmnKJn3O8NZu6A2HNXBjiA2e2TaDUBl/O1pMfuQRllKQRKIwi+AVYQ XA5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=wR7cNwYGmXEKYN3ENn+/EdepeafP7PTJKqEHH5APryc=; fh=zh3d3x9lQGBBeRDxXJ3u5JvMTgGIgna9QtMBbctOflM=; b=it2f8+/g8ZQ52iok0xKAxBTZ/3W9GFA8TgP3ToGW+LaPZpbl9VQNjvjHLGVINSuojr jefG1b8Bpasiwb11DAZSHI0/GJXIKTbbYp0n+9mV9I+72L8eKn0CFyFOdtwvpOeyTdaJ 2QQMNl8rSQbAHEbYv1mVlfPiOuBsIIq2h+2fiEVLAZTU7zZjOucHqxd3CGhVoC+XPTjZ UDb0aW+DN2+hFk5aioO2U2nsX+k4dhybAk2Z+Jk9E5eG8KZJMHbuyLzUjLNTPUxnJtoj cdTRM1djkvbeBHYN5nY7dJOjN/Wavk4BfTwQsoNBP0IlFvWHoMQU2TSz/GLR3fX5DcWD 709g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id ck18-20020a17090afe1200b002774df69ae4si6292145pjb.92.2023.09.26.13.55.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 13:55:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id B86C9808A8ED; Tue, 26 Sep 2023 13:42:31 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235910AbjIZUmY (ORCPT <rfc822;pwkd43@gmail.com> + 28 others); Tue, 26 Sep 2023 16:42:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232008AbjIZUmX (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 26 Sep 2023 16:42:23 -0400 Received: from mail.andi.de1.cc (mail.andi.de1.cc [IPv6:2a02:c205:3004:2154::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DA849F; Tue, 26 Sep 2023 13:42:16 -0700 (PDT) Received: from p200300ccff2a5b001a3da2fffebfd33a.dip0.t-ipconnect.de ([2003:cc:ff2a:5b00:1a3d:a2ff:febf:d33a] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from <andreas@kemnade.info>) id 1qlEsl-004D7y-4C; Tue, 26 Sep 2023 22:42:10 +0200 Received: from andi by aktux with local (Exim 4.96) (envelope-from <andreas@kemnade.info>) id 1qlEsk-008tas-1C; Tue, 26 Sep 2023 22:42:10 +0200 From: Andreas Kemnade <andreas@kemnade.info> To: bcousson@baylibre.com, tony@atomide.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andreas Kemnade <andreas@kemnade.info> Subject: [PATCH] ARM: dts: omap4-embt2ws: Add Bluetooth Date: Tue, 26 Sep 2023 22:42:04 +0200 Message-Id: <20230926204204.2120316-1-andreas@kemnade.info> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 26 Sep 2023 13:42:31 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778135077082808115 X-GMAIL-MSGID: 1778135077082808115 |
Series |
ARM: dts: omap4-embt2ws: Add Bluetooth
|
|
Commit Message
Andreas Kemnade
Sept. 26, 2023, 8:42 p.m. UTC
Since the required clock is now available, add bluetooth.
Note: Firmware (bts file) from device vendor reroutes tx for some time
during initialisation and later put it back, producing timeouts in
bluetooth initialisation but ignoring that command leads to proper
initialisation.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
Depends on: https://lore.kernel.org/linux-omap/20230916100515.1650336-6-andreas@kemnade.info/T/#u
arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
Comments
On 26/09/2023 22:42, Andreas Kemnade wrote: > Since the required clock is now available, add bluetooth. > > Note: Firmware (bts file) from device vendor reroutes tx for some time > during initialisation and later put it back, producing timeouts in > bluetooth initialisation but ignoring that command leads to proper > initialisation. > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info> > --- > Depends on: https://lore.kernel.org/linux-omap/20230916100515.1650336-6-andreas@kemnade.info/T/#u > arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts > index 9d2f2d8639496..25b80385dc1f0 100644 > --- a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts > +++ b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts > @@ -478,10 +478,12 @@ &uart2 { > interrupts-extended = <&wakeupgen GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH > &omap4_pmx_core OMAP4_UART2_RX>; > > - /* > - * BT + GPS in WL1283 in WG7500 requiring CLK32KAUDIO of pmic > - * which does not have a driver > - */ > + bluetooth: tiwi { Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation E.g. "bluetooth" Best regards, Krzysztof
On Wed, 27 Sep 2023 09:56:28 +02Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 26/09/2023 22:42, Andreas Kemnade wrote: > > Since the required clock is now available, add bluetooth. > > > > Note: Firmware (bts file) from device vendor reroutes tx for some time > > during initialisation and later put it back, producing timeouts in > > bluetooth initialisation but ignoring that command leads to proper > > initialisation. > > > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info> > > --- > > Depends on: https://lore.kernel.org/linux-omap/20230916100515.1650336-6-andreas@kemnade.info/T/#u > > arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts | 10 ++++++---- > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > diff --git a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts > > index 9d2f2d8639496..25b80385dc1f0 100644 > > --- a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts > > +++ b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts > > @@ -478,10 +478,12 @@ &uart2 { > > interrupts-extended = <&wakeupgen GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH > > &omap4_pmx_core OMAP4_UART2_RX>; > > > > - /* > > - * BT + GPS in WL1283 in WG7500 requiring CLK32KAUDIO of pmic > > - * which does not have a driver > > - */ > > + bluetooth: tiwi { > > Node names should be generic. See also an explanation and list of > examples (not exhaustive) in DT specification: > https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > > E.g. "bluetooth" > well, that is what I get currently as a reward from the kernel for describing the hardware and so the motivation for the patch, not necessarily the most important functionality. But the over the uart runs the ti shared transport protocol (also there is a non dt compatible driver in drivers/misc/ti-st) which provides more than Bluetooth, e.g. it also provides at least GNSS and FM (although it do not know if it works in this particular hardware). GPS/GNSS should work. So the node name would be bluetoothgnss then? Well, I think we do not need the label then. Regards, Andreas
On 27/09/2023 18:29, Andreas Kemnade wrote: > > > On Wed, 27 Sep 2023 09:56:28 +02Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > >> On 26/09/2023 22:42, Andreas Kemnade wrote: >>> Since the required clock is now available, add bluetooth. >>> >>> Note: Firmware (bts file) from device vendor reroutes tx for some time >>> during initialisation and later put it back, producing timeouts in >>> bluetooth initialisation but ignoring that command leads to proper >>> initialisation. >>> >>> Signed-off-by: Andreas Kemnade <andreas@kemnade.info> >>> --- >>> Depends on: https://lore.kernel.org/linux-omap/20230916100515.1650336-6-andreas@kemnade.info/T/#u >>> arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts | 10 ++++++---- >>> 1 file changed, 6 insertions(+), 4 deletions(-) >>> >>> diff --git a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts >>> index 9d2f2d8639496..25b80385dc1f0 100644 >>> --- a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts >>> +++ b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts >>> @@ -478,10 +478,12 @@ &uart2 { >>> interrupts-extended = <&wakeupgen GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH >>> &omap4_pmx_core OMAP4_UART2_RX>; >>> >>> - /* >>> - * BT + GPS in WL1283 in WG7500 requiring CLK32KAUDIO of pmic >>> - * which does not have a driver >>> - */ >>> + bluetooth: tiwi { >> >> Node names should be generic. See also an explanation and list of >> examples (not exhaustive) in DT specification: >> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation >> >> E.g. "bluetooth" >> > well, that is what I get currently as a reward from the kernel for describing > the hardware and so the motivation for the patch, not necessarily the most important > functionality. > > But the over the uart runs the ti shared transport protocol (also there is > a non dt compatible driver in drivers/misc/ti-st) which provides more than Bluetooth, > e.g. it also provides at least GNSS and FM (although it do not know if it works in this particular > hardware). GPS/GNSS should work. > > So the node name would be bluetoothgnss then? Well, I think we do not need the label then. bluetooth-gnss would work for me if it was accepted by bindings... but it is not, so this leaves you so far with "bluetooth". Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts index 9d2f2d8639496..25b80385dc1f0 100644 --- a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts +++ b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts @@ -478,10 +478,12 @@ &uart2 { interrupts-extended = <&wakeupgen GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH &omap4_pmx_core OMAP4_UART2_RX>; - /* - * BT + GPS in WL1283 in WG7500 requiring CLK32KAUDIO of pmic - * which does not have a driver - */ + bluetooth: tiwi { + compatible = "ti,wl1283-st"; + enable-gpios = <&gpio1 25 GPIO_ACTIVE_HIGH>; /* GPIO_25 */ + clocks = <&twl 1>; + clock-names = "ext_clock"; + }; }; &uart3 {