dt-bindings: remoteproc: mtk,scp: Add missing additionalProperties on child node schemas
Message ID | 20230926164513.101958-1-robh@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp2060262vqu; Tue, 26 Sep 2023 09:58:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IETDzaFYxulqHw5qWfdat7UVZsUg8gLlnp4Cjqqrhw0OrjEg1PfGj5gnk9+WDjxM4A1MbEn X-Received: by 2002:a05:6a00:15d5:b0:691:2d4:23a2 with SMTP id o21-20020a056a0015d500b0069102d423a2mr10039460pfu.31.1695747530521; Tue, 26 Sep 2023 09:58:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695747530; cv=none; d=google.com; s=arc-20160816; b=ODkLxL650MCxBJcZ0siYHVEMw31nZfPT9SLzbmcpgdZXuVpTMPzMnhJ202bHVH8CyI itNFIv+lm49imI28z4ql0DBSMLAIxU+6E7S1dmJYbLc34EURHCSpyiw9EcPOmQzw3lwa CMYZ2Cs1MXjaMqj5YdmCdVFx4N/WCa4uKx4BG0WrDZ+NzltAvhJX7j8lLxf5LMhD+84c /4wXHuIC25K3L1VcVy1oaCVAEVH6BWOnA4G0SjiSRbH18EP6X67gOns/9/j3qf7RB2Q7 xyZ2zpkHWWTRBz+8uR/v1rudp9O0APlyIYgBuxv3EdCfn6CWh/8bI6gdjUfbn74Y6qdN sLRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=rnjnk+YYr3UHiZnQyZtcglFMhD3zdtbdeKEv4rdGxTs=; fh=5nbGAVVZkmssIkSld8HID+xP6fgVgDYVlVQqOoZ6uqI=; b=MJeJDnGVOKvznMkaiK2+HX29atcgbPv1vEJIaN6QI4WFLGMGGA7NB9X5e9WCrTwATW vjYtXmu/TdwfzMYre17AMRfOwkm2o3PSL8TmARq9C49Dm/ndUdTLDLt0g1aFGWrwtOnn +Rc73Iilc6Qyehj1hTRV4BGl1Iwe/yaIKVZ/L7JHl9nyukQqygzSurD9hrv4PK1OKL0x JgpG08te2DFxj+ElFz9fPtXnrWFmQDmXMun2qt3Pntg7uJ+Qz1Jfxck6EPWptPN1Asr+ Ai6q3Qz3hi8LgHp706nF0BFnAW3xXWgGJ+d/gwi58WAGaDItKx9pwf50gb6+uR1kZ9vo g1Vw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qq2tfooT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id g2-20020a636b02000000b0057e0c5a34f1si9748577pgc.239.2023.09.26.09.58.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 09:58:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qq2tfooT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 76DAA8091C60; Tue, 26 Sep 2023 09:45:58 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235369AbjIZQpd (ORCPT <rfc822;pwkd43@gmail.com> + 28 others); Tue, 26 Sep 2023 12:45:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235377AbjIZQpc (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 26 Sep 2023 12:45:32 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D62FF180; Tue, 26 Sep 2023 09:45:25 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 62842C433C7; Tue, 26 Sep 2023 16:45:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695746725; bh=aYyNkcYVEy5iUmtkKozylsTv6tDrVJnDNQ3yWacAOpE=; h=From:To:Cc:Subject:Date:From; b=qq2tfooTqqPYFON0eSeyQI07FZu1DUcA8mcw4uBpxv1/cgJOQRnZ93YtiKi/61vKS UAYcUWY/ICSiL+GOadHAG2K5n5KfxIxdfUG9ho7TLRoc33/bpFVx4qq6m+waAyh/n9 HpcjGSw6bDZ9LkKqz6EtET7UqIpCeML9hecUhZJ9IW0tBP9qZ91PhMoJHjO8pLe45x zb1JyUuu/h1CApqiBKjopN4PmYLLQlbAA7VLLCK/veDYnoCJ4dHpkwJwoZEQTAVsPE f2wL1UboIZ/WN2yO43riAsOtVxN7efRf1RP0q+Ko+gHgNyTxz6JBW3NsKHOqzLsyv3 wFfYrCigx4ctQ== Received: (nullmailer pid 102369 invoked by uid 1000); Tue, 26 Sep 2023 16:45:22 -0000 From: Rob Herring <robh@kernel.org> To: Bjorn Andersson <andersson@kernel.org>, Mathieu Poirier <mathieu.poirier@linaro.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Matthias Brugger <matthias.bgg@gmail.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, Tinghan Shen <tinghan.shen@mediatek.com> Cc: linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH] dt-bindings: remoteproc: mtk,scp: Add missing additionalProperties on child node schemas Date: Tue, 26 Sep 2023 11:45:08 -0500 Message-Id: <20230926164513.101958-1-robh@kernel.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 26 Sep 2023 09:45:58 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778120162643379196 X-GMAIL-MSGID: 1778120162643379196 |
Series |
dt-bindings: remoteproc: mtk,scp: Add missing additionalProperties on child node schemas
|
|
Commit Message
Rob Herring
Sept. 26, 2023, 4:45 p.m. UTC
Just as unevaluatedProperties or additionalProperties are required at
the top level of schemas, they should (and will) also be required for
child node schemas. That ensures only documented properties are
present for any node.
Signed-off-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 1 +
1 file changed, 1 insertion(+)
Comments
Il 26/09/23 18:45, Rob Herring ha scritto: > Just as unevaluatedProperties or additionalProperties are required at > the top level of schemas, they should (and will) also be required for > child node schemas. That ensures only documented properties are > present for any node. > > Signed-off-by: Rob Herring <robh@kernel.org> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
On Tue, Sep 26, 2023 at 11:45:08AM -0500, Rob Herring wrote: > Just as unevaluatedProperties or additionalProperties are required at > the top level of schemas, they should (and will) also be required for > child node schemas. That ensures only documented properties are > present for any node. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- Acked-by: Conor Dooley <conor.dooley@microchip.com> > Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > index 895415772d1d..24422fd56e83 100644 > --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > @@ -91,6 +91,7 @@ allOf: > > additionalProperties: > type: object > + additionalProperties: false > description: > Subnodes of the SCP represent rpmsg devices. The names of the devices > are not important. The properties of these nodes are defined by the > -- > 2.40.1 >
Hi Rob, On Tue, Sep 26, 2023 at 11:45:08AM -0500, Rob Herring wrote: > Just as unevaluatedProperties or additionalProperties are required at > the top level of schemas, they should (and will) also be required for > child node schemas. That ensures only documented properties are > present for any node. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > index 895415772d1d..24422fd56e83 100644 > --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > @@ -91,6 +91,7 @@ allOf: > > additionalProperties: > type: object > + additionalProperties: false Things have changed in the remoteproc tree [1] and this patch doesn't apply. Please see if it is still needed. Thanks, Mathieu [1]. https://git.kernel.org/pub/scm/linux/kernel/git/remoteproc/linux.git/tree/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml?h=rproc-next#n80 > description: > Subnodes of the SCP represent rpmsg devices. The names of the devices > are not important. The properties of these nodes are defined by the > -- > 2.40.1 >
On Thu, Sep 28, 2023 at 2:31 PM Mathieu Poirier <mathieu.poirier@linaro.org> wrote: > > Hi Rob, > > On Tue, Sep 26, 2023 at 11:45:08AM -0500, Rob Herring wrote: > > Just as unevaluatedProperties or additionalProperties are required at > > the top level of schemas, they should (and will) also be required for > > child node schemas. That ensures only documented properties are > > present for any node. > > > > Signed-off-by: Rob Herring <robh@kernel.org> > > --- > > Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > > index 895415772d1d..24422fd56e83 100644 > > --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > > +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > > @@ -91,6 +91,7 @@ allOf: > > > > additionalProperties: > > type: object > > + additionalProperties: false > > Things have changed in the remoteproc tree [1] and this patch doesn't apply. > Please see if it is still needed. It is not needed any more. Thanks, Rob
diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml index 895415772d1d..24422fd56e83 100644 --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml @@ -91,6 +91,7 @@ allOf: additionalProperties: type: object + additionalProperties: false description: Subnodes of the SCP represent rpmsg devices. The names of the devices are not important. The properties of these nodes are defined by the