From patchwork Tue Sep 26 15:53:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 144953 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp2017099vqu; Tue, 26 Sep 2023 08:54:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGovOgAcP70yYmahK5iqsfuM1D4CceIAeyqhl5pu6C51puUs2Z90IsAcDPR3QRO9Dx3/ACh X-Received: by 2002:a05:6a20:5492:b0:14d:f087:c0cc with SMTP id i18-20020a056a20549200b0014df087c0ccmr12354278pzk.48.1695743677287; Tue, 26 Sep 2023 08:54:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695743677; cv=none; d=google.com; s=arc-20160816; b=w91cqbS6kdQfFIfz1i9HxWp3ZeHN2v+QOQ7U/bLSrzTjIvY5RubmRjMK0x46OIjjrF RxTScL0wjfahjOiwFTTg1oPZc+oRvqtDs98ZPmrLJwUsP3eYU5V6HsXDrHxyGE74bm5V j4QnNHdShuhwTIfY8jKTkxXF2YfW0liLQ42z26asXTQdDGLxooNpAmUDxlV612YGxKo1 XMR4ag7Jeu8JUrZdkfciKWZwG3ffPIZkRTEpznl+uS2h3FztH8wWXxNIXhV6CkQyItCL LMqWeaGfO/UH5yDkrHM18tHDY6AV+s5I8rYTO1SfB2dGhjXSnwFtrc8MG5ZaYJM02xX3 5rPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=eE4Kw4ynJn/fY0uTa13p94UN/QAJIGEXQWpl87QwNb8=; fh=hn2K8zH58zhgy12DX7GhzjVYO69QJpZQVgFrLxMK9VM=; b=OhfoNvGTbUt/fi45A7lmkKQZ/VeJxaJbAqmUsy0lfCVVIUxl5gaGF4MgaKLOkM85Wn FIVZyTOXJhJfi7x/F9BwPsOkbkRJQcwqifFKljR6tA3iKf4JzemOBv+LRT2un4ZA8MSH 6dFKPKd1L0IzSYLjUEPbAkWCKUq9n7JO4tCq7zgLAsrh8FY5aVrxgdBv0yWgX83XzsGI BgPYFamUHn+t1sIilmXtf5xR7/U7AKFr6GDXWH9xTVbaIMS9mORc0bGEPmBr2oOujp0W S6/8G6N9i1/46jJejFkM/Ft911RKodTqtn57KWPYp11MNmK6k5THZUKdeY+kCWN0nE2W OycQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=u8XvF9TN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id bs125-20020a632883000000b00564929df8besi11837436pgb.568.2023.09.26.08.54.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 08:54:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=u8XvF9TN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id D727281BAA76; Tue, 26 Sep 2023 08:54:34 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234417AbjIZPy2 (ORCPT + 28 others); Tue, 26 Sep 2023 11:54:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229629AbjIZPy1 (ORCPT ); Tue, 26 Sep 2023 11:54:27 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89F9511D; Tue, 26 Sep 2023 08:54:20 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A87CDC433C7; Tue, 26 Sep 2023 15:54:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695743660; bh=a0yWQ4vIBE8N4N1i6VC7OsRaMv2o6zjb5hCiz+yfCDg=; h=From:To:Cc:Subject:Date:From; b=u8XvF9TNvYBIvrKGre6i0T5K/DxCKJ68oIb6JbO8VGJGPKPUtxj2iQV0QAlrQmQMl Bt/H5gf0wWHzL4UZiKV6SlC1INMtcUIQNo+ws9TsR4vPogc6mJCuIq01pzcOH/FcQO 7lbfPQXpttXVAI7h7Ds6HVt9Czq16CePiSqFtI/iy/erHiz3I1Wosqwqbcc1Vdf0dG raDlRaAtChbAc5Fa2llBkCd2kw3SZBNIsNgaR25fItAhCPnxrWlTbBf46ycs1jlrRk MgxL71snrZUpfA3A0gS8xU8+P5f9ay/d9BB33I1yvjRYjoHmRLCj6uYTudPpqcoA02 bVhve0ve4Pd9g== Received: (nullmailer pid 31792 invoked by uid 1000); Tue, 26 Sep 2023 15:54:17 -0000 From: Rob Herring To: Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy?= =?utf-8?q?=C5=84ski?= , Bjorn Helgaas , Krzysztof Kozlowski , Conor Dooley , Ray Jui , Scott Branden , Broadcom internal kernel review list Cc: Ray Jui , Scott Branden , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] dt-bindings: PCI: brcm,iproc-pcie: Fix example indentation Date: Tue, 26 Sep 2023 10:53:40 -0500 Message-Id: <20230926155351.31117-1-robh@kernel.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 26 Sep 2023 08:54:34 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778116122106589841 X-GMAIL-MSGID: 1778116122106589841 The example's indentation is off. While fixing this, the 'bus' node is unnecessary and can be dropped. It is also preferred to split up unrelated examples to their own entries. Signed-off-by: Rob Herring Acked-by: Conor Dooley Reviewed-by: Florian Fainelli --- .../bindings/pci/brcm,iproc-pcie.yaml | 124 +++++++++--------- 1 file changed, 60 insertions(+), 64 deletions(-) diff --git a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml index 0972868735fc..0cb5bd6cffa1 100644 --- a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml @@ -117,68 +117,64 @@ unevaluatedProperties: false examples: - | - #include - - bus { - #address-cells = <1>; - #size-cells = <1>; - pcie0: pcie@18012000 { - compatible = "brcm,iproc-pcie"; - reg = <0x18012000 0x1000>; - - #interrupt-cells = <1>; - interrupt-map-mask = <0 0 0 0>; - interrupt-map = <0 0 0 0 &gic GIC_SPI 100 IRQ_TYPE_NONE>; - - linux,pci-domain = <0>; - - bus-range = <0x00 0xff>; - - #address-cells = <3>; - #size-cells = <2>; - device_type = "pci"; - ranges = <0x81000000 0 0 0x28000000 0 0x00010000>, - <0x82000000 0 0x20000000 0x20000000 0 0x04000000>; - - phys = <&phy 0 5>; - phy-names = "pcie-phy"; - - brcm,pcie-ob; - brcm,pcie-ob-axi-offset = <0x00000000>; - - msi-parent = <&msi0>; - - /* iProc event queue based MSI */ - msi0: msi { - compatible = "brcm,iproc-msi"; - msi-controller; - interrupt-parent = <&gic>; - interrupts = , - , - , - ; - }; - }; - - pcie1: pcie@18013000 { - compatible = "brcm,iproc-pcie"; - reg = <0x18013000 0x1000>; - - #interrupt-cells = <1>; - interrupt-map-mask = <0 0 0 0>; - interrupt-map = <0 0 0 0 &gic GIC_SPI 106 IRQ_TYPE_NONE>; - - linux,pci-domain = <1>; - - bus-range = <0x00 0xff>; - - #address-cells = <3>; - #size-cells = <2>; - device_type = "pci"; - ranges = <0x81000000 0 0 0x48000000 0 0x00010000>, - <0x82000000 0 0x40000000 0x40000000 0 0x04000000>; - - phys = <&phy 1 6>; - phy-names = "pcie-phy"; - }; + #include + + pcie@18012000 { + compatible = "brcm,iproc-pcie"; + reg = <0x18012000 0x1000>; + + #interrupt-cells = <1>; + interrupt-map-mask = <0 0 0 0>; + interrupt-map = <0 0 0 0 &gic GIC_SPI 100 IRQ_TYPE_NONE>; + + linux,pci-domain = <0>; + + bus-range = <0x00 0xff>; + + #address-cells = <3>; + #size-cells = <2>; + device_type = "pci"; + ranges = <0x81000000 0 0 0x28000000 0 0x00010000>, + <0x82000000 0 0x20000000 0x20000000 0 0x04000000>; + + phys = <&phy 0 5>; + phy-names = "pcie-phy"; + + brcm,pcie-ob; + brcm,pcie-ob-axi-offset = <0x00000000>; + + msi-parent = <&msi0>; + + /* iProc event queue based MSI */ + msi0: msi { + compatible = "brcm,iproc-msi"; + msi-controller; + interrupt-parent = <&gic>; + interrupts = , + , + , + ; + }; + }; + - | + pcie@18013000 { + compatible = "brcm,iproc-pcie"; + reg = <0x18013000 0x1000>; + + #interrupt-cells = <1>; + interrupt-map-mask = <0 0 0 0>; + interrupt-map = <0 0 0 0 &gic GIC_SPI 106 IRQ_TYPE_NONE>; + + linux,pci-domain = <1>; + + bus-range = <0x00 0xff>; + + #address-cells = <3>; + #size-cells = <2>; + device_type = "pci"; + ranges = <0x81000000 0 0 0x48000000 0 0x00010000>, + <0x82000000 0 0x40000000 0x40000000 0 0x04000000>; + + phys = <&phy 1 6>; + phy-names = "pcie-phy"; };