From patchwork Tue Sep 26 04:09:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Roesch X-Patchwork-Id: 144706 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp1660254vqu; Mon, 25 Sep 2023 21:14:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE1MlveEFM8qej+nhq8xbozfNK0iR2N2NKTaJUJeFtPlzEpwvYIRMCN1Bqh0ZWuuKK2seKA X-Received: by 2002:a05:6808:2122:b0:3ae:a81:55a9 with SMTP id r34-20020a056808212200b003ae0a8155a9mr12167909oiw.24.1695701673020; Mon, 25 Sep 2023 21:14:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695701672; cv=none; d=google.com; s=arc-20160816; b=Ty+/v+MzCAhHjKIWZCncls7rvQgq2pmDq9xC7JXl9fRutBOv7iZmbNDNFv06KCi5h+ SFRoJPZpTaMDR+0DtbH5IRXi0Ka8Vc2OKCh1Ba+z2x8a4XqMt2si4jz239IMnsyGeHzy sbO4Chvr9+ctCr83P2ZVZFvH1i3swfRB4CCOnyteOAolnvaP3PIKVvCDTyGmV9zxKvA3 FXN97wrqw8nkpBb0QhJuEe9YsXRbQOIFMN4Ih3Owa2Sp8s7qEWsRV2Boiv+kd5meAaVi 5eljSFL6CxBA1AfTa4tSSlEwu5tFv23qHO0yT+/dzSKN8dSuKuv31LzaiuDfk/5GB0k8 pGZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=rEeKjj+nCu8+n8S1jluBJxwJZhUI2GEoXKLMBjiuJJY=; fh=sS+J4OyOC0EcVLWJpS3mBHGeO+0+dYZJ+ImCUfzsrH4=; b=doXza2AmwLwNPsVC0O/meg+DrKg0ep8ZJq9ZB+QeKFsQD+IadoaIb3b91x3GZ4h9YO ew4VfqCJ2hkwBJv6a2DyXKi/EnTKJxtPvs4FU0lR1ceCbuEvGzzS1Ck6lgXFrh4nmb47 BqFM+sx1haO5Dty/SYJSkBWB/MQhCRKPoG9U4uEoGaqaCfAbM2d84AVR16vok8FEwmkj E42qonmL6CoFcyMlYCuwMINYOA8cy8zMbZLB3zOOmCrneMdCvz1/hfZ/iQfy8dnKIL2g I2fea+7qn4/oZTuYwbeImPms/mnqu4YMG2MXztE7uYQigRigP+LD09qm82u6PTP5YW5P hIXQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id ds10-20020a056a004aca00b00690da053918si11275861pfb.4.2023.09.25.21.14.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 21:14:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 8B2A18226F11; Mon, 25 Sep 2023 21:10:32 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233559AbjIZEKN (ORCPT + 27 others); Tue, 26 Sep 2023 00:10:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233231AbjIZEKF (ORCPT ); Tue, 26 Sep 2023 00:10:05 -0400 Received: from 66-220-144-178.mail-mxout.facebook.com (66-220-144-178.mail-mxout.facebook.com [66.220.144.178]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 385B7F2 for ; Mon, 25 Sep 2023 21:09:59 -0700 (PDT) Received: by devbig1114.prn1.facebook.com (Postfix, from userid 425415) id 82FD9C8F2446; Mon, 25 Sep 2023 21:09:44 -0700 (PDT) From: Stefan Roesch To: kernel-team@fb.com Cc: shr@devkernel.io, akpm@linux-foundation.org, david@redhat.com, hannes@cmpxchg.org, riel@surriel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH v3 2/4] mm/ksm: add pages_skipped metric Date: Mon, 25 Sep 2023 21:09:37 -0700 Message-Id: <20230926040939.516161-3-shr@devkernel.io> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20230926040939.516161-1-shr@devkernel.io> References: <20230926040939.516161-1-shr@devkernel.io> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 25 Sep 2023 21:10:32 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778072077945287479 X-GMAIL-MSGID: 1778072077945287479 This change adds the "pages skipped" metric. To be able to evaluate how successful smart page scanning is, the pages skipped metric can be compared to the pages scanned metric. The pages skipped metric is a cumulative counter. The counter is stored under /sys/kernel/mm/ksm/pages_skipped. Signed-off-by: Stefan Roesch Reviewed-by: David Hildenbrand --- mm/ksm.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/mm/ksm.c b/mm/ksm.c index d65eb48f9a13..3de130d170b7 100644 --- a/mm/ksm.c +++ b/mm/ksm.c @@ -293,6 +293,9 @@ static bool ksm_smart_scan; /* The number of zero pages which is placed by KSM */ unsigned long ksm_zero_pages; +/* The number of pages that have been skipped due to "smart scanning" */ +static unsigned long ksm_pages_skipped; + #ifdef CONFIG_NUMA /* Zeroed when merging across nodes is not allowed */ static unsigned int ksm_merge_across_nodes = 1; @@ -2376,6 +2379,7 @@ static bool should_skip_rmap_item(struct page *page, } /* Skip this page */ + ksm_pages_skipped++; rmap_item->remaining_skips--; remove_rmap_item_from_tree(rmap_item); return true; @@ -3463,6 +3467,13 @@ static ssize_t pages_volatile_show(struct kobject *kobj, } KSM_ATTR_RO(pages_volatile); +static ssize_t pages_skipped_show(struct kobject *kobj, + struct kobj_attribute *attr, char *buf) +{ + return sysfs_emit(buf, "%lu\n", ksm_pages_skipped); +} +KSM_ATTR_RO(pages_skipped); + static ssize_t ksm_zero_pages_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf) { @@ -3560,6 +3571,7 @@ static struct attribute *ksm_attrs[] = { &pages_sharing_attr.attr, &pages_unshared_attr.attr, &pages_volatile_attr.attr, + &pages_skipped_attr.attr, &ksm_zero_pages_attr.attr, &full_scans_attr.attr, #ifdef CONFIG_NUMA