| Message ID | 20230925151812.142480-1-kieran.bingham+renesas@ideasonboard.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp1531325vqu;
Mon, 25 Sep 2023 15:48:01 -0700 (PDT)
X-Google-Smtp-Source:
AGHT+IHLk4V2+uCdYvlICE7L1QrRKqv9NB14/fDMKENuWwsY3TtxwkOq5sNGT/NdcptPo9QXykfH
X-Received: by 2002:a05:6870:c10a:b0:1d5:6161:76f2 with SMTP id
f10-20020a056870c10a00b001d5616176f2mr10226691oad.27.1695682080906;
Mon, 25 Sep 2023 15:48:00 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1695682080; cv=none;
d=google.com; s=arc-20160816;
b=ImNL6nxKbVbFqw19J8GLKoTZD8kdIWOMe0c0Fn2ngiopKgbXZkp8ZpD1t3qeLgIEJu
P/W0rwXda4pkITHPDQOk24ty+rqtiEHTf3j66lQY12+e7Rcvkr+WzaU8e6VpS9CuXSNO
9oP++Q76UGKAe98z3mDB1yedYATPM0+VEs3DDTaihMvPxXWIOUcWXHVUfMlhH79JGbHr
v7DY+WAbMdicgRypWwCpSwh+7r2H6S8UrU1kUXKaQsHldpG6qpFu6FDRZCawiOr4psm9
Hs4HLA5WFalF1Wne2B0FKjGPuL8UnWEiU241lJShR8VmCcK0jZ1Jit2GHYhp3yfgO4aM
7tIw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=UFXRQ1KsC0Gi0apSO7TRuCPrp6qw3DNanSMS6MaPrGE=;
fh=qgvo2NtZmaCqeKfJWD6yVFHTNeocvXdceOnTP30l19U=;
b=R1v1mQuGkQX30WXIJe89NX9EzBGY0ewEIiOB9pviaYaQO6fHz/YXqqRA2v5Z5/vQNc
KUkkbdTlP1G4slKfEPUngwmkZ2/Jk55FvE6Q11sprJGAcoBvpQ0G/HwTY7bFFZt3FMLh
7rXvnunb/1puB2NJ+BoyagMBq27pzDMpsI6PcATfl47jCPKBMpmFsn8hIy1rkGkXHUPu
hmflXnUdNSjHpH6Dae8RUHLpV4H0A1e54yFb4IPTZ85YBgn4Tslm92NkYFb6gQ01ODER
7Ho7RjVhcyc02vk9bxWHmn23Xs2PDj4doXtPlmwPv5wfODYKRTt94eZKq+eeOGwDTGnX
iCkA==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail
header.b=oMiBoohc;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 23.128.96.33 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33])
by mx.google.com with ESMTPS id
y2-20020a655b42000000b00578889362a2si10416664pgr.663.2023.09.25.15.48.00
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 25 Sep 2023 15:48:00 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Authentication-Results: mx.google.com;
dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail
header.b=oMiBoohc;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 23.128.96.33 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0])
by lipwig.vger.email (Postfix) with ESMTP id 9D1D981CFF3B;
Mon, 25 Sep 2023 08:18:39 -0700 (PDT)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S232608AbjIYPS3 (ORCPT <rfc822;pusanteemu@gmail.com> + 29 others);
Mon, 25 Sep 2023 11:18:29 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34712 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S232716AbjIYPS0 (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Mon, 25 Sep 2023 11:18:26 -0400
Received: from perceval.ideasonboard.com (perceval.ideasonboard.com
[213.167.242.64])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0BD4103
for <linux-kernel@vger.kernel.org>;
Mon, 25 Sep 2023 08:18:19 -0700 (PDT)
Received: from Monstersaurus.local
(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net [82.37.23.78])
by perceval.ideasonboard.com (Postfix) with ESMTPSA id 79602291;
Mon, 25 Sep 2023 17:16:36 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;
s=mail; t=1695654997;
bh=gozTk7lyY/6ypu7+3Un1hCKYcvFcJxTXtAmzQjFkaLI=;
h=From:To:Cc:Subject:Date:From;
b=oMiBoohc8SIuoAcuTVI3625y4eV251g502y9wyABX81qFHNcXv0OXZmQCn68Hm9B2
/+YjBsp9NieAjWt2pbAiNdcKICoDcNLwxM3M3fwQB8cfWTXOriFk6ZZIsrEHEZCE8d
RBSq/oqc6qc5P3zs2n51aqV7Xqr52laf/obKCN8g=
From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org,
Florian Fainelli <florian.fainelli@broadcom.com>
Cc: Kieran Bingham <kieran.bingham@ideasonboard.com>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Maxime Ripard <mripard@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
Joel Savitz <jsavitz@redhat.com>,
Yang Yingliang <yangyingliang@huawei.com>,
Yuan Can <yuancan@huawei.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Nicolas Saenz Julienne <nsaenz@kernel.org>
Subject: [PATCH] firmware: raspberrypi: Fix devm_rpi_firmware_get
documentation
Date: Mon, 25 Sep 2023 16:18:11 +0100
Message-Id: <20230925151812.142480-1-kieran.bingham+renesas@ideasonboard.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test,
not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]);
Mon, 25 Sep 2023 08:18:39 -0700 (PDT)
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1778051533877489450
X-GMAIL-MSGID: 1778051533877489450
|
| Series |
firmware: raspberrypi: Fix devm_rpi_firmware_get documentation
|
|
Commit Message
Kieran Bingham
Sept. 25, 2023, 3:18 p.m. UTC
From: Kieran Bingham <kieran.bingham@ideasonboard.com> The function documentation for devm_rpi_firmware_get() was missing a description for the dev parameter. Provide it and clear the warning produced here. Fixes: f663204c9a1f ("firmware: raspberrypi: Introduce devm_rpi_firmware_get()") Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> --- drivers/firmware/raspberrypi.c | 1 + 1 file changed, 1 insertion(+)
Comments
From: Florian Fainelli <f.fainelli@gmail.com> On Mon, 25 Sep 2023 16:18:11 +0100, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> wrote: > From: Kieran Bingham <kieran.bingham@ideasonboard.com> > > The function documentation for devm_rpi_firmware_get() was missing > a description for the dev parameter. > > Provide it and clear the warning produced here. > > Fixes: f663204c9a1f ("firmware: raspberrypi: Introduce devm_rpi_firmware_get()") > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > --- Applied to https://github.com/Broadcom/stblinux/commits/drivers/next, thanks! -- Florian
diff --git a/drivers/firmware/raspberrypi.c b/drivers/firmware/raspberrypi.c index f66efaa5196d..4cd290a60fba 100644 --- a/drivers/firmware/raspberrypi.c +++ b/drivers/firmware/raspberrypi.c @@ -378,6 +378,7 @@ EXPORT_SYMBOL_GPL(rpi_firmware_get); /** * devm_rpi_firmware_get - Get pointer to rpi_firmware structure. + * @dev: The firmware device structure * @firmware_node: Pointer to the firmware Device Tree node. * * Returns NULL is the firmware device is not ready.