Message ID | 20230925111022.3626362-1-geert+renesas@glider.be |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp1158373vqu; Mon, 25 Sep 2023 05:06:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHkZoeZqAWYTiW91cYKqa7WRA+csHxhoEXF26d0EwjSWK8TjO+wEySWFT9gEvygb6g8Nn7u X-Received: by 2002:a05:6358:4319:b0:13f:7e5:b397 with SMTP id r25-20020a056358431900b0013f07e5b397mr2856566rwc.7.1695643592706; Mon, 25 Sep 2023 05:06:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695643592; cv=none; d=google.com; s=arc-20160816; b=rYehR7DOOl4QbGCEpNbc92euqsrlRkpVPf9dMuhRZUvL44rvZE+P9vvxz+8Cg/6e/o aJZLpTBEPLxMfcIoyLqIUQk04D4AuY8mU9yA5kpxa0oRhuhpmg4mSneoN6SnK0AljvnG pE3Efkgg6SL2T2bXZ3WLFM96Ms3tdr7ZacvAfdPpclxSZbpG0W6c4VidKeFPAGTclbVO BK7Pb+Rvub5Y2XkYD94Tq/zzx2t6jKNVHL3Xr8MuGOwKw5za1vZLxeNcKflB7uPd4T1T pAjQV/8lYkkiS5SN/EmHIfI0GcTZLfeZVuxbJGtjK0BJrZz4mdhEZ0WwuCJGGmaBRs9M kRAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=hqvwk+V+MiOmBOPwQ3GwlbFjoETzU3PU0k8AwH6ZJ/Y=; fh=1vZZeJqz4pbqC6lbj1VmBOeflcPeltnLmefNAMEwgpE=; b=fK24rtw55b8oZOJQvMXjKzGf/i0y2QfhYR9+dR22gxTVqGwmcT2qN6qNGHqom0Lt9y KX9spZdWJmKpj6IuPI1Cqs5aGOy6OTxXIzLGLVuLP92gAj6NOpTlss2LWvZXaGXlAOJL Q1AJdDTQ//NN+Wm88tfLM/yOd72ZjQaauZ3Cglq0lARinzOnx6ZQnfM2ebGM+vL9zLN+ hewEQcWdNviR62nisNGQ0h12o5kRkrR+rZiSFUWgKKLyrvMKak9pJ/WZH5IqoYpmS239 vgwMjLmGdGHUm4mvTc5HGmV4iSEqBDnJFefwsIs+vvHqk7VeP0zie6MfjkxTU7CvoTZB 74qw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id 82-20020a630155000000b00563f4e46f7esi9417031pgb.287.2023.09.25.05.06.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 05:06:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 19BA980267EA; Mon, 25 Sep 2023 04:11:04 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231133AbjIYLKp (ORCPT <rfc822;pusanteemu@gmail.com> + 29 others); Mon, 25 Sep 2023 07:10:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229556AbjIYLKg (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 25 Sep 2023 07:10:36 -0400 Received: from andre.telenet-ops.be (andre.telenet-ops.be [IPv6:2a02:1800:120:4::f00:15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBCCFCE for <linux-kernel@vger.kernel.org>; Mon, 25 Sep 2023 04:10:28 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed40:ee18:727e:6235:2ac2]) by andre.telenet-ops.be with bizsmtp id qBAP2A00E4XpEKH01BAP7T; Mon, 25 Sep 2023 13:10:26 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from <geert@linux-m68k.org>) id 1qkjTT-004Xi7-4c; Mon, 25 Sep 2023 13:10:23 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from <geert@linux-m68k.org>) id 1qkjTr-00FDNv-27; Mon, 25 Sep 2023 13:10:23 +0200 From: Geert Uytterhoeven <geert+renesas@glider.be> To: Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>, Thomas Zimmermann <tzimmermann@suse.de>, Sam Ravnborg <sam@ravnborg.org>, Daniel Thompson <daniel.thompson@linaro.org> Cc: linux-sh@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven <geert+renesas@glider.be>, kernel test robot <lkp@intel.com> Subject: [PATCH] sh: ecovec24: Rename missed backlight field from fbdev to dev Date: Mon, 25 Sep 2023 13:10:22 +0200 Message-Id: <20230925111022.3626362-1-geert+renesas@glider.be> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 25 Sep 2023 04:11:04 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778011175788028479 X-GMAIL-MSGID: 1778011175788028479 |
Series |
sh: ecovec24: Rename missed backlight field from fbdev to dev
|
|
Commit Message
Geert Uytterhoeven
Sept. 25, 2023, 11:10 a.m. UTC
One instance of gpio_backlight_platform_data.fbdev was renamed, but the
second instance was forgotten, causing a build failure:
arch/sh/boards/mach-ecovec24/setup.c: In function ‘arch_setup’:
arch/sh/boards/mach-ecovec24/setup.c:1223:37: error: ‘struct gpio_backlight_platform_data’ has no member named ‘fbdev’; did you mean ‘dev’?
1223 | gpio_backlight_data.fbdev = NULL;
| ^~~~~
| dev
Fix this by updating the second instance.
Fixes: ed369def91c1579a ("backlight/gpio_backlight: Rename field 'fbdev' to 'dev'")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202309231601.Uu6qcRnU-lkp@intel.com/
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/sh/boards/mach-ecovec24/setup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi Am 25.09.23 um 13:10 schrieb Geert Uytterhoeven: > One instance of gpio_backlight_platform_data.fbdev was renamed, but the > second instance was forgotten, causing a build failure: > > arch/sh/boards/mach-ecovec24/setup.c: In function ‘arch_setup’: > arch/sh/boards/mach-ecovec24/setup.c:1223:37: error: ‘struct gpio_backlight_platform_data’ has no member named ‘fbdev’; did you mean ‘dev’? > 1223 | gpio_backlight_data.fbdev = NULL; > | ^~~~~ > | dev > > Fix this by updating the second instance. > > Fixes: ed369def91c1579a ("backlight/gpio_backlight: Rename field 'fbdev' to 'dev'") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202309231601.Uu6qcRnU-lkp@intel.com/ > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Thomas Zimmermann <tzimmermann@suse.de> Sorry for missing this driver in the original patch. Best regards Thomas > --- > arch/sh/boards/mach-ecovec24/setup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/sh/boards/mach-ecovec24/setup.c b/arch/sh/boards/mach-ecovec24/setup.c > index 3be293335de54512..7a788d44cc73496c 100644 > --- a/arch/sh/boards/mach-ecovec24/setup.c > +++ b/arch/sh/boards/mach-ecovec24/setup.c > @@ -1220,7 +1220,7 @@ static int __init arch_setup(void) > lcdc_info.ch[0].num_modes = ARRAY_SIZE(ecovec_dvi_modes); > > /* No backlight */ > - gpio_backlight_data.fbdev = NULL; > + gpio_backlight_data.dev = NULL; > > gpio_set_value(GPIO_PTA2, 1); > gpio_set_value(GPIO_PTU1, 1); -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)
On Mon, 2023-09-25 at 13:10 +0200, Geert Uytterhoeven wrote: > One instance of gpio_backlight_platform_data.fbdev was renamed, but the > second instance was forgotten, causing a build failure: > > arch/sh/boards/mach-ecovec24/setup.c: In function ‘arch_setup’: > arch/sh/boards/mach-ecovec24/setup.c:1223:37: error: ‘struct gpio_backlight_platform_data’ has no member named ‘fbdev’; did you mean ‘dev’? > 1223 | gpio_backlight_data.fbdev = NULL; > | ^~~~~ > | dev > > Fix this by updating the second instance. > > Fixes: ed369def91c1579a ("backlight/gpio_backlight: Rename field 'fbdev' to 'dev'") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202309231601.Uu6qcRnU-lkp@intel.com/ > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > arch/sh/boards/mach-ecovec24/setup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/sh/boards/mach-ecovec24/setup.c b/arch/sh/boards/mach-ecovec24/setup.c > index 3be293335de54512..7a788d44cc73496c 100644 > --- a/arch/sh/boards/mach-ecovec24/setup.c > +++ b/arch/sh/boards/mach-ecovec24/setup.c > @@ -1220,7 +1220,7 @@ static int __init arch_setup(void) > lcdc_info.ch[0].num_modes = ARRAY_SIZE(ecovec_dvi_modes); > > /* No backlight */ > - gpio_backlight_data.fbdev = NULL; > + gpio_backlight_data.dev = NULL; > > gpio_set_value(GPIO_PTA2, 1); > gpio_set_value(GPIO_PTU1, 1); Reviewed-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
On Mon, 2023-09-25 at 13:10 +0200, Geert Uytterhoeven wrote: > One instance of gpio_backlight_platform_data.fbdev was renamed, but the > second instance was forgotten, causing a build failure: > > arch/sh/boards/mach-ecovec24/setup.c: In function ‘arch_setup’: > arch/sh/boards/mach-ecovec24/setup.c:1223:37: error: ‘struct gpio_backlight_platform_data’ has no member named ‘fbdev’; did you mean ‘dev’? > 1223 | gpio_backlight_data.fbdev = NULL; > | ^~~~~ > | dev > > Fix this by updating the second instance. > > Fixes: ed369def91c1579a ("backlight/gpio_backlight: Rename field 'fbdev' to 'dev'") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202309231601.Uu6qcRnU-lkp@intel.com/ > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > arch/sh/boards/mach-ecovec24/setup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/sh/boards/mach-ecovec24/setup.c b/arch/sh/boards/mach-ecovec24/setup.c > index 3be293335de54512..7a788d44cc73496c 100644 > --- a/arch/sh/boards/mach-ecovec24/setup.c > +++ b/arch/sh/boards/mach-ecovec24/setup.c > @@ -1220,7 +1220,7 @@ static int __init arch_setup(void) > lcdc_info.ch[0].num_modes = ARRAY_SIZE(ecovec_dvi_modes); > > /* No backlight */ > - gpio_backlight_data.fbdev = NULL; > + gpio_backlight_data.dev = NULL; > > gpio_set_value(GPIO_PTA2, 1); > gpio_set_value(GPIO_PTU1, 1); Applied to my sh-linux tree. Thanks, Adrian
diff --git a/arch/sh/boards/mach-ecovec24/setup.c b/arch/sh/boards/mach-ecovec24/setup.c index 3be293335de54512..7a788d44cc73496c 100644 --- a/arch/sh/boards/mach-ecovec24/setup.c +++ b/arch/sh/boards/mach-ecovec24/setup.c @@ -1220,7 +1220,7 @@ static int __init arch_setup(void) lcdc_info.ch[0].num_modes = ARRAY_SIZE(ecovec_dvi_modes); /* No backlight */ - gpio_backlight_data.fbdev = NULL; + gpio_backlight_data.dev = NULL; gpio_set_value(GPIO_PTA2, 1); gpio_set_value(GPIO_PTU1, 1);