From patchwork Mon Sep 25 09:54:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 144368 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp1115159vqu; Mon, 25 Sep 2023 03:44:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEDa9rWVX8NJD3FFEmuiJPFgH4FfJj9GbUwpLtZuN5c0bpazhb4R6bpC6z/zXuH9bDBqoUr X-Received: by 2002:a17:902:f688:b0:1c0:bf60:ba4f with SMTP id l8-20020a170902f68800b001c0bf60ba4fmr8224907plg.4.1695638696659; Mon, 25 Sep 2023 03:44:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695638696; cv=none; d=google.com; s=arc-20160816; b=UqV+EKCNPK3egoqadQzDu+5lsJErGWboRPNFT5O5n8/ynPiJvizvS12is3G+WmISzu LjqybknXFY2XlitpZmbDthZus8plqPjh0tAQdPKeMMgeeoDSjAB+awyFBvA2p+4CVzzr p9cb4BJoJX5g+mM+2px7Nq32XaGmvoZcJcJo2aBBxEN/rQItEb3mXRPmQ1mA7Edx4R71 vgxKFQVSJl9DZ8jhabVdOw/qPgH4JkJjLmLKMJ0r6wwvUnYSzzOAbCHEnLLuiPimK4DQ lninXBZibVEkgeBZbk923FVQkJPQkLExNSr+I6niXLE8PUZwaXbldNmS749Z2X4GeYnf OhiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=nEaAGUEqZvOL2CjC4mcm3+ryHPPbkDSqHR3SFU5iIxM=; fh=EN/eMTn6WAITyhRpbFazeuYDaXUKAbmTII5FRbOS4Mg=; b=TBBlee9bz1O7AjkBSUTKrIn9As6GORjnB8+gCm3Mf6/icHrbpd/tRc91GQyPZtCawY HHL51B84akkmECxEAcbgThFvVubM5qFqV5woRO/ZlSVgmxIhl2di3gnXl7mOUYyW6GUv EU0gaDtchwBtcUaJc8BHpspoSjORD5u0jhiR2iyvs1n4DcsnG1jtDiPGr62ig28bzrRk t7dRqNXJq1AunzJcsHfjjlzG/G3mNKGBI7TVfn9cHLIuNUDriJhkTk62Rul4x/ZIrCoV JAdde5lMao1b+T5W5tXQkZoKdXBOS9IMOm4fL/iw33AzTjE5lOIcDenV/eguAfLL/tOn hKcA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id e15-20020a17090301cf00b001bc836180dcsi10065724plh.520.2023.09.25.03.44.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 03:44:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 5A4FB80A856E; Mon, 25 Sep 2023 02:55:58 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229851AbjIYJzs (ORCPT + 29 others); Mon, 25 Sep 2023 05:55:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbjIYJzp (ORCPT ); Mon, 25 Sep 2023 05:55:45 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A4DAA3 for ; Mon, 25 Sep 2023 02:55:39 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qkiJV-0007n8-Ri; Mon, 25 Sep 2023 11:55:37 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qkiJV-008pyz-Ei; Mon, 25 Sep 2023 11:55:37 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qkiJV-004dks-5Z; Mon, 25 Sep 2023 11:55:37 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Hitomi Hasegawa Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 08/40] soc/fujitsu: a64fx-diag: Convert to platform remove callback returning void Date: Mon, 25 Sep 2023 11:54:59 +0200 Message-Id: <20230925095532.1984344-9-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> References: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1878; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=saXqsLDHKnHalVQxew/MdBsH6YDXz3ImTwJq8YFGrKw=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlEVhIlQMyzfP/6okjPblsvnLY5ljbi40E89BdP TdBef3YVZSJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZRFYSAAKCRCPgPtYfRL+ TuRZB/9CAMDp4N6XKzi15yXUJ/0r+i6UjQAowApyp9OWmLwTPlhqHOLe5KtbxMmkeJpAYcOqxt+ UjEinBWWG3DXy36ZISIk9ggwuKVIQunoOXY6Cp9FH1dDUacIjWGDi4FgoIJ9c+s2Y7eD6EVxd/p bGcE4jDmYkpXwLA5I//CvB1LnXgkBAqImvd+TVqoW+OuexRkt+xF87LW71Qni39hupQi7Zq9fO8 YxkBLLxX/NqUuFb7km3fR+8l51WEXfVlLFOrWBe5DtPjHjHNbQtGV7mLC9LRGxyVUhbWGGYemCS j+g54ccFCLwqUBA+ObaRwRVKaPcAbLZts80N4Etx27+/tLRr X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 25 Sep 2023 02:55:58 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778006041980081106 X-GMAIL-MSGID: 1778006041980081106 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/soc/fujitsu/a64fx-diag.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/soc/fujitsu/a64fx-diag.c b/drivers/soc/fujitsu/a64fx-diag.c index 524fbfeb94e3..330901893577 100644 --- a/drivers/soc/fujitsu/a64fx-diag.c +++ b/drivers/soc/fujitsu/a64fx-diag.c @@ -116,7 +116,7 @@ static int a64fx_diag_probe(struct platform_device *pdev) return 0; } -static int a64fx_diag_remove(struct platform_device *pdev) +static void a64fx_diag_remove(struct platform_device *pdev) { struct a64fx_diag_priv *priv = platform_get_drvdata(pdev); @@ -127,8 +127,6 @@ static int a64fx_diag_remove(struct platform_device *pdev) free_nmi(priv->irq, NULL); else free_irq(priv->irq, NULL); - - return 0; } static const struct acpi_device_id a64fx_diag_acpi_match[] = { @@ -144,7 +142,7 @@ static struct platform_driver a64fx_diag_driver = { .acpi_match_table = ACPI_PTR(a64fx_diag_acpi_match), }, .probe = a64fx_diag_probe, - .remove = a64fx_diag_remove, + .remove_new = a64fx_diag_remove, }; module_platform_driver(a64fx_diag_driver);