From patchwork Mon Sep 25 09:54:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 144352 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp1098464vqu; Mon, 25 Sep 2023 03:07:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHAqaYqbp4gHDkmnQ0y9ePJcIMkCXabeSwJWDLNp2jXLzIe5quXmTqu0/q8EEZGNgWjn7ED X-Received: by 2002:a17:90b:154:b0:26d:20ef:1d32 with SMTP id em20-20020a17090b015400b0026d20ef1d32mr3873608pjb.38.1695636449283; Mon, 25 Sep 2023 03:07:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695636449; cv=none; d=google.com; s=arc-20160816; b=Zkg5kVYvFUNGlLy5/dUvj6GOvvV2mPdCOMP7atOEUjllQGGsB3mja3HPt9t6+0t0yd QICO3fzOAKojcHWC8wR+GojXnMsBD1TQrl3Z7DuekZZ5XeENUV6uXfpkNm8Nf7CzSL2W t4+7I7yvp8pgaZ17OGl15bOEemFhwk7rAwLxeHLtJAqp7KYSHOKDpIi7jNNTy7BmsFn1 3vM68ul2zPJAORJV1x+kE2CLH7oJBH+yf+R0QidJD+4nf9D24SWBstdRzxu+8ciDQ5Sq ERKoaCwu4j+TkdOrfHT1DAPdhrAJAnUj+CjOb+HzLdvTpFKhNbDzBHGtBQJjzfwZxdTp PKYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=OCF9I9jLtJPMoFK8pzZqCeap0Mj3e2yp3cvxGNJdteg=; fh=zFIuurgTf6ZOteKSFjg0pMbpNQ/9UZBeYxK8kiubgyA=; b=Rb7tPgS0DmSIRjYUY+7Z3SJeLIAzXDcxpegbolFb4j8lFCTSNWso/RsU1Woi/4pJhn Nz60jc704/nBBhDnFwTR4/K2sm3dhfzExr1bLFIhvkjlANtjJ7jUdE8T0cWv5NZR3REy b9op7cD0RIPfasvU33V0PCMTEeATUx9rwYJPD42OWtiUYKyZOWOpLkpJ06I5/zeLP8iR WOGGEvQNKHdJQ1KiYDt8RT0Lp+whL6Ba8LtRFzPGaG8AzJjDIG23BAZdlhJB1MxIxdb6 oazEqPpADZsT3/cy/BNoN4Nro8VLwaF9lq18bmFs/6hlsr+pm/8cIOHao52aH0LyaHWu Z65Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id o10-20020a17090ac08a00b0026806ed3fd8si9808277pjs.71.2023.09.25.03.07.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 03:07:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id CAB8680A5FB2; Mon, 25 Sep 2023 02:58:12 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231337AbjIYJ6G (ORCPT + 29 others); Mon, 25 Sep 2023 05:58:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230442AbjIYJ4Y (ORCPT ); Mon, 25 Sep 2023 05:56:24 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 315931B3 for ; Mon, 25 Sep 2023 02:55:54 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qkiJV-0007m7-H5; Mon, 25 Sep 2023 11:55:37 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qkiJU-008pyn-IQ; Mon, 25 Sep 2023 11:55:36 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qkiJU-004dkc-97; Mon, 25 Sep 2023 11:55:36 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Joel Stanley Cc: Andrew Jeffery , Arnd Bergmann , Rob Herring , Zev Weiss , linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 04/40] soc/aspeed: aspeed-uart-routing: Convert to platform remove callback returning void Date: Mon, 25 Sep 2023 11:54:55 +0200 Message-Id: <20230925095532.1984344-5-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> References: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1943; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=Dp6z+QS6f+BYha8PjTOhguNb6MQfm1ovSiqKV9hX2h4=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlEVhEDSuLBlvM8gieK9jXohUdapwIH+hiYb4hy aiG/QEwFEGJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZRFYRAAKCRCPgPtYfRL+ TlRbB/9A2LAHx8RySGAgbLbJ8MlzL2k1s7rTNPGGbJkPLkmNex9kVNnPPwajEiON0s8s7kTBAKC 1wD/b2E1kUJfaerSMsqbI0eLiRHfQZ8RrNiHt/U1/2mL1sZzE5lhb3qiVq4tfrL+KwX+hzV9Mdr sjOLm2OH6UluKyWV764xCygA01aJMnOTcCqHIZ8SaG/Vh44x755YDukvqAbcQ1ythtTxipk9+2S pbY5C/Es0/D6Vu9xNapnd2BJuqhUJdZzAz8UC89tbqnezgRBgN1cGEY7yA2lNvq1oBYb7LMIXg9 G10Ke9g15LerIWVCr6bhyew3OBir105Uex4voBQqUbQQ28M/ X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 25 Sep 2023 02:58:12 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778003684962804763 X-GMAIL-MSGID: 1778003684962804763 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Andrew Jeffery --- drivers/soc/aspeed/aspeed-uart-routing.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/soc/aspeed/aspeed-uart-routing.c b/drivers/soc/aspeed/aspeed-uart-routing.c index 3a4c1f28cb34..a2195f062e01 100644 --- a/drivers/soc/aspeed/aspeed-uart-routing.c +++ b/drivers/soc/aspeed/aspeed-uart-routing.c @@ -565,14 +565,12 @@ static int aspeed_uart_routing_probe(struct platform_device *pdev) return 0; } -static int aspeed_uart_routing_remove(struct platform_device *pdev) +static void aspeed_uart_routing_remove(struct platform_device *pdev) { struct device *dev = &pdev->dev; struct aspeed_uart_routing *uart_routing = platform_get_drvdata(pdev); sysfs_remove_group(&dev->kobj, uart_routing->attr_grp); - - return 0; } static const struct of_device_id aspeed_uart_routing_table[] = { @@ -591,7 +589,7 @@ static struct platform_driver aspeed_uart_routing_driver = { .of_match_table = aspeed_uart_routing_table, }, .probe = aspeed_uart_routing_probe, - .remove = aspeed_uart_routing_remove, + .remove_new = aspeed_uart_routing_remove, }; module_platform_driver(aspeed_uart_routing_driver);