From patchwork Mon Sep 25 09:55:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 144332 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp1096841vqu; Mon, 25 Sep 2023 03:04:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEO53CFt50dcLfhFvkM3QZx6Ud7x5Pg8OFYxPmJj7JJ+UfFb1yCFyQECzO9gGaVvVRg65t8 X-Received: by 2002:a17:90a:51a5:b0:263:ebab:a152 with SMTP id u34-20020a17090a51a500b00263ebaba152mr3880204pjh.19.1695636263859; Mon, 25 Sep 2023 03:04:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695636263; cv=none; d=google.com; s=arc-20160816; b=S1A6h0Vp4bukh4ydY4LnbNtvCm+1ta7nAWvw06KepfwbJVc9HvTUBi1YEz7m9s1jm7 rlsaJ4wfGbRh9sX7+JlseXDGPdpSQk83WiV4DNl0ej/JzhrUcmnI/aGssVVeZlqLEJXf PzzuKM1QjxmYegBcEJwJJoi4OZELFaUsp3J+eTScuCL1T422onRdKxGPVfWTomYjOLQt G9w9RSYJVHw1T/aVm7/0cbRwYugDcc7MFRqUWk2sSca9yun8L806NCoZS9X8ffMvc2a9 fVGZRD7+PRbkP3pa7js+UDDPEgFcjlop6CTyYP5XAA2lspphk1qi68yQOT2jWq+Yxv6B QFGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=y8tMzqL4s6x0LrTjDeTI4zum9Tn3qzTrF6rB+DndwyM=; fh=MY6fc1dLfQO8CUmFaPh3oHmz3pAqJs+Epn2Slqo9l20=; b=wwVQFUnnrtwqxyKNeik7UpWkBbeUVMMXtwIg5WIiEP6LCYQkDRTPAXaXYhz+Ck3SIJ CvIHjFW5U9PJXBJqE9Of61jNUvGZwof1q7AGwK7+su9dlWjdsKthsb3f1xqh07hlQeHj /eeyCE4kQRE1pHyx+B1NuMFnUFhIezMsxEJPa6meDGPhc5w06HMyyn8zZaG6BZNgLczf VrbKdoSOfOAVh5RsnG2NY9xucRSKuyMwOZ/DZ21otmaIHUJuLYxscpBRyNh0z5g1jADS FCTPK1QDl4POKKqzjYTubbTe4MKcOrBRUoFNH1fkRop1+Un2Ikqm50Hdd6T2lH1ja4iH umqw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id w19-20020a17090a8a1300b00271a453203esi2728734pjn.130.2023.09.25.03.04.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 03:04:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 2F73B80BB6F3; Mon, 25 Sep 2023 02:58:32 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231340AbjIYJ6I (ORCPT + 29 others); Mon, 25 Sep 2023 05:58:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230379AbjIYJ4i (ORCPT ); Mon, 25 Sep 2023 05:56:38 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C043CDA for ; Mon, 25 Sep 2023 02:55:58 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qkiJc-0008BC-Vh; Mon, 25 Sep 2023 11:55:44 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qkiJc-008q1A-I2; Mon, 25 Sep 2023 11:55:44 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qkiJc-004dmw-8x; Mon, 25 Sep 2023 11:55:44 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Michal Simek Cc: Rob Herring , Ruan Jinjie , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 40/40] soc/xilinx: zynqmp_power: Convert to platform remove callback returning void Date: Mon, 25 Sep 2023 11:55:31 +0200 Message-Id: <20230925095532.1984344-41-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> References: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1887; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=gIpZ9diDZeuFvzB/S1auBzLsV7kwS6CbiHArr/4Amqs=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlEVhsmBIFeF96e2ej5WPmcUERrhYQkPD1S8gZD 6zHN1isOjOJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZRFYbAAKCRCPgPtYfRL+ TnImCACr+IZ5Ex28v9coHdnTaCVbz+D3NZEWm/YoHQ01dIkmhaUZcckq+JW1+w/fYuSaj87sE6o 4wkYX9zAKfqjWkZd1Ho6ObugY+5YFaWgn8qQ8Q6E5TDBBTM0cX6T5fTabMn8qiN1/9GgUahMJ0F xgyTLuuW2iTZfy1INrCYaMRs24qz+v5XnjuOk4Amwh5uvHb42mC8sx92Z1x5EgE+rtGM4NnKAzj IPAZBNlkNk1ikPUhz0NIdTAvWa4QzxVKm3+DAiy0fwKE+EVDjWeXu+rlR5OhBamynhnguxIroxf bmL4YRnPEGFnLEYS/o1zEZC6kvM4gXZJkvfU3DBjEXG0rgWX X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 25 Sep 2023 02:58:33 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778003490675455691 X-GMAIL-MSGID: 1778003490675455691 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/soc/xilinx/zynqmp_power.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/soc/xilinx/zynqmp_power.c b/drivers/soc/xilinx/zynqmp_power.c index c2c819701eec..9d27f850f491 100644 --- a/drivers/soc/xilinx/zynqmp_power.c +++ b/drivers/soc/xilinx/zynqmp_power.c @@ -275,7 +275,7 @@ static int zynqmp_pm_probe(struct platform_device *pdev) return 0; } -static int zynqmp_pm_remove(struct platform_device *pdev) +static void zynqmp_pm_remove(struct platform_device *pdev) { sysfs_remove_file(&pdev->dev.kobj, &dev_attr_suspend_mode.attr); if (event_registered) @@ -283,8 +283,6 @@ static int zynqmp_pm_remove(struct platform_device *pdev) if (!rx_chan) mbox_free_channel(rx_chan); - - return 0; } static const struct of_device_id pm_of_match[] = { @@ -295,7 +293,7 @@ MODULE_DEVICE_TABLE(of, pm_of_match); static struct platform_driver zynqmp_pm_platform_driver = { .probe = zynqmp_pm_probe, - .remove = zynqmp_pm_remove, + .remove_new = zynqmp_pm_remove, .driver = { .name = "zynqmp_power", .of_match_table = pm_of_match,