From patchwork Mon Sep 25 09:55:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 144331 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp1096819vqu; Mon, 25 Sep 2023 03:04:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFodyN6dz9Jryy2jaRtfyWE+Mh0WNzew9kSP3yEmldcdhWiRkvdLzfCadMT99Fjd7Sq3X8L X-Received: by 2002:a05:6808:140e:b0:3ae:4cad:91a0 with SMTP id w14-20020a056808140e00b003ae4cad91a0mr808881oiv.6.1695636261435; Mon, 25 Sep 2023 03:04:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695636261; cv=none; d=google.com; s=arc-20160816; b=MFAEP/ZqFv8ZXM0s7wRGLQfplFZem9PmD8YgHnQxlt94KBRM0fdujPAHVUze+pkihc gASEfrDgO2lUp4nXcS9UfYwT3yGv8TFsA4lszQ0XFKhC1Fw6J4bgldQXpIDhoXoVkNY2 sQCrPjjiJqtspYfT6OvDA/t+WZuXKYxu5gxYcv/LLhNiT1X9LOyecCwfe+Rn01HzUB68 Oxh3dYLSlZS/QctJbb9M0AGRSSR9H9371B1ZtZnhKK6VwjCKrj7+ZjfXZfwoQxkyCIvq jJ3bupOqbtOX/12LwZSuQsCA1d5BPIKSN1rJAB4RSF65zf6lEb8/LqpeUGcXQn3Weoku sG9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=DSW+bXqEWEY/zXYXMzH0nAcdPTSHJ9enR7wBOOipbcY=; fh=AOovw+M3JgsWSwJq2DLVB5ADiz1uuv2AcUunvu3FHNI=; b=pdtDUTfit07AeYDiKQSLAWA6Wcsm491uhOuEXCP1WM3zTDMLNIJpJpWBUsrv0jygbT UGymWIUjRQisdxWJCsbj8Ph9kLbg+Za1dE9KBCEJnMzBhcU3N87Va3r0H8cnJvKM0V/r YoJj5GU04CXx7cXeBSIVrXGMg9wJI7b9UcmAHwq3CJ7/Zt5L+MlQ+6hUDy/caO++1BE4 F5/PmSXGz6KHRLUJFO7bGoI4ghd7iXtk77o5hVWx+BcEmw0+fhsDuESNiKRe3n3Yb84D /xZHYVWmiYNUXrEzHGNIo0XBebHiZ+bV+hZMHrhXwTooUUr+QQdhKGmbWVgTcSnarNOu v0dw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id w29-20020a63161d000000b005702257f32csi9363087pgl.840.2023.09.25.03.04.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 03:04:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 4E90B80B19C1; Mon, 25 Sep 2023 02:57:01 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231124AbjIYJ4r (ORCPT + 29 others); Mon, 25 Sep 2023 05:56:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230097AbjIYJzy (ORCPT ); Mon, 25 Sep 2023 05:55:54 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A937CFE for ; Mon, 25 Sep 2023 02:55:47 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qkiJc-0008AT-8C; Mon, 25 Sep 2023 11:55:44 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qkiJb-008q0x-Rd; Mon, 25 Sep 2023 11:55:43 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qkiJb-004dmk-Gk; Mon, 25 Sep 2023 11:55:43 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Nishanth Menon , Santosh Shilimkar Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 37/40] soc/ti: pruss: Convert to platform remove callback returning void Date: Mon, 25 Sep 2023 11:55:28 +0200 Message-Id: <20230925095532.1984344-38-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> References: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1712; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=c709ql2KZbhU/Nl8vVPOXcOtp/pbM4UUu61jct04VQs=; b=owGbwMvMwMXY3/A7olbonx/jabUkhlTBiMyND1a/8WSSXy+oJMj0pyN86clHNreORvveyv9cl /7uhH5KJ6MxCwMjF4OsmCKLfeOaTKsqucjOtf8uwwxiZQKZwsDFKQATmSnJ/k/HVTDCsJ2Zf9Ms mbz+CWt7NYPNpnZc1wlNS7rqNsdUeo9itffT18sDuj3DrzsWdspdirms+DQqvuhM32kVBW0ZMdd v33fVM9xu8dO9WDXLJ2lh1gqf3gOmER3/Df3s221rqkUEJBUytxWKvvjXJvLspN1fxsL3JWr7bb 4IF+iLz5itFf9lo+nL3ikrTsulil3U25ihd3pTo0UcSyXDj9yjG2candDx1quobVV/FlDCf7ggN OGndndt9fVTxnbhqXVWn9yPrJc+yv9+655fk1vlp35O4rjQ+mKD87L3Znbp73/f/T+L/ceikrhY ox82D5fssZV9sUX106eQyLdW864JBdxWKntx/E79QWkWAA== X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 25 Sep 2023 02:57:01 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778003488865799081 X-GMAIL-MSGID: 1778003488865799081 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/soc/ti/pruss.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c index f49f8492dde5..24a42e0b645c 100644 --- a/drivers/soc/ti/pruss.c +++ b/drivers/soc/ti/pruss.c @@ -565,7 +565,7 @@ static int pruss_probe(struct platform_device *pdev) return ret; } -static int pruss_remove(struct platform_device *pdev) +static void pruss_remove(struct platform_device *pdev) { struct device *dev = &pdev->dev; @@ -573,8 +573,6 @@ static int pruss_remove(struct platform_device *pdev) pm_runtime_put_sync(dev); pm_runtime_disable(dev); - - return 0; } /* instance-specific driver private data */ @@ -610,7 +608,7 @@ static struct platform_driver pruss_driver = { .of_match_table = pruss_of_match, }, .probe = pruss_probe, - .remove = pruss_remove, + .remove_new = pruss_remove, }; module_platform_driver(pruss_driver);