From patchwork Mon Sep 25 09:55:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 144337 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp1097033vqu; Mon, 25 Sep 2023 03:04:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG3nggGoKPENB6D59eG89zp6NmE89XKqwsQdN5GN+5bBw181ivZh5HbSgw5R6xY4XwO/x7h X-Received: by 2002:a05:6a20:ce9e:b0:15e:5e8c:e45d with SMTP id if30-20020a056a20ce9e00b0015e5e8ce45dmr5151944pzb.24.1695636284064; Mon, 25 Sep 2023 03:04:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695636284; cv=none; d=google.com; s=arc-20160816; b=mROv11t2ww7ppVdIH9khKOvHImQqN8YtvAGOTKzru1A2TcAH0bKcIeggiW2S+1DGWe z3YHzOmhERz0ankdQ6ehf6Itdt/XvCpJZ+2saSr5iyAm2downZdyj5e46N/+ZwIRtoSl Fh0lMJYVPGFfwmkoaira/uKPnBWGQK+LZHA3tzSD0N0raJcMoiCXLE4APQiU2bmxdcac rnyxo1Ko3YTGs3Yy9Y0KZWL0Utdlx9NXF7C84ky67ZTDhPJzq7H6DOt+NExnN5e28OAj GcpSsXDimwGsbs4VVypdi7bhAzwBDhGKPecjBrElSLtw6GRxvKhvG15F62Ds1Yt0P3cF SzbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Iuq1HWof5ESoecxKFXUnRqqmveWzbAGZFM2xneMnbq8=; fh=AOovw+M3JgsWSwJq2DLVB5ADiz1uuv2AcUunvu3FHNI=; b=sZyaE2ozqEE45upPJ6/KRfTfO9cd3R6Nctfsdg0GQfxltoOmIjPjNVeug3pBfExi5w lZ7xlGOl630AXUiE0EwrcNL2ktMasZgron9/tJmKQtqPrXZ2CQf5D0ckDt/85rN3I5m4 XOR7EYEodJFwgGitBcy7Zk0d+ts+/hkz6Wg7sBdgoGLfB5s8V6SfzwXYOzL1eh4vwL03 sfajaWv7Wro5HkfFLGACEA9FZQOaxaSegLb5s3I57CkwMHlqWXWJhWnE9LGFCBi3qG3I pqcAflstRx1nQZ/2zsj/vkDlG86uaBqz0I8FOAXr2GMARBQubX5mVndr6f5u+2bxXfxV prwA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id cb3-20020a056a00430300b0068fb986fcf3si9380759pfb.377.2023.09.25.03.04.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 03:04:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id EEA60809E89D; Mon, 25 Sep 2023 02:57:25 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230402AbjIYJ5C (ORCPT + 29 others); Mon, 25 Sep 2023 05:57:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230166AbjIYJz5 (ORCPT ); Mon, 25 Sep 2023 05:55:57 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9D3B109 for ; Mon, 25 Sep 2023 02:55:48 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qkiJb-0008AG-Vi; Mon, 25 Sep 2023 11:55:43 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qkiJb-008q0t-Iy; Mon, 25 Sep 2023 11:55:43 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qkiJb-004dmg-9u; Mon, 25 Sep 2023 11:55:43 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Nishanth Menon , Santosh Shilimkar Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 36/40] soc/ti: pm33xx: Convert to platform remove callback returning void Date: Mon, 25 Sep 2023 11:55:27 +0200 Message-Id: <20230925095532.1984344-37-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> References: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1787; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=HJo3aWO18/wKa8knQmWwhu5R4zVuVXax0HAzXVwl9s0=; b=owGbwMvMwMXY3/A7olbonx/jabUkhlTBiIzcKIfQnIyHXcuv97WxRLPfu+ktFR3Z1jxXy2vN2 jAP7ZZORmMWBkYuBlkxRRb7xjWZVlVykZ1r/12GGcTKBDKFgYtTACayx5T9n1b5U2WuUv01oo2q vI2CgifuBlya5CTafvNIKJdTxPr1MU0K21TqmGU3TMtL0/F8KZYd+jNguSeXo8GFUo6lPjEndvN rTDp6alVf0pGbpUpXuQITPytyFB2YmpH40qKslCFeds/n6EuXVqu8VrA89KU7PsHpU+K1Gu/bfb qmV6KuMb+87MMxs0c4aGVsuwDvG/tJzPfWvny6ZP0HY+WZsh8ivz8MeKa8ZuIJLk0mmb13/ttMW K6wbObhdr+Wq56er4I6J1tVzV55pMrnme+cX82vZkyMXHL1frjX/G3OmS86JtmHdWb/Dsk42TUv 7WX+C2GWyyIaCycV3dZSsJKt+VpTVyK4x/LXA76TSou5AQ== X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 25 Sep 2023 02:57:26 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778003512497530363 X-GMAIL-MSGID: 1778003512497530363 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/soc/ti/pm33xx.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/soc/ti/pm33xx.c b/drivers/soc/ti/pm33xx.c index f04c21157904..8e983c3c4e03 100644 --- a/drivers/soc/ti/pm33xx.c +++ b/drivers/soc/ti/pm33xx.c @@ -583,7 +583,7 @@ static int am33xx_pm_probe(struct platform_device *pdev) return ret; } -static int am33xx_pm_remove(struct platform_device *pdev) +static void am33xx_pm_remove(struct platform_device *pdev) { pm_runtime_put_sync(&pdev->dev); pm_runtime_disable(&pdev->dev); @@ -594,7 +594,6 @@ static int am33xx_pm_remove(struct platform_device *pdev) am33xx_pm_free_sram(); iounmap(rtc_base_virt); clk_put(rtc_fck); - return 0; } static struct platform_driver am33xx_pm_driver = { @@ -602,7 +601,7 @@ static struct platform_driver am33xx_pm_driver = { .name = "pm33xx", }, .probe = am33xx_pm_probe, - .remove = am33xx_pm_remove, + .remove_new = am33xx_pm_remove, }; module_platform_driver(am33xx_pm_driver);