From patchwork Mon Sep 25 09:55:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 144355 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp1099902vqu; Mon, 25 Sep 2023 03:10:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFT/JeoPrqClTJT+rs+UYtxkb59PoEEnDxVnIbWeqbVj6F8Itk4szu3eeXfYvPIoS3C1uYq X-Received: by 2002:a17:90a:bd88:b0:276:eadf:11af with SMTP id z8-20020a17090abd8800b00276eadf11afmr10415721pjr.7.1695636619715; Mon, 25 Sep 2023 03:10:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695636619; cv=none; d=google.com; s=arc-20160816; b=Xoq66p/huWvtDj1XkBjTvIPfRtZFVcpcDGyxNOe98ZimuR8VdkZ/tT2IZ1tzUD7mr1 32AsAYrwb/H7/8Hq7LU3aJRYc8DGyzNvwJ9yw2fohyG8iKl1ziH9ddh6/2sJAndZUY7r ht9Ow3axhEp30NBJMrS7WQkYT5n3a5JWzSropWAXKZ4zfs5TC8ORHgALLGDIuniHyzUU 8m6bgfMcuu0O2crAEBWtih5AIVky/7oAOjZzZdPZSEsaNvqei70YfyUvnRMIN5lioqLm GVtRq94nHrqywpp6AeP30NYtR+FfGXs/ok9KFdzlptSa7KC91n9D1xn4I8/CFcCJ78NV 6I6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=KljqChQBIZspynLi3Y39+730gE3Yn8qcF75B0SNFNAs=; fh=AOovw+M3JgsWSwJq2DLVB5ADiz1uuv2AcUunvu3FHNI=; b=SnDzu8qx6Pl3+TG+0cN68vwF202OcIzMGKeFiId0gignJtzECXXgfWpanvg6pFotJB FWZZVJ3srS4G1hoZ11CdSoUfkm3I4EGQsPn5bywvAm+sGeQlgiw9bx6tPx28O7+YGBDQ tDTN/npLzWhNwcVb9PsDuPECV/197A+cKkPz2ay81CRrX/l0waB4pUMBwyqw572DBLM4 Of0mtliykwUW5prgUGxN8Dg8ARUaVvjWmWGaC/YuX1H600ir65xh+hzjjWw/EgEHEHt5 KvjXemH+qMmxtLzP5Nt61Os/MbJ+sGM/GaOr+CjqT1emY4kvDDEarD6HgJWkQwn/ymil pHqQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id oo4-20020a17090b1c8400b00277517b42dasi2681084pjb.35.2023.09.25.03.10.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 03:10:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id D4242809C4D9; Mon, 25 Sep 2023 02:58:34 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230384AbjIYJ4q (ORCPT + 29 others); Mon, 25 Sep 2023 05:56:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230082AbjIYJzx (ORCPT ); Mon, 25 Sep 2023 05:55:53 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE81CEE for ; Mon, 25 Sep 2023 02:55:46 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qkiJb-00089p-OX; Mon, 25 Sep 2023 11:55:43 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qkiJb-008q0p-Bf; Mon, 25 Sep 2023 11:55:43 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qkiJb-004dmc-2d; Mon, 25 Sep 2023 11:55:43 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Nishanth Menon , Santosh Shilimkar Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 35/40] soc/ti: knav_qmss_queue: Convert to platform remove callback returning void Date: Mon, 25 Sep 2023 11:55:26 +0200 Message-Id: <20230925095532.1984344-36-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> References: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1672; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=ELrjacRF1jFpMcwr8ey7TAsP/DW/oJeKycDIVxyda94=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlEVhnqr9134qY5AhMZPvy8V57NJDuo8ZOU/mLP 1w0Co+Fr8mJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZRFYZwAKCRCPgPtYfRL+ Tl9wB/9CrLgKUh3aLfv9rmqi4oA9p6kGTGHC9YvFvmUe234alk4BCwl6LelvR9HTQ4buVmdsS7z rdbSs0a0cZwYIMacmFbapkraOybI/PYnQjnl8bt1ks5EQZkxK0qaDuNs0nvFe9yKsre0RDI/tFG JFsOCDjHUbk7vtiTsAYF00EmQZxqcOf5ZbScVI8yljos35fmMgzNuOix0OU+t6Q6kdD28/jt6Fi hH35WsCLurbDJPLxQFZ5sYnZ2+wdGiMwvndw7D0fp5mKu8EeGI06u5CkBqvMdIaVypbaT8VVK0A X7/kmgkasWFJlecPumGAuVwVM2DZS+9oau9unc6oPe8hCuLe X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 25 Sep 2023 02:58:34 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778003863724285251 X-GMAIL-MSGID: 1778003863724285251 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/soc/ti/knav_qmss_queue.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c index 0f252c2549ba..cea791717957 100644 --- a/drivers/soc/ti/knav_qmss_queue.c +++ b/drivers/soc/ti/knav_qmss_queue.c @@ -1884,17 +1884,16 @@ static int knav_queue_probe(struct platform_device *pdev) return ret; } -static int knav_queue_remove(struct platform_device *pdev) +static void knav_queue_remove(struct platform_device *pdev) { /* TODO: Free resources */ pm_runtime_put_sync(&pdev->dev); pm_runtime_disable(&pdev->dev); - return 0; } static struct platform_driver keystone_qmss_driver = { .probe = knav_queue_probe, - .remove = knav_queue_remove, + .remove_new = knav_queue_remove, .driver = { .name = "keystone-navigator-qmss", .of_match_table = keystone_qmss_of_match,