From patchwork Mon Sep 25 09:55:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 144335 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp1096962vqu; Mon, 25 Sep 2023 03:04:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFEWZhNZUDi7MUKphfvAZlerfH24+PjHCDrUMj9YtmJXx0Ya1xu+XYAAgVMTJutqCo6o+R4 X-Received: by 2002:a05:6a20:9704:b0:14c:7800:f3f4 with SMTP id hr4-20020a056a20970400b0014c7800f3f4mr3954059pzc.36.1695636276681; Mon, 25 Sep 2023 03:04:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695636276; cv=none; d=google.com; s=arc-20160816; b=GzjTsPXECBSAetDR9vLkQUWf84aAXRLFCfS0xbs7KJV0BXMFc07ZDecoIAF55pe5qM GwNImPxEDfb3PR1XF37DlQURbchDsjGe5wjJgQhqWgcD95xPwsAhwwFepD4oz8fBeT1I YRenBc9IJnU9BTyug9CC/VTh586G2Ycm12e/RZWrSDdeRHRlsIEE9jtk3ciokTTnFY3U ryu9BRCgfcwpOpvFfthhJzIsHmi3xpy/LeTiTkp8f4aWDG3wJYgVVysQ+P1FwRhkW0PL YAwNf1XCdBlbs3AP0DDY0rXf684DTzTvA/3XfeGl+xskGXbNWwn9yzD8qelkKSQG+5K3 MBEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=BwvBYFVq6hsqN2t+bcpDLL+hsuB8K/Pn+jqOAnWF8K8=; fh=AOovw+M3JgsWSwJq2DLVB5ADiz1uuv2AcUunvu3FHNI=; b=XAmHBu27HSSdEz3LR673m3WHusZulPmVp0MLT3FRisyIXAa75gO8PbH/cuGV65vaCu t3lWKsKDAt1G16gxA7VAqzD+0NpJPvNAT+5ycQAlM7Vn0MIxGZKHCNO6XE5hBIEDwano D04OEhWNxXTL3AtBoJcqq0/ytOkEDstgmV6AwwvO8uKoSWdwX6wylnagoNPQAaluXBmu yKUEwaHrthSEK+6KprufxUTeqmLb5jnJUGkymoRK4z18jqz0xkZpa9HO1f9Y+07Lzz1J 92Qok6+Yj1evwSPT3h1YFQU/YhUp5/Dy+KskTdx6pMfJCK279xzbor1geYi8vsLwr7DK F6Ow== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id x24-20020a056a000bd800b00690d42e3347si8905968pfu.157.2023.09.25.03.04.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 03:04:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id CDF79806512E; Mon, 25 Sep 2023 02:57:18 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231163AbjIYJ46 (ORCPT + 29 others); Mon, 25 Sep 2023 05:56:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230132AbjIYJz4 (ORCPT ); Mon, 25 Sep 2023 05:55:56 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8D76103 for ; Mon, 25 Sep 2023 02:55:48 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qkiJb-00088k-Ik; Mon, 25 Sep 2023 11:55:43 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qkiJb-008q0l-5j; Mon, 25 Sep 2023 11:55:43 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qkiJa-004dmY-SW; Mon, 25 Sep 2023 11:55:42 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Nishanth Menon , Santosh Shilimkar Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 34/40] soc/ti: knav_dma: Convert to platform remove callback returning void Date: Mon, 25 Sep 2023 11:55:25 +0200 Message-Id: <20230925095532.1984344-35-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> References: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1792; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=dh69mYFR4egmQPe5mzBDjMQ4mx/++UfHvxZ/Uiregas=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlEVhm5EBdm/9vZUJsuOCEfsIrnQ0tb63Zgo3D5 qY3Qz1ktIWJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZRFYZgAKCRCPgPtYfRL+ TgjQCAC5JeA5F/+ij1LEKrRjIRPwuHFcPLZh7epJ7fyS/uyW/ZWnboMCmRCFDToziZTi3mu4CpT i29Yks7ZtxuYCiD8TzVK6mal/7N8AKCjEIb73yt4wGecf+PZBlAcXUio9lNiWwW0UqoRoauYgei TfkpJ5gM2s4W8TACWjnWDWTgbh+rP8Ii8Wid2s7cckVyN7F9L7V1QuxOFKw1nfe3ob1a3y+lzqI Qyib16oG7GZ/UOo/XsyAtCZXBMRmn2yJWHYslQUk+CKoRVgnsijWMyYsPZpW4mnu0yRkhxFOens 6sH36RS/3vvF5IWVv8Nut2LVqwnxuSOfU5JWiwTPrL29ZU8g X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 25 Sep 2023 02:57:18 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778003504490835753 X-GMAIL-MSGID: 1778003504490835753 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/soc/ti/knav_dma.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/soc/ti/knav_dma.c b/drivers/soc/ti/knav_dma.c index 0fbc37cd5123..6023006685fc 100644 --- a/drivers/soc/ti/knav_dma.c +++ b/drivers/soc/ti/knav_dma.c @@ -773,7 +773,7 @@ static int knav_dma_probe(struct platform_device *pdev) return ret; } -static int knav_dma_remove(struct platform_device *pdev) +static void knav_dma_remove(struct platform_device *pdev) { struct knav_dma_device *dma; @@ -784,8 +784,6 @@ static int knav_dma_remove(struct platform_device *pdev) pm_runtime_put_sync(&pdev->dev); pm_runtime_disable(&pdev->dev); - - return 0; } static struct of_device_id of_match[] = { @@ -797,7 +795,7 @@ MODULE_DEVICE_TABLE(of, of_match); static struct platform_driver knav_dma_driver = { .probe = knav_dma_probe, - .remove = knav_dma_remove, + .remove_new = knav_dma_remove, .driver = { .name = "keystone-navigator-dma", .of_match_table = of_match,