From patchwork Mon Sep 25 09:55:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 144339 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp1097195vqu; Mon, 25 Sep 2023 03:05:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGIPuQQO5EMNbWCOAWfFo2bxBY9CGD1wG+AE0nuTge368uiGtAO+ECi32HdcRh8owiZ5HTA X-Received: by 2002:a05:6a00:b56:b0:690:3b59:cc7a with SMTP id p22-20020a056a000b5600b006903b59cc7amr9311035pfo.23.1695636303322; Mon, 25 Sep 2023 03:05:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695636303; cv=none; d=google.com; s=arc-20160816; b=bcycG8cT8mecI/2MJknC4bpSp1UxAAzyXreBCNSuYjM53cMUNg6HfOwgH2gQ6Ssyl8 SmOwRh0Bs0Ev+QaAFu/nKXLvPpAQXUlnJvt31O3C+InoBNvujmrI8uMrlDCuQcauEHOe JFz1V3zjTd+w68yqAzQcnwQ9XmSUiSMPEsJXt45WxRigv5KJxLMbytux3YJ9/PmWI1TI 5Z8NVzL99wV84hvBB3+GjbvUXOEUiSPnihtOEVdRia2V3Rid1iPbU4MuZNv1bL/jPiIH KVo7h8QPWJogds73QQ+h1crl7FvFc6N2ELJ8XRWJpmPLtZniRZJRGOiN3oNQWSapA1UM bqow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=g1g0x+I7IIEKUtZXeG7RK1OV3Do/TI3DrJiew9ncn34=; fh=AOovw+M3JgsWSwJq2DLVB5ADiz1uuv2AcUunvu3FHNI=; b=k/474W+HsMGg7obq/zRSUkPhyIJxVlWEVeaKilh9FobIGUh01bP5wdt7jgwAsYhWr1 vrwtYBH+eaa5uG5jATmr/+TOUcWv12IVKimArX1lZ0hIGFF4gKbiowpkPZhaSnHc291s jAiPAq0kF8P2MbdMoa4ywPT5gVIASOSArQHhB4qwxR90ZTYaGN/DcEn/4Akj/4HhQJLl HnI37Xw9BdyqZyIqVKiukzSq/ZA7VdD32xrrbDq25IQbViRMERqkj81xwrxizY0YJO5z l3qINTb737qY1ojKyMIDJiEa6wB1z5uTJOdQlY7pZtOmf8NX3AsCqvGlaGsvsdx3glJ8 9d3w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id ck12-20020a056a00328c00b0069026a3de0asi9606426pfb.138.2023.09.25.03.05.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 03:05:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id D39C08071229; Mon, 25 Sep 2023 02:57:58 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230510AbjIYJ4n (ORCPT + 29 others); Mon, 25 Sep 2023 05:56:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230010AbjIYJzx (ORCPT ); Mon, 25 Sep 2023 05:55:53 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE713E8 for ; Mon, 25 Sep 2023 02:55:46 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qkiJb-00088E-Ah; Mon, 25 Sep 2023 11:55:43 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qkiJa-008q0h-TZ; Mon, 25 Sep 2023 11:55:42 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qkiJa-004dmT-KN; Mon, 25 Sep 2023 11:55:42 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Nishanth Menon , Santosh Shilimkar Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 33/40] soc/ti: k3-ringacc: Convert to platform remove callback returning void Date: Mon, 25 Sep 2023 11:55:24 +0200 Message-Id: <20230925095532.1984344-34-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> References: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1696; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=hlwfHmXrVPpoUA6HQvorzbxZ+wVHWipEdQuyoYdBV0k=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlEVhlVFfuEe2s8yzgLrMDIqb7suMbNJw8ygZ86 nDZkEJWesOJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZRFYZQAKCRCPgPtYfRL+ TpUEB/9jnSCqzUu3P1MFhGYE6gKOTj94efDqWml5vzmoAJQUEYcKuuGw75sXiVQOo2J4JRcN1IM G/0Q4ApYlUzZkqGbV3MvgrjnM9O0YIF4zWK3+rlpJ7SQT9xo/dAnZhzHmbiwgh2rn9HviFvUFJ1 v8u6Swskv5DobZsmnb02DQNreSG59l/CKndoFyOcjuGRhugM7u8TNJkSgquN9OAENQqbPQXfnPm 8D/CfD+Hzzs3kGADN86pEEWdJw2G7Pzpm8oyR8k/zXaF5GzQVqrC5DvhQmBLbw/H4q+Llgq8vxn CxjbnyIrHf1VgypDRhbGIPre/2Uh2RihkQ47ToXk4HDWrXly X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 25 Sep 2023 02:57:59 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778003532021853198 X-GMAIL-MSGID: 1778003532021853198 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/soc/ti/k3-ringacc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/soc/ti/k3-ringacc.c b/drivers/soc/ti/k3-ringacc.c index 148f54d9691d..fd4251d75935 100644 --- a/drivers/soc/ti/k3-ringacc.c +++ b/drivers/soc/ti/k3-ringacc.c @@ -1551,19 +1551,18 @@ static int k3_ringacc_probe(struct platform_device *pdev) return 0; } -static int k3_ringacc_remove(struct platform_device *pdev) +static void k3_ringacc_remove(struct platform_device *pdev) { struct k3_ringacc *ringacc = dev_get_drvdata(&pdev->dev); mutex_lock(&k3_ringacc_list_lock); list_del(&ringacc->list); mutex_unlock(&k3_ringacc_list_lock); - return 0; } static struct platform_driver k3_ringacc_driver = { .probe = k3_ringacc_probe, - .remove = k3_ringacc_remove, + .remove_new = k3_ringacc_remove, .driver = { .name = "k3-ringacc", .of_match_table = k3_ringacc_of_match,