From patchwork Mon Sep 25 09:55:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 144382 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp1129555vqu; Mon, 25 Sep 2023 04:13:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFDiSwiC4lza7vUfDnw8oxasEOOI5QjmS0ZUlWj6Opar5GiG7wv0YIH/WZCaj9arPSkVInE X-Received: by 2002:a17:902:fa04:b0:1c6:2902:24f9 with SMTP id la4-20020a170902fa0400b001c6290224f9mr158106plb.1.1695640400441; Mon, 25 Sep 2023 04:13:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695640400; cv=none; d=google.com; s=arc-20160816; b=CV8KbaLse8o8TJk1UJlBeFNuVSqWotJkoeMfXg6GPYQCXDrcoMXsBBu+Nmv3ED9Pix g+r3RXNISyxvX6NvgHQRxECww1flCK395mbvFzIMmQgcabmhFUz78X49qjVF8EpDnGpn FpO4Km7t4pBham784cS+QsVlCi+z6OQRkInIXUAOKZsbTPS4wgbzFAbj+ReFBkdRQmA1 8nHKaRiYIh47O0jq7x+8idsebJu9F9SAkRirgnb/8ICRhCeHoxXKyFdXKeQM6JaXlmy9 k1Lj9dsti5fQs0v/oJmxXBRqSxXGJOIKWk90DWOoa+3NoBfhh5CinB1WqaCydinr3WUi DHxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=MQP91+uMPaRHuQ6vqnsW0n1VeBRxKp6BSxkCRb0LjlE=; fh=+KPZtSvYUFUy6ZYQaAsS0aDPy9TPrNUccuOVW4LoMjA=; b=DjtRq4tdUGsZVVbApGpWP+VIpj2/txELtezjb5eRnrqDsZMtgTpNDJMEPPW29KUYht 0aLQqRQwzadCxGSLnBSXZ3Udyg+k8WHSG1wfwa8c7QMGh3ittrsqtHmy1qpxRAh4tZji ULIGSh+901HVZ4nMtYUK2S9C2vXjCxceyRFp76Ebn7e7uQsBWuO0HTRrW6jzd4TrZyUm BHlaXb5daQge1iemkgrIUhD1ORG/KAl5VdoovYLEilt+rjyiQxdA0T4mYllN6XHYSknp O94HHfwIhTki5MhuIE9N+m4kTsxsx0pJb4b57rHsks5qFp6Cq8OTh+XZs1IAWYW8x5FY pN/w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id u16-20020a170902e81000b001b9e82a6beesi10205152plg.548.2023.09.25.04.13.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 04:13:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id A9C468023935; Mon, 25 Sep 2023 03:00:08 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231149AbjIYKAD (ORCPT + 29 others); Mon, 25 Sep 2023 06:00:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230185AbjIYJ7f (ORCPT ); Mon, 25 Sep 2023 05:59:35 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A59A127 for ; Mon, 25 Sep 2023 02:56:26 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qkiJb-00087l-4p; Mon, 25 Sep 2023 11:55:43 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qkiJa-008q0c-MW; Mon, 25 Sep 2023 11:55:42 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qkiJa-004dmQ-DB; Mon, 25 Sep 2023 11:55:42 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Thierry Reding , Jonathan Hunter , Sumit Gupta , Shang XiaoJing , Muhammad Usama Anjum , Rob Herring Cc: Nick Alcock , Yang Yingliang , linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 32/40] soc/tegra: cbb: tegra194-cbb: Convert to platform remove callback returning void Date: Mon, 25 Sep 2023 11:55:23 +0200 Message-Id: <20230925095532.1984344-33-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> References: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2005; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=fJek1nXRjVsALxbooou+SSfwuAYzMEZE4AiZBXgjDcQ=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlEVhj7v6vyTqodYCq2VrRogq1Zj5wQGoIHk1ls VBTTjBoX92JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZRFYYwAKCRCPgPtYfRL+ TjGHB/9JTRks2fQHjRlc6o9U5WRuLZL7Gm8heSS/KwtLWYOOBv3Ek2PbVFE+OQCAU6y7WCo1iq2 5XOvCatGvRTVUw3+BYcKE29vfUx7Bdb5uy90WanBBVqlM0V2oSbA6IRGlrskytwisxw9TddnSmy 6bloElouToNXDk1l3QdxBVq3Sot6K4MOvB1CqwkJIhqEsBVRa82b7vs2E0LBTFRoW/xes5Gat59 XH46DrxTc5TV+fMHgeV8oh3g7rzhf2h04+9gVXQ+hCCavmps9d+gybwddVAzkqr95PDnQz+RD6R XJA7viwK5QIe95rnstIB0lNVfUVGNcI0/Pc6FhD4ZGiMtnkL X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 25 Sep 2023 03:00:08 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778007828963913287 X-GMAIL-MSGID: 1778007828963913287 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/soc/tegra/cbb/tegra194-cbb.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/soc/tegra/cbb/tegra194-cbb.c b/drivers/soc/tegra/cbb/tegra194-cbb.c index cf6886f362d3..9cbc562ae7d3 100644 --- a/drivers/soc/tegra/cbb/tegra194-cbb.c +++ b/drivers/soc/tegra/cbb/tegra194-cbb.c @@ -2293,7 +2293,7 @@ static int tegra194_cbb_probe(struct platform_device *pdev) return tegra_cbb_register(&cbb->base); } -static int tegra194_cbb_remove(struct platform_device *pdev) +static void tegra194_cbb_remove(struct platform_device *pdev) { struct tegra194_cbb *cbb = platform_get_drvdata(pdev); struct tegra_cbb *noc, *tmp; @@ -2311,8 +2311,6 @@ static int tegra194_cbb_remove(struct platform_device *pdev) } spin_unlock_irqrestore(&cbb_lock, flags); - - return 0; } static int __maybe_unused tegra194_cbb_resume_noirq(struct device *dev) @@ -2332,7 +2330,7 @@ static const struct dev_pm_ops tegra194_cbb_pm = { static struct platform_driver tegra194_cbb_driver = { .probe = tegra194_cbb_probe, - .remove = tegra194_cbb_remove, + .remove_new = tegra194_cbb_remove, .driver = { .name = "tegra194-cbb", .of_match_table = of_match_ptr(tegra194_cbb_match),