From patchwork Mon Sep 25 09:55:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 144330 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp1096732vqu; Mon, 25 Sep 2023 03:04:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHkTbUGNwYC6AYmX4E8s4kIX644nl9R/oyJMdDTisFYomzSA8GmN0KhkBUJ2CJTN2/HXWdH X-Received: by 2002:a05:6808:1450:b0:3a7:3ce0:1ad7 with SMTP id x16-20020a056808145000b003a73ce01ad7mr9348137oiv.20.1695636251828; Mon, 25 Sep 2023 03:04:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695636251; cv=none; d=google.com; s=arc-20160816; b=gQ/+7MUkEjKi8bIt3UUNAxpA02YpkcOb2uYJUst67orXOQMEnOAHReqPC72CLJtXUV apxu/sK3K4//1ez89zu7Zzgz6W+v3fFK5fNej916fZBUrkaE9xJKVHK9z85HpUy+g2BO miHz66InbcCjURzaNQJBuZ7MLjhcTtbmy4JNxEDGxI5z5JlekBpdm1E+LkcJFGyhN6Vo 89WUh63/SnCr/a6vBB7IW8WYZnApIk6IrT9AexNj/cnjoEodH/W+nQpUmsb/t9kZAysR sxm4ftFUBMCRI+Q0VJUtwx4HxiCbZy0+hD9Gg9PopcfIhork1XnlZBdIY5UMFnhyHPxl 31vA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=W5mCWRXc0pkhb8CGL0eQnT0xAxTUA0wygGDa6KbarCE=; fh=dI1JMT46o3BIt87R4A+1KF18C5uRma7B2GrOTQ5jf4s=; b=l3YplEBkhe5gfEFc+phwSVb6vlxoi8J0K7j1RTIx4IwcJkwK3S644cT0dO76pp1LdG 96JENf0vhJc27Wzc47jLEnt594246ZQjFdiauwoj4lhavXUOOUdkWBe+ciZ+/yWHrQU4 g576hTr8E9qDcJ3vhZJvzRhlLaB1ohxdwwSw+dSJA4BQ4kQt56iukXTqv0URZDIetdP2 j9oZg8XZuHeLfKDGUbTKauhYlXz/sPWhDSOF13da9xbPk5lGgE7xAWhMPgEY6xnBtzJ1 wDWdplxgiuyzAoW7K96LUpL7DJVcKVgGnB418AqDSBmq8PHD2RqKxx4v3kaTpobfjYdO pC+g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id t12-20020a65554c000000b00578b379922bsi9353262pgr.511.2023.09.25.03.04.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 03:04:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id DCE32811ADC4; Mon, 25 Sep 2023 02:58:35 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230488AbjIYJ4y (ORCPT + 29 others); Mon, 25 Sep 2023 05:56:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230020AbjIYJz4 (ORCPT ); Mon, 25 Sep 2023 05:55:56 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7DEF101 for ; Mon, 25 Sep 2023 02:55:48 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qkiJa-000859-TZ; Mon, 25 Sep 2023 11:55:42 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qkiJa-008q0X-FA; Mon, 25 Sep 2023 11:55:42 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qkiJa-004dmM-5r; Mon, 25 Sep 2023 11:55:42 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Krzysztof Kozlowski Cc: Alim Akhtar , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 31/40] soc/samsung: exynos-chipid: Convert to platform remove callback returning void Date: Mon, 25 Sep 2023 11:55:22 +0200 Message-Id: <20230925095532.1984344-32-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> References: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1808; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=5kh+y4DOQVrSyZkhWv/uw6w4/RUDtFUk39hMgcVFiI0=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlEVhiyd9rJ769lDBMAmedB3kviAVUASyQCp9/t LhMqggF/tuJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZRFYYgAKCRCPgPtYfRL+ Tg/8B/94KeKdeLgFZohjWhwnbra0fvi3MpKMsMjNUhpcd5kPIi1qsJy67sN20WFAReEnLBGMqMZ aqAl6ldk1b53Q2M3ATlr6o+JVUSh7zypA2EjalEXxZCHtfZ1FWpEPlQexHVRVwtmsQ26hHvrcRI DtGCjq9+3xNJyX8NJdou4dGOGtFmWg219SQ354karaHcN6fL96DwdljDjZtkQKnc0ZHa+C50ZAd SguGjS2vTnqeGDvd0vmPAFZ+PxNxvPtmU+T5eEmjpAOLiB4ch2ZBLCfK3z6kYiF8RQCK9hikHu0 DYJ3QM1mfBiYubDx2Lxkej4YtYn8R56ctFvTfBsTeyfJWTFm X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 25 Sep 2023 02:58:35 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778003478212209595 X-GMAIL-MSGID: 1778003478212209595 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/soc/samsung/exynos-chipid.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c index 7ba45c4aff97..3fd0f2b84dd3 100644 --- a/drivers/soc/samsung/exynos-chipid.c +++ b/drivers/soc/samsung/exynos-chipid.c @@ -158,13 +158,11 @@ static int exynos_chipid_probe(struct platform_device *pdev) return ret; } -static int exynos_chipid_remove(struct platform_device *pdev) +static void exynos_chipid_remove(struct platform_device *pdev) { struct soc_device *soc_dev = platform_get_drvdata(pdev); soc_device_unregister(soc_dev); - - return 0; } static const struct exynos_chipid_variant exynos4210_chipid_drv_data = { @@ -197,7 +195,7 @@ static struct platform_driver exynos_chipid_driver = { .of_match_table = exynos_chipid_of_device_ids, }, .probe = exynos_chipid_probe, - .remove = exynos_chipid_remove, + .remove_new = exynos_chipid_remove, }; module_platform_driver(exynos_chipid_driver);