From patchwork Mon Sep 25 09:55:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 144349 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp1097813vqu; Mon, 25 Sep 2023 03:06:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHfz9XO51YMYDTcjK8RKXX9l2tmI9e3kecOka2rG96x56W0jykbW8KDGzA1ZFa1aiKHW3Gl X-Received: by 2002:a05:6358:720:b0:143:9763:e6 with SMTP id e32-20020a056358072000b00143976300e6mr2604659rwj.0.1695636374535; Mon, 25 Sep 2023 03:06:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695636374; cv=none; d=google.com; s=arc-20160816; b=b4OriIWYbYVeIUhKE9XShd0HuBJOSyRnjYyYcXnMTwj8YEELrfQUnlBZIi9TfA83yq Y/Z+TBs4rlHRRdOsFLJ1/KuKWiiDtcbiM6tMgODRoHqdr3eexNjyWp8zCmGiCEqsW6BY e0EiVDqp6ythq0hEECJdaGKmJfFeHQcpLWXBZLZl42yf+Cgdy0cY2G2xLCcI9ZeWD5XR jN+y5aSuCNaeT9YQrTQraIPk5LJT8Ux81J4YT9j81VB9sJ5eGI/ACnszkfl2rnaN+r/Q SI0DLgEuWNue9wzCGTI9vHaj23bwXnMwMJPP/X9xq7j0tIaUXuEMt/yaihR+TmKPSIEq SlEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=peIYf39s63XDSYnlCsHiBNi+JqTCu+4/MhzlTxJK6UU=; fh=8FRHurZ4XhDSzMskhGToyLFYUXPJvn1xrtCS7T04f18=; b=Nv0tKCpLVqY9moC/C/99H1BEHUmmogiE3mtyJlpVK78N9QwoP/4VBGc6Wqk3KP8nmh WU3iFe35TXAg24+kYunS1czNujmevAgeL0HhfKONrFCdypyRvdty9baEpUSeqZs8JzTE ZuBFO9DxqUEftq9/i8AloTUmN1gXBLruiY5rThEK/7F4RaDA5Y+RpaIJYLdLLSmuVZl/ j6n0SxtS0BLlhIGGltMtQn6Tp7JegZt2vhiXVm7+gZwpJ8S1evbXAT8dKi/K5HnkNgXV DgzkPPhgd5CvXn7aFQ5Apf5D0vBD0vHqwkfHpLqHts0tOchuYd1g4X/gRyzSCClkZptF 0+SQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id j2-20020a63e742000000b00577646e2b6bsi9454355pgk.206.2023.09.25.03.06.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 03:06:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 4E5FA809E217; Mon, 25 Sep 2023 02:57:34 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230503AbjIYJ4l (ORCPT + 29 others); Mon, 25 Sep 2023 05:56:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230074AbjIYJzx (ORCPT ); Mon, 25 Sep 2023 05:55:53 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFEFAE3 for ; Mon, 25 Sep 2023 02:55:46 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qkiJa-00083B-ND; Mon, 25 Sep 2023 11:55:42 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qkiJa-008q0T-64; Mon, 25 Sep 2023 11:55:42 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qkiJZ-004dmI-TM; Mon, 25 Sep 2023 11:55:41 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Heiko Stuebner Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 30/40] soc/rockchip: io-domain: Convert to platform remove callback returning void Date: Mon, 25 Sep 2023 11:55:21 +0200 Message-Id: <20230925095532.1984344-31-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> References: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1863; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=dSb9QNeIckA738H8tOK4mdlXe6+NMGUKtANgI6GyJvY=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlEVhhLmCL9V7I1ameNsoabvEahY8rsNxRFzmCZ MhyoiSvkuaJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZRFYYQAKCRCPgPtYfRL+ TqsQB/9O+lvyEqVpjhB5clMRQGvlRE2E4pIuH64H6vN9WvwD5VS8yymgO0poaWwThVyUFi+99fT U093S8k4KltHmhp1f3W6QsxW5PRVITqv1aAfgbppx3udLWVOGS0Kxddhx6IQC6B1BH0ObMYLeS+ IyUyRbRc6+6yg6g47KD97bvsnYI0v7WSsNoYgqIFq6/q1qqc9cQcXpX+52TtX14VBmjcAc+8Z09 +4iATbjiqKUDmFD46IaH6VEfdqTT3kCBNefhCFKrhSxJR1Fphp7M0lRSrxo0+rE2e65cnk/OJXo MahpxRkHCxfat45eiM6+ExAZ7EOdKL3c+6aMRulj8Mk7KaL/ X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 25 Sep 2023 02:57:34 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778003607038129482 X-GMAIL-MSGID: 1778003607038129482 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/soc/rockchip/io-domain.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/soc/rockchip/io-domain.c b/drivers/soc/rockchip/io-domain.c index 6619256c2d11..18f809c160a7 100644 --- a/drivers/soc/rockchip/io-domain.c +++ b/drivers/soc/rockchip/io-domain.c @@ -687,7 +687,7 @@ static int rockchip_iodomain_probe(struct platform_device *pdev) return ret; } -static int rockchip_iodomain_remove(struct platform_device *pdev) +static void rockchip_iodomain_remove(struct platform_device *pdev) { struct rockchip_iodomain *iod = platform_get_drvdata(pdev); int i; @@ -699,13 +699,11 @@ static int rockchip_iodomain_remove(struct platform_device *pdev) regulator_unregister_notifier(io_supply->reg, &io_supply->nb); } - - return 0; } static struct platform_driver rockchip_iodomain_driver = { .probe = rockchip_iodomain_probe, - .remove = rockchip_iodomain_remove, + .remove_new = rockchip_iodomain_remove, .driver = { .name = "rockchip-iodomain", .of_match_table = rockchip_iodomain_match,