From patchwork Mon Sep 25 09:55:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 144343 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp1097700vqu; Mon, 25 Sep 2023 03:06:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH8uIbJLOjJOIQt5Nc3w1wyPTULFk3/WNBP/PExv+S3PpyUNH33e4vAyYuQt7M7FoLkBynZ X-Received: by 2002:a17:902:c40a:b0:1c5:cfd6:9e82 with SMTP id k10-20020a170902c40a00b001c5cfd69e82mr5734366plk.18.1695636360085; Mon, 25 Sep 2023 03:06:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695636360; cv=none; d=google.com; s=arc-20160816; b=DLrjOvjJFlsJ1VzKX5wJpDqTdFp8sOQYIF5tbZRDSsXKaesrUxQ9cpDfL2h2xUfAO3 DKAkAKhgd21YO/Pu8fZoMI+M3Caf+cVwFyQs2ydAEnO3h8qMLFO1zFBPR/gdHVuPkqyX ATdcE8NMLt9PjpkIq3XdibuBdNuPHwzx0mR3MTqJd8WzSbNGEVZPanzP3irELNzdaPq9 l9LRHwFfDix+kY5YjEw7nSU7lzxb82g4sHYsGQo46vvQ9Z9n3DXQ22b5wtylEvPNz7YL ZXyUFjcP87D8ZssiOqqes0dTSvNyf5sJ5vVvBFmO20+rtk+PqFfqWY1S7DpEcit3dF+Q UXMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Ur1akne2LHbot39JpPy2kFSs7g8FhyKrJ2TnUO7ZZjk=; fh=yesUiOtvEq6SW7SpcQd8dbVo+PJhFfjCDOfcoICCX2U=; b=a1JY7cLh6uL8TOgh83jk3GgRn6tgq7nvs7KQEGhFrnn6DSgQyXjbxccKVlwo0xwq3Y asek3gTEjaNx4OVe6k90lF9xKBzGIKFPP/RPgFwdFzgkp53EZO0dfrtwkNv0lxria9/p 7Qh6DyOR6VboRQ68A/Ib7OKoo/y0fKutp4IYOI2wEtpu5a3NDuoqUh7CZkq6fP+3j86O N8z0OYb7CIr6A2/2M4GlGQVZVaFnQrKGXn1ThWRUVB4wxu8hl6273wLJD/4L4A/nAWqc 1Q7eJ+12bTIIRBWYgDCOxMDAbL4rI6S98admN9VlCyMfZIT6G77sHuQp2dtLvBLi2CbR C7Sg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id z18-20020a170903019200b001b8a70d11e4si10389685plg.529.2023.09.25.03.05.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 03:06:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id F24CF8025807; Mon, 25 Sep 2023 02:57:25 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231150AbjIYJ5S (ORCPT + 29 others); Mon, 25 Sep 2023 05:57:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230232AbjIYJ4D (ORCPT ); Mon, 25 Sep 2023 05:56:03 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E393711B for ; Mon, 25 Sep 2023 02:55:49 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qkiJZ-0007zo-9W; Mon, 25 Sep 2023 11:55:41 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qkiJY-008pzy-Ju; Mon, 25 Sep 2023 11:55:40 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qkiJY-004dlq-As; Mon, 25 Sep 2023 11:55:40 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Andy Gross , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 23/40] soc/qcom: qcom_gsbi: Convert to platform remove callback returning void Date: Mon, 25 Sep 2023 11:55:14 +0200 Message-Id: <20230925095532.1984344-24-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> References: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1713; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=eNF+bxPsU6MJI6SmqQsGkl5fEqZP0D5rW8QkBlB+fmk=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlEVhZndudiGaALleMrA8pDLQKs2c7vBoIWBzq7 kRDztsaYDmJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZRFYWQAKCRCPgPtYfRL+ ThgjCACrSH0U+OYk1g45k77ScIibVr/T6Xrn2/Q8lfZpo2K+EnhykNeVr/ZQkH/FWaQqCdjPZz2 TjunUQGyU6D7XTQn5XTxZ/6j5P+FQpXyWpDeKppK6Jo79rjZ6NSH02m8V2m1vgyA5rfFjbHIR0b m2xxTs313W8hqOq3MJWZLpjT72QmVp9J4nNrJOmmxDUWe2pjdCfJFNzk0CN0Xavc2xenZnXPyaz GY8woJKetAqWeqvQlcwsjzqEZMHXjwWXJdwsGs+crmMvp61rkd9YCrWdz6P69O45jN6YDpM7ZW7 6AV+6FdmZPLlKOll62bzEFwTfWyfAOCNexhl3KVXBiDefXkf X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 25 Sep 2023 02:57:26 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778003591544576406 X-GMAIL-MSGID: 1778003591544576406 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/soc/qcom/qcom_gsbi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/soc/qcom/qcom_gsbi.c b/drivers/soc/qcom/qcom_gsbi.c index df7907a83aa8..f04b9a324ea9 100644 --- a/drivers/soc/qcom/qcom_gsbi.c +++ b/drivers/soc/qcom/qcom_gsbi.c @@ -212,13 +212,11 @@ static int gsbi_probe(struct platform_device *pdev) return of_platform_populate(node, NULL, NULL, &pdev->dev); } -static int gsbi_remove(struct platform_device *pdev) +static void gsbi_remove(struct platform_device *pdev) { struct gsbi_info *gsbi = platform_get_drvdata(pdev); clk_disable_unprepare(gsbi->hclk); - - return 0; } static const struct of_device_id gsbi_dt_match[] = { @@ -234,7 +232,7 @@ static struct platform_driver gsbi_driver = { .of_match_table = gsbi_dt_match, }, .probe = gsbi_probe, - .remove = gsbi_remove, + .remove_new = gsbi_remove, }; module_platform_driver(gsbi_driver);