From patchwork Mon Sep 25 09:55:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 144333 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp1096934vqu; Mon, 25 Sep 2023 03:04:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEo26cRHMXvdngVhpFPLkS2a0kgjmMDvnaMlfCQEhxUg+A0ehflP9GtUO/pti+7lAL5+iGG X-Received: by 2002:a17:902:bd0a:b0:1c5:fe75:b304 with SMTP id p10-20020a170902bd0a00b001c5fe75b304mr3125481pls.59.1695636272857; Mon, 25 Sep 2023 03:04:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695636272; cv=none; d=google.com; s=arc-20160816; b=nltzIT1JX2OR7KDi200xa+n4W+HAOkQxwkA+OAE71y+rJrdsd8OgzqCKACvgM8a5io tM47JQ52KcymDELWxnWMh3oj3tAWfPJg+Jib8KkCMBXRH+qf4crGyH6a3uWaGOCb9ycM vGvw+wwBraRzhKCLmxA2qWq27GzgeSfrLzBwAOqX9UDXaysXYYjFHfWAOMhz13XvEWcQ pxZKS7fQ0FgHNpIWvbQwCaThoIzfkvKY0iiJXyYS1KYBJZ9mLnwvIHFKNlDhptDEXfzX oGwXKkR/Zllm050UeoyCJ6EcoVxYhGDfxAmffexCopJa325SV6CWxZ5GG/dHyj+l6VrZ /dNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Mv9P0C7t/ulJIDdsVMtma1kmnUTPSI/iPDS7H95RL8Q=; fh=yesUiOtvEq6SW7SpcQd8dbVo+PJhFfjCDOfcoICCX2U=; b=0YPs60mpqGt9v6Y2qaUNKf5CND8uEkFxUAEukP/qNHiniX04SM5zjV9D0UrQ7yAAxn 3WwxVkJ/jlnel8oT4sEXLpyWm1q2AqZqAeUgrOuney+Q2mxOEc2dwRnydKQ1sFhKuZTv HctGU/CU2PBnickambgvgCfNSZ8CY/KLDPrwaUr/+X8lNCCrgJXyXBXqYIrsq3tdD5Jb oyz294ezkARNnZHbSnNswlZa38VWdaUqPNGaPTab3waXM42pjnVusvpab69lSEdQKg6V Q3N7cX/RTmze758B7mlLdBdqGQPItRU/Gh5Dh8V0nPaBc5ggjhhajHu1Vau4d4/a8e4x vVlA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id b9-20020a170903228900b001c57270c11fsi10153973plh.365.2023.09.25.03.04.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 03:04:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id A4E5E80BB6E4; Mon, 25 Sep 2023 02:58:13 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230348AbjIYJ55 (ORCPT + 29 others); Mon, 25 Sep 2023 05:57:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230415AbjIYJ4X (ORCPT ); Mon, 25 Sep 2023 05:56:23 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1A451B1 for ; Mon, 25 Sep 2023 02:55:53 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qkiJZ-0007yW-2A; Mon, 25 Sep 2023 11:55:41 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qkiJY-008pzr-6x; Mon, 25 Sep 2023 11:55:40 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qkiJX-004dlh-U4; Mon, 25 Sep 2023 11:55:39 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Andy Gross , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 21/40] soc/qcom: pmic_glink: Convert to platform remove callback returning void Date: Mon, 25 Sep 2023 11:55:12 +0200 Message-Id: <20230925095532.1984344-22-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> References: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1935; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=feNw6Iehxq5cpeZvKpkOslVobhCC8GM5VKPDgbn0M7s=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlEVhX2d7dAZtHLNX+a36/PvcJy1Ir7k07q9my/ snPq4zbWemJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZRFYVwAKCRCPgPtYfRL+ TmbDB/99bFLJnBjgwDQHuW+8AkUCkuoAMGJhVgGjexCH5XFHmLS1jqaDlr0hdLKPLjlete/WmCU qU64I3t6c1lFWolBWHiE/jgasdui9vZxTbuq7JZVhVNjLh1FsdK+BqdvzjcuRE7+g7ZIrdijP9A QmPv6gjcUu3KqldNCYw462pAKPeKKZTcvkt1879piZLevRFMHf/Orv0qe8wprqziTrS7M0diFIg TnjOwN5rjE3OsgiGGQV7lLgd+HWA+Pb8K+AFrDtvxYkGBrtIv9C2dn2nIM/DdxgGBnqaMPGZsoF 750mRZ5BmdnFO4Hva3Kpk1ieLIC4clQAC2O+pOyZABfe1NdI X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 25 Sep 2023 02:58:13 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778003500663129279 X-GMAIL-MSGID: 1778003500663129279 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/soc/qcom/pmic_glink.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/soc/qcom/pmic_glink.c b/drivers/soc/qcom/pmic_glink.c index 61c89ddfc75b..914057331afd 100644 --- a/drivers/soc/qcom/pmic_glink.c +++ b/drivers/soc/qcom/pmic_glink.c @@ -318,7 +318,7 @@ static int pmic_glink_probe(struct platform_device *pdev) return ret; } -static int pmic_glink_remove(struct platform_device *pdev) +static void pmic_glink_remove(struct platform_device *pdev) { struct pmic_glink *pg = dev_get_drvdata(&pdev->dev); @@ -334,8 +334,6 @@ static int pmic_glink_remove(struct platform_device *pdev) mutex_lock(&__pmic_glink_lock); __pmic_glink = NULL; mutex_unlock(&__pmic_glink_lock); - - return 0; } static const unsigned long pmic_glink_sm8450_client_mask = BIT(PMIC_GLINK_CLIENT_BATT) | @@ -352,7 +350,7 @@ MODULE_DEVICE_TABLE(of, pmic_glink_of_match); static struct platform_driver pmic_glink_driver = { .probe = pmic_glink_probe, - .remove = pmic_glink_remove, + .remove_new = pmic_glink_remove, .driver = { .name = "qcom_pmic_glink", .of_match_table = pmic_glink_of_match,