From patchwork Mon Sep 25 09:55:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 144371 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp1115189vqu; Mon, 25 Sep 2023 03:45:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFB972vqhZVNz/jQrj2JsZRsHYaChpJF+pkljLbBsLXTgtPoDT+zM6Z0c2zfMY7X0qs/gWs X-Received: by 2002:a05:6a21:32a7:b0:15c:b7bb:2bd9 with SMTP id yt39-20020a056a2132a700b0015cb7bb2bd9mr9462194pzb.6.1695638703082; Mon, 25 Sep 2023 03:45:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695638703; cv=none; d=google.com; s=arc-20160816; b=oSuSC5bxXxdOOhfFYZ0JAkfvARKMXsUO/Wkml+zUDJfNb1mhtCGgv8NIQwG8GlnEzt D5r9nk9iFFr+g7nU9ovte2E5/p8Zphx4gzYbqJirdjX4Sq71XzubJpbbO6SJSSnGv5RH H1f6il5Sbv+vgg2KyO3TP3PQ59/pD+gbqkPlwS+A4NjykfNtoMEQ0JB/+qEOXPPY6LTl zVeywKB65AEJpX3Zp0ztA+YM7dp9mMw3LCs+5qBlDWnQ5UiudOUla4JISX8HMVC2nXdA jW/kdanzZMo1rbolKNSXuW7BOb0ySJ6RZcEia6hhEGVGb6U25uITGFOVPt9BHpZQbCx0 cccg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:from; bh=tYdcv5vDL5m8iEwIpOTI3M4JRx6yZaBcECm5gKUJ6JI=; fh=Q1ApBNW11NC/3LTbkAke/6HAQpY7ndyAGPP6GP9MS7M=; b=D+ElAb0+8hv/OsTheu+TDACO4Fp3X9FV8gnUHtMcl0wDqvvgVpINRiXPBtEvJMOSim jfwUHQao8k/Ht+ARxQ24SMMK3DmASJfMajIXUF55Tyt7GXZqP6SoEGnoqOcSh8bqS/1h IUxkJ1SuLJlf/Cu/cGGWL5opB7ZucZBFd3/DyV2ZEdpsQpFJisjm9j34vs2L8DDc/pF0 GG0bcrPuDjNQ7KvO99NUeN1F2gubV89zQERrcy8otzuwuO8u93G1fS/4FGX3Zrc9eSHY J5Thb/0pzU10RpB0Gx5by0Yo1t/nnRFCT9a1yxX4/ccGsxsvpR7fLtHF3aVmtFFeKEl0 JYQg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id t8-20020a170902e84800b001b8c824e826si4371523plg.533.2023.09.25.03.45.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 03:45:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id EDD7080CBDDE; Mon, 25 Sep 2023 02:56:43 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230389AbjIYJ4i (ORCPT + 29 others); Mon, 25 Sep 2023 05:56:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230059AbjIYJzx (ORCPT ); Mon, 25 Sep 2023 05:55:53 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08BC0FB for ; Mon, 25 Sep 2023 02:55:47 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qkiJZ-0007ww-A3; Mon, 25 Sep 2023 11:55:41 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qkiJX-008pzc-Er; Mon, 25 Sep 2023 11:55:39 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qkiJX-004dlR-5c; Mon, 25 Sep 2023 11:55:39 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= Cc: Arnd Bergmann , zhang songyi , Lubomir Rintel , linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 17/40] soc/pxa: ssp: Convert to platform remove callback returning void Date: Mon, 25 Sep 2023 11:55:08 +0200 Message-Id: <20230925095532.1984344-18-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> References: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1766; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=7RMXK7o5MKcvP26bqwpTH0k5DtjEeMQoS+T8l69yDkY=; b=owGbwMvMwMXY3/A7olbonx/jabUkhlTBiODpyie7BT4bBoj6Pj3yb9LxfxLf3ZYoMxk6KuY3c YZFvr/YyWjMwsDIxSArpshi37gm06pKLrJz7b/LMINYmUCmMHBxCsBEVgqz/y8UOHdhVtlOtwlt Va/K9v8zcBeYrvYpM12O885e1erSj5y9wuHmKqZ1rvHBG4S/VAQ1ZtywteTZeGdWnXfpyokzZ5w S/8/IbBvodSS7q8E8kDVr/Z9Xpg+jsjk/rUwSbPyooKUQqs6zunKLs4bdu/lffm54ZbunaVKi97 mlW17nZ9TPEbvT+a3y//3F/87czCwvvpS8+/iOOMmkqPmsez9Klbc+kDUyKz4gZpLHmZH1QJVNw eK7Y9zbDWpOXW31WtZq+WX2UyJmzVrapOcfa3P0O39UTZzqqqu/1vcwaAifjZAV9t6ywcPXZu60 nmhZLy2GxYIe0tVitReYvC/u+9FwLbjq4HvncqDiNAA= X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 25 Sep 2023 02:56:44 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778006048414636614 X-GMAIL-MSGID: 1778006048414636614 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/soc/pxa/ssp.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/soc/pxa/ssp.c b/drivers/soc/pxa/ssp.c index bd029e838241..a1e8a07f7275 100644 --- a/drivers/soc/pxa/ssp.c +++ b/drivers/soc/pxa/ssp.c @@ -176,15 +176,13 @@ static int pxa_ssp_probe(struct platform_device *pdev) return 0; } -static int pxa_ssp_remove(struct platform_device *pdev) +static void pxa_ssp_remove(struct platform_device *pdev) { struct ssp_device *ssp = platform_get_drvdata(pdev); mutex_lock(&ssp_lock); list_del(&ssp->node); mutex_unlock(&ssp_lock); - - return 0; } static const struct platform_device_id ssp_id_table[] = { @@ -199,7 +197,7 @@ static const struct platform_device_id ssp_id_table[] = { static struct platform_driver pxa_ssp_driver = { .probe = pxa_ssp_probe, - .remove = pxa_ssp_remove, + .remove_new = pxa_ssp_remove, .driver = { .name = "pxa2xx-ssp", .of_match_table = of_match_ptr(pxa_ssp_of_ids),