From patchwork Mon Sep 25 09:55:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 144372 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp1115238vqu; Mon, 25 Sep 2023 03:45:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGUyzG/pEuuQUaJEFAcuuaEq9OTs4qM64oCfKlAY1HZGmQssOeL2WZT+0ZzIO7wSzb8SGLo X-Received: by 2002:a05:6a20:440d:b0:134:d4d3:f0a5 with SMTP id ce13-20020a056a20440d00b00134d4d3f0a5mr8623430pzb.2.1695638708542; Mon, 25 Sep 2023 03:45:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695638708; cv=none; d=google.com; s=arc-20160816; b=TfYP75XigFDFgRiaFY9dkFRzzoNEnSsqqlrYbwWrZlx2QzXXH9l84rgdSsnePaEkXd u2tUGFvfEm2EAgreLc6D4ZdamB+G2lxXCZ2IKGK1Hv6kgzk3ABno8JWDo+qmecHB951k KHl76FEsPVrmXufexT+nzy8E4syJzzPgTjOWrwRmpt8oqC/gyvFiH9LNqGhiU4j+yn0i TvHIIphG0uQS2QGx7Wg4WGI4W1wy9JsRanT+XYr0t1EcI8MG/PMhgoJB72nKqVK3KNU7 L+xcAkhjNEXWvPaBygZZr/cyrEKbiljdOb1LImt81ALItPLZof4GvuBm2FclRfvwBfBm qeJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=yB5MxEaKOQtTjLkHakVr/FW11onIt9ggDnw+6uhuDT4=; fh=CQONkf4yGPg5zbRYksrJcfg7BrV8CK2qTR14xwhw6UA=; b=sA0XxKUAyc8s8NiG7USw9p5FoRVEpg0SS+X1uGYlzL6uA8SQQcHPJmHk624W64Hw13 rl6XBTAYyuWqlYaf/WTLLXim57JPpGIYWOh0GjhuINxcdmPHe/JHlti4PT2Cu2KVmAyO oABsNDrcZuEM1G80IPN4OnGKhswzDs0o67LdVbXlBuFq5futm6PRzfuyw+KUb8a/mlpc bLP71hVOMWaUnE0qH3dg6hhjfc1EJ98vO5Hw0orfbjrjlXDFdXixTpBIJ7PwtL3liLAp hAcwin4xbxkYzTbBN9TJTVtt8Sfm5zW1QNHzwYJFBZTrAMW4iUpATjRUJKlC+Ucnvfvg wAwg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id x14-20020a17090abc8e00b00277374d74afsi4211232pjr.12.2023.09.25.03.45.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 03:45:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id B544D8027F18; Mon, 25 Sep 2023 02:57:05 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231151AbjIYJ44 (ORCPT + 29 others); Mon, 25 Sep 2023 05:56:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230025AbjIYJz4 (ORCPT ); Mon, 25 Sep 2023 05:55:56 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9C77106 for ; Mon, 25 Sep 2023 02:55:48 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qkiJY-0007vo-4O; Mon, 25 Sep 2023 11:55:40 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qkiJX-008pzZ-76; Mon, 25 Sep 2023 11:55:39 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qkiJW-004dlO-UI; Mon, 25 Sep 2023 11:55:38 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Conor Dooley , Daire McNamara Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 16/40] soc/microchip: mpfs-sys-controller: Convert to platform remove callback returning void Date: Mon, 25 Sep 2023 11:55:07 +0200 Message-Id: <20230925095532.1984344-17-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> References: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1915; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=qMSvMdLyWMVv0eJCyiyAecwlWse+6vZrOq8DCVNTw0k=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlEVhRLmiPsKzsDJkYR+pBw2aoZnqSIdabHXV7C DpcqEXgCa2JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZRFYUQAKCRCPgPtYfRL+ TmTYB/99Y/TSuw+jf9J9wshJHpxLVPHGRUpd5pY81V4tLP2iw+PzEksAiYPeQymUzFoH1qsh1Is t/RZu7byjFUcQGsdQUHYb01thd2I/BwqgtXqnj+9f12ZgIjs7T4uvIpZsMzscvrM2Z1/sMclYZV wdhVIxGpotONKw8apwUR4kd/G8FCPI2TcopqkrjyY9Ct4lrPx14ra2v6XX2VDVxBuH8RCNM/Ux4 eRqP8T8xLhpjFcbn9JNZGJucAUxruSr0cvVjqp0poxFMXVTwr7UVF+8ZZLrWnC6oyqNUrWCyCad HSTQYlWFtRsmsaS2sIQWLy7FhEOniQGQem/769udRIwibvDm X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 25 Sep 2023 02:57:05 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778006054515679810 X-GMAIL-MSGID: 1778006054515679810 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/soc/microchip/mpfs-sys-controller.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/soc/microchip/mpfs-sys-controller.c b/drivers/soc/microchip/mpfs-sys-controller.c index fbcd5fd24d7c..0935e9e94172 100644 --- a/drivers/soc/microchip/mpfs-sys-controller.c +++ b/drivers/soc/microchip/mpfs-sys-controller.c @@ -149,13 +149,11 @@ static int mpfs_sys_controller_probe(struct platform_device *pdev) return 0; } -static int mpfs_sys_controller_remove(struct platform_device *pdev) +static void mpfs_sys_controller_remove(struct platform_device *pdev) { struct mpfs_sys_controller *sys_controller = platform_get_drvdata(pdev); mpfs_sys_controller_put(sys_controller); - - return 0; } static const struct of_device_id mpfs_sys_controller_of_match[] = { @@ -207,7 +205,7 @@ static struct platform_driver mpfs_sys_controller_driver = { .of_match_table = mpfs_sys_controller_of_match, }, .probe = mpfs_sys_controller_probe, - .remove = mpfs_sys_controller_remove, + .remove_new = mpfs_sys_controller_remove, }; module_platform_driver(mpfs_sys_controller_driver);