From patchwork Mon Sep 25 09:55:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 144328 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp1096617vqu; Mon, 25 Sep 2023 03:04:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGPCMiNnITq/CSiFYAFnA4xYh30uXBg4TyD0ABHM0WkHotupCNZF9CnxVhUtwpOskAwa6w+ X-Received: by 2002:a05:6871:1c4:b0:1c8:d72a:d6ba with SMTP id q4-20020a05687101c400b001c8d72ad6bamr6665880oad.45.1695636240515; Mon, 25 Sep 2023 03:04:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695636240; cv=none; d=google.com; s=arc-20160816; b=eiKgNv8/EUYGajrHxkZBnQymu6LbqWiP+//eirzhsU8Y7E6gs6f8F/NmnR+6HMOyI7 sMY15woJTtyO/T5XZIZhzBomwN3mckEvE2x+qeEba3XqaAHCgWdUCzoAesA3aOg9D4+X dvuRv0kSahW5eKw3GvmJtzlTWoL0tTKZNm1QfRfcJ3NCUtcnBOXuKoJFL/WQKGszsDlW 91YJay36Ngf4kUG34hjRifZKXDvgrxHHEQH7lVkQ7t4UL4hvjfcsMEO/ZqTvv3ka6mcw M7yOQDY03Rkt55QC82g3ZNss++J62xa/fhc0vB8lZ2cxax7ceQydj2pZUZMCdu0Mj/53 HF5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=F6KiwW2oqFlfwA9YiUBHEwfkUgnOgarCUgM6zxIIQgc=; fh=M19OeAri8mdyWR8E6EuR589uowEODmmrablWnMiZ4ws=; b=woi/s9dEqi7xhUcaUqdvphypmhN3MjFS5x2/4T+8q1FJ0PSo6gEDpqO7834fCl/ZbP MrQmThK05+KiA3K+9TZSPeEyslUXMiBpQHtpMNNo7O6jCPLWhpBxu7wf2OEAJpjuQtle r9tguu/XkiTtWdvyXRGQP81s8AWpY5G5xe8V5OE1zo8q8buVJGkvvbgKtIcXBqHOx/V0 3t2au4DkrUhu9aY0ZH7cPUI69Hi7g6LYSkhr0M8D2fuB9/ycMqXH2iJlQEciUeW3JcyP yJqG+oXiHECNFompqcLan0F8kh41qO6Kwz+rYO0d54NZ8GB6GpQLQ3Uj//iTODstIRfz tZaQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id b17-20020a656691000000b005648d20203dsi9884989pgw.233.2023.09.25.03.04.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 03:04:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 77CEE80B19CE; Mon, 25 Sep 2023 02:56:49 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229726AbjIYJ4g (ORCPT + 29 others); Mon, 25 Sep 2023 05:56:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230042AbjIYJzw (ORCPT ); Mon, 25 Sep 2023 05:55:52 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85738DA for ; Mon, 25 Sep 2023 02:55:46 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qkiJX-0007qg-M8; Mon, 25 Sep 2023 11:55:39 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qkiJW-008pzO-Io; Mon, 25 Sep 2023 11:55:38 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qkiJW-004dlC-9A; Mon, 25 Sep 2023 11:55:38 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Yinbo Zhu Cc: loongarch@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 13/40] soc/loongson: loongson2_guts: Convert to platform remove callback returning void Date: Mon, 25 Sep 2023 11:55:04 +0200 Message-Id: <20230925095532.1984344-14-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> References: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1681; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=ATjpJg3Ymn3lpV/5/BensT0YUucFb6ICE/DcTgZnEiU=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlEVhOe/DWNmRhMPdnepAPTAePH9HSED/q6ORNq y4EcfxNb7WJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZRFYTgAKCRCPgPtYfRL+ TvGmCAChX5JJSKyWxFMa7rU47aHAgL6TpgnCjq94OMFLpaki4HemK4CGcqcXzVOOpb8Ibp7vjsg MZu3h8z/Lbwpavjrwo2L1g7Tq2Tlt2fWIH+F/zX7Eu4+VpphT9vNj0Gjp+VATd8mhbXk1YXE5HJ WcqyI/lLeOVm0dks8SLNWpVBN1UsfpJZyoTB4bpO6u3wnoFNwRqE2xCfeZslzh6B16qzGa5YTi4 yGWMU5gJryc5JulBxbszxRCcsGmlxgU98i9Iy+xytb17tOj+EQR770ZaMTMV0as7ldV2u/Z0miN d6lcfMkkifrfU6ut/kQFd4TW7Hp28ZAUSeAVCNDh1zGfigWT X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 25 Sep 2023 02:56:49 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778003466792314836 X-GMAIL-MSGID: 1778003466792314836 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/soc/loongson/loongson2_guts.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/soc/loongson/loongson2_guts.c b/drivers/soc/loongson/loongson2_guts.c index bace4bc8e03b..48f8382888a7 100644 --- a/drivers/soc/loongson/loongson2_guts.c +++ b/drivers/soc/loongson/loongson2_guts.c @@ -150,11 +150,9 @@ static int loongson2_guts_probe(struct platform_device *pdev) return 0; } -static int loongson2_guts_remove(struct platform_device *dev) +static void loongson2_guts_remove(struct platform_device *dev) { soc_device_unregister(soc_dev); - - return 0; } /* @@ -173,7 +171,7 @@ static struct platform_driver loongson2_guts_driver = { .of_match_table = loongson2_guts_of_match, }, .probe = loongson2_guts_probe, - .remove = loongson2_guts_remove, + .remove_new = loongson2_guts_remove, }; static int __init loongson2_guts_init(void)