From patchwork Mon Sep 25 09:55:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 144347 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp1097768vqu; Mon, 25 Sep 2023 03:06:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFqbuL5/LZPc5nBYDosXkjWbEQh/vny+rrHBLTetp71QN1ZTllrS8EkdwvDk5BxwaWu/G6H X-Received: by 2002:a05:6a20:1614:b0:15d:bc0f:9b64 with SMTP id l20-20020a056a20161400b0015dbc0f9b64mr5076326pzj.45.1695636370053; Mon, 25 Sep 2023 03:06:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695636370; cv=none; d=google.com; s=arc-20160816; b=m8qNn/0+JX3YXmmh9G6zPylJYyIWFh/W42IcHYicKyK6qp8VTrKBsumlruZhfAC9mv SwO9Wx/iRda8xM+qaoi4S3LukqsW4ZVirj/soSezX3CiLqG6PW95WLwTy9unKpufEJal HaXkNFP5QzdS2XPKY+vGC9w2m5oRYVGe9AfX/+LIFh/BFZQhh8SDjnIOZycjM/gZKZB0 1l3wnbNTfPO04Et6jnXABxD+jnk/SDZUqwk5ypxmgn/8D0rGrMp+/3yqZlsF67CbFDhR xx7G4+QYH8YsWTsrR4x4h7NPA9gMjfeFW/gDkoGMf9DsI+EKYGGzV/SmSwbTa16zjmnt XNag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=3AYW/Gmxf0zYpGMWubFGHDxfx6cool2g+rFrqok5894=; fh=2bBwuuA4om3O7YWuRtrCLSYy66XwRp4ocsXBnhc4xFQ=; b=ALA6I5XY0gBbn5zONDsTg6O6jFVGFmsjGeJpysEDfpkra9/08L8/BaSFpge2Ev9aqD kNZDVbYBx6Zt7gbRkqbhd3qi40jXeZVDfYUDfRuGjwQmkmiv35+ng4Dq/aCulWajB/N6 3oQ8ku6LjzkdT+2hvMq3J8fWELUOby53jrN9c+l4F8hyINVLNYBTlKjfDGqZGo1kRE87 oZuA1AqzEn2ZD7QOEYM511W49iX5OQw/JSFnMxFq/qzRBSo+I5xmtFS1S2JlZtnvJWn8 EYf7BRLiBTaSd2+JvzH3Gkqj93xZO3Y9xzziJHj9zuIBOUnBkJ8AEBhejACBMdmQ1YKJ 070w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id i8-20020a17090ad34800b00267ed8359e2si9607955pjx.55.2023.09.25.03.06.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 03:06:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 2D98D8063031; Mon, 25 Sep 2023 02:56:41 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230153AbjIYJz5 (ORCPT + 29 others); Mon, 25 Sep 2023 05:55:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229629AbjIYJzq (ORCPT ); Mon, 25 Sep 2023 05:55:46 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB011C6 for ; Mon, 25 Sep 2023 02:55:39 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qkiJW-0007na-Ei; Mon, 25 Sep 2023 11:55:38 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qkiJW-008pzG-2C; Mon, 25 Sep 2023 11:55:38 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qkiJV-004dl4-PJ; Mon, 25 Sep 2023 11:55:37 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Krzysztof Halasa Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 11/40] soc/ixp4xx: ixp4xx-qmgr: Convert to platform remove callback returning void Date: Mon, 25 Sep 2023 11:55:02 +0200 Message-Id: <20230925095532.1984344-12-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> References: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1717; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=HudFbgOcgVWKgqxMtzAy+tK9o9GlSRRwK6tTBfx+JS4=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlEVhMmDxj6OX/DR/bhIvlFUD5d6B8TbKN3gQz7 EKAN2ByP9GJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZRFYTAAKCRCPgPtYfRL+ TgFYB/44oA3f0XXEXVKeBOSu5mPOcVc6nis5SiomTDO+TuP/3MPMHeLWmQ+omdc3yj6nDHwYnro Lp1nc8AmtBlXzlzkOTsAXKj/qJR6xBGZ+6lB1jZvR5pN2g6EcT3NbVOPl350D/wGi/4mmY1f4lm G8ozjN+5mkmY5g3ldYNKxVI/QyXtaazAzRd+QJ50nfwpLXc+eIVgoeXI/QonEE8185eaDHX+44+ 3LTGCTSFaMG3zbILZ0t6+hnZpluWiOrOQYHi3dHfEWbchWHi0cba1C8PjHJO4dczWPKxLKp+huA C/tu8Qaa7DEps5/HQWafKiLWkKMIhhnFl+xptdgYnE9mkLpR X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 25 Sep 2023 02:56:41 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778003602750705492 X-GMAIL-MSGID: 1778003602750705492 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/soc/ixp4xx/ixp4xx-qmgr.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/soc/ixp4xx/ixp4xx-qmgr.c b/drivers/soc/ixp4xx/ixp4xx-qmgr.c index 291086bb9313..244ad8d7e80b 100644 --- a/drivers/soc/ixp4xx/ixp4xx-qmgr.c +++ b/drivers/soc/ixp4xx/ixp4xx-qmgr.c @@ -442,11 +442,10 @@ static int ixp4xx_qmgr_probe(struct platform_device *pdev) return 0; } -static int ixp4xx_qmgr_remove(struct platform_device *pdev) +static void ixp4xx_qmgr_remove(struct platform_device *pdev) { synchronize_irq(qmgr_irq_1); synchronize_irq(qmgr_irq_2); - return 0; } static const struct of_device_id ixp4xx_qmgr_of_match[] = { @@ -462,7 +461,7 @@ static struct platform_driver ixp4xx_qmgr_driver = { .of_match_table = ixp4xx_qmgr_of_match, }, .probe = ixp4xx_qmgr_probe, - .remove = ixp4xx_qmgr_remove, + .remove_new = ixp4xx_qmgr_remove, }; module_platform_driver(ixp4xx_qmgr_driver);