From patchwork Mon Sep 25 09:55:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 144367 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp1115095vqu; Mon, 25 Sep 2023 03:44:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGpwAvwRGfRyHXzgBQy8xDG8er2vKz2J0fuqrU54zrH0I1VTwUjr0ZpkD8NPkMoogqrlzo8 X-Received: by 2002:a17:90a:3d84:b0:26b:27f6:9027 with SMTP id i4-20020a17090a3d8400b0026b27f69027mr5490639pjc.1.1695638685960; Mon, 25 Sep 2023 03:44:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695638685; cv=none; d=google.com; s=arc-20160816; b=i1JAA/FONzXe6JqUZBiQXBKnJzYcMx6yiPJAJ9+aheWp05Sf2oED0u/7mMUt75KPLx TNmu+nI5xUHu5UumJXdrnDyBYYJl93cWlZN4zAVr52KrwdD/CZmO/yCFZdYKtOvMfvY0 NiLR0SrpHaryvoCk9M6u4T3MCEEvP8OJMytDVawMRzE79HQ1s9AsrOVRmRfstabx8XH/ fZ/ILKSXlCgtCR9hV9MBnsoDXjFcufGJzVrF5Cdree0bKwV9tpGwiKE8DcTV49t3oORZ baWJLow29sF8EMCn0q9HAFZGjoDDPKuOV8sJT7yXkmPgcI4x22glSF2M9DVFCgFILtWy OvZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=yP3itk5goUdK8cIU1HmeWDMUhjptpFpgIKIhoVrzT08=; fh=2bBwuuA4om3O7YWuRtrCLSYy66XwRp4ocsXBnhc4xFQ=; b=hkDxSdRlaKRXDHK7sEnljmtXiUO/lJ/5WxwPCNNRi3TAdaxMRy+MX1Uz1r0CDr02Hd 7uMtco4RePbeArcERO7fAesI6jZsj94KmUd5itVqld8/T/FIDy1ufVzLrHwRLNyhb/K3 bLf7IjhvnRrHK5/cfKri9b4nM/Bn6XKnbz4PD6IS3we2D0hYN1ggK0sHolEzco2Q++DO +K7EX2B46A9h9JGBAzjpr0Eosc4+IbLmhXFa/H3UegT8Uw5hlIXhng65zssmbKQl+pCS WI6JDKzjDz7cEe8VjIHWB/e9F/w9EP5AggL5H0XRzbU2+2E/7ycTIOV/nMroPpZobAgG puZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id u9-20020a17090adb4900b0026b502223cbsi4129928pjx.10.2023.09.25.03.44.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 03:44:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id DE1AF807453E; Mon, 25 Sep 2023 02:55:51 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229966AbjIYJzv (ORCPT + 29 others); Mon, 25 Sep 2023 05:55:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229579AbjIYJzq (ORCPT ); Mon, 25 Sep 2023 05:55:46 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D01E2C2 for ; Mon, 25 Sep 2023 02:55:39 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qkiJW-0007nR-9J; Mon, 25 Sep 2023 11:55:38 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qkiJV-008pzC-SL; Mon, 25 Sep 2023 11:55:37 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qkiJV-004dl0-J3; Mon, 25 Sep 2023 11:55:37 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Krzysztof Halasa Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 10/40] soc/ixp4xx: ixp4xx-npe: Convert to platform remove callback returning void Date: Mon, 25 Sep 2023 11:55:01 +0200 Message-Id: <20230925095532.1984344-11-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> References: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1795; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=nCrJKabnsqX9H53lylFo464Y3PbUHfbxoonMWHYMvkE=; b=owGbwMvMwMXY3/A7olbonx/jabUkhlTBCO/tvFlXHs77uTr0SoxW0lMNdosz6b3ro1N1rmYKG 8t5TLnRyWjMwsDIxSArpshi37gm06pKLrJz7b/LMINYmUCmMHBxCsBEQhay/xVotDtfoPXNI+8i b0roj3UGfOXXWRbeMfGoy1rOzpD0IHrelnXx+Q+Xp4iv6Kr7dSI3z6WSobYpw3eaqFpKpJ2shfh qWYVLZhrTbj6/qJbbxLSw57Danebpgd5H2YOi52bsFjVetlY2Pt6grsTmIm/Dmxr/S3cFZTnfRG 7J8DP6UJ3l6eT34SzL7nXXZz65KPqkXbk6W9jl044VbJtL1zqfbT8od2fLyZUsx7au+HQ1NG5ll sMlfs8tqwNuhoXMykw1DNaI2sPAtHWimOnhVbkyFQWCQsYtR+bZTL/OoC/zKFJfImteT4vFd615 d3lVE3/dXnTDw/l0x0HeC5IiDdp9LN/TDDcm79KSeqUBAA== X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 25 Sep 2023 02:55:51 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778006030504179963 X-GMAIL-MSGID: 1778006030504179963 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/soc/ixp4xx/ixp4xx-npe.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/soc/ixp4xx/ixp4xx-npe.c b/drivers/soc/ixp4xx/ixp4xx-npe.c index 5be9988f30ce..35825ee95dff 100644 --- a/drivers/soc/ixp4xx/ixp4xx-npe.c +++ b/drivers/soc/ixp4xx/ixp4xx-npe.c @@ -736,7 +736,7 @@ static int ixp4xx_npe_probe(struct platform_device *pdev) return 0; } -static int ixp4xx_npe_remove(struct platform_device *pdev) +static void ixp4xx_npe_remove(struct platform_device *pdev) { int i; @@ -744,8 +744,6 @@ static int ixp4xx_npe_remove(struct platform_device *pdev) if (npe_tab[i].regs) { npe_reset(&npe_tab[i]); } - - return 0; } static const struct of_device_id ixp4xx_npe_of_match[] = { @@ -761,7 +759,7 @@ static struct platform_driver ixp4xx_npe_driver = { .of_match_table = ixp4xx_npe_of_match, }, .probe = ixp4xx_npe_probe, - .remove = ixp4xx_npe_remove, + .remove_new = ixp4xx_npe_remove, }; module_platform_driver(ixp4xx_npe_driver);