| Message ID | 20230925081332.15906-6-j-keerthy@ti.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp1209956vqu;
Mon, 25 Sep 2023 06:26:13 -0700 (PDT)
X-Google-Smtp-Source:
AGHT+IF+cAHtTndNPqY9zsYLzSU8CWCr3dfLA3No+7mnFO/exDismyvpEdlDL/1jaMrPl8RMmiso
X-Received: by 2002:a17:90b:3e8c:b0:277:11b1:d5c4 with SMTP id
rj12-20020a17090b3e8c00b0027711b1d5c4mr5913637pjb.41.1695648373519;
Mon, 25 Sep 2023 06:26:13 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1695648373; cv=none;
d=google.com; s=arc-20160816;
b=JY9oGxHFLYkS9SPLjvU6QvQZ+kwxCd5YcjhyxwxpAuIebvYzaGETkyuC5fkjgoiSth
JmnUZjNsVGo99LtBf28FSzRcLpkuuuXYaAItJaYUI7FuKnvISv8xHdEs0Ee/iEqrUaJA
bOiWLf1r6sZy0EhKpaM8uSStc6zGZ7w1ME9fuSz6jRx91MZNyyZxGo6J3P3Kn3MFk6ko
lyEWVvC84he8Ev9Bhu4jIswzeFd9Tbcj3AurWK1ppKKZ/pYCs3SoUEGkJLeU9DODquKh
5yEbdUlIPHchBzOhnxKIgQQNtvuXfnZOzK/oRFkHZ8+XxESWLlrRhPcLH0pdqZRTv7dr
edGg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:mime-version:references:in-reply-to:message-id
:date:subject:cc:to:from:dkim-signature;
bh=f9ZWPSYeF4dTQs163qkKOD80Qa2VkjFxu370RMZajsg=;
fh=o4PFLqU4Z+JLVMnI9bVS5jAHyZaUDjrT7v5G6HFgWcM=;
b=PUWnDtEPAuRdG+aqIbreSYyh244ggyZYUhHn3XXw1WngVKbD68mkoZ39Dlztm7ds2m
4nxuAFk2+7CEDKIjY8MlZbq7Ze038XCoJToSwQJmqpPg4rIlKcLxak9frjHjEGbTvxdR
cY+2CuaA9fCVVMSajTMUEUOGkvGVvfbORzPN0nkdyT2LPJ6ZtVpdsDOl50A4lejvLTMq
0WFkMloUvTv1VmtIbdgp+mJprKVjNWNPurJLPExFi8LeD8wu/cELBD3O396COK6mdb+L
+kQ3NZU5HftlxzFo0Ddu1TetNZbvX3K8YvTgOmT0UGsPjfqNx4mad8o0ffdOI+NFaA3H
QgGA==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=CIbcecZ6;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:2 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com
Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2])
by mx.google.com with ESMTPS id
mi2-20020a17090b4b4200b00277636a9e5csi1860746pjb.96.2023.09.25.06.26.13
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 25 Sep 2023 06:26:13 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:2 as permitted sender)
client-ip=2620:137:e000::3:2;
Authentication-Results: mx.google.com;
dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=CIbcecZ6;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:2 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com
Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0])
by agentk.vger.email (Postfix) with ESMTP id 29C558090E83;
Mon, 25 Sep 2023 01:15:39 -0700 (PDT)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S231849AbjIYIPI (ORCPT <rfc822;ezelljr.billy@gmail.com>
+ 30 others); Mon, 25 Sep 2023 04:15:08 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55430 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S232921AbjIYIOn (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Mon, 25 Sep 2023 04:14:43 -0400
Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8023F10F7;
Mon, 25 Sep 2023 01:14:12 -0700 (PDT)
Received: from fllv0035.itg.ti.com ([10.64.41.0])
by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 38P8DxkP114419;
Mon, 25 Sep 2023 03:13:59 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com;
s=ti-com-17Q1; t=1695629639;
bh=f9ZWPSYeF4dTQs163qkKOD80Qa2VkjFxu370RMZajsg=;
h=From:To:CC:Subject:Date:In-Reply-To:References;
b=CIbcecZ6QFFywQetnXdkxvz/kaExpMAjuqt7kN7TGCqeA7FbHvPe4qyXoAmcNWZva
JELsTVYkM1CrFUggmwkzBjwanxD+EM6lhEznhY40VWN8ES7RL8W0ruudhEtHmyLLeG
YXINVCQ0njTbwn+gDFvJ0Qc+scBARwM0+WMouJpo=
Received: from DFLE105.ent.ti.com (dfle105.ent.ti.com [10.64.6.26])
by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 38P8Dxnd044556
(version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL);
Mon, 25 Sep 2023 03:13:59 -0500
Received: from DFLE100.ent.ti.com (10.64.6.21) by DFLE105.ent.ti.com
(10.64.6.26) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Mon, 25
Sep 2023 03:13:59 -0500
Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE100.ent.ti.com
(10.64.6.21) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via
Frontend Transport; Mon, 25 Sep 2023 03:13:58 -0500
Received: from keerthy.dhcp.ti.com (ileaxei01-snat2.itg.ti.com [10.180.69.6])
by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 38P8Db3J007734;
Mon, 25 Sep 2023 03:13:55 -0500
From: Keerthy <j-keerthy@ti.com>
To: <robh+dt@kernel.org>, <nm@ti.com>, <vigneshr@ti.com>,
<conor+dt@kernel.org>, <kristo@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>
CC: <j-keerthy@ti.com>, <u-kumar1@ti.com>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH v4 5/7] arm64: dts: ti: k3-j784s4-mcu: Add the main domain
watchdog instances
Date: Mon, 25 Sep 2023 13:43:30 +0530
Message-ID: <20230925081332.15906-6-j-keerthy@ti.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20230925081332.15906-1-j-keerthy@ti.com>
References: <20230925081332.15906-1-j-keerthy@ti.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test,
not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]);
Mon, 25 Sep 2023 01:15:39 -0700 (PDT)
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1778016188775059306
X-GMAIL-MSGID: 1778016188775059306
|
| Series |
arm64: ti: k3-j7: Add the ESM & main domain watchdog nodes
|
|
Commit Message
J, KEERTHY
Sept. 25, 2023, 8:13 a.m. UTC
There are totally 2 instances of watchdog module in MCU domain.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
.../boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi | 20 +++++++++++++++++++
1 file changed, 20 insertions(+)
Comments
On 13:43-20230925, Keerthy wrote: > There are totally 2 instances of watchdog module in MCU domain. > > Signed-off-by: Keerthy <j-keerthy@ti.com> > --- > .../boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi > index a7b5c4cb7d3e..0b7cc277a567 100644 > --- a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi > @@ -714,4 +714,24 @@ > ti,esm-pins = <63>; > bootph-pre-ram; > }; > + > + mcu_watchdog0: watchdog@40600000 { > + compatible = "ti,j7-rti-wdt"; > + reg = <0x00 0x40600000 0x00 0x100>; > + clocks = <&k3_clks 367 1>; > + power-domains = <&k3_pds 367 TI_SCI_PD_EXCLUSIVE>; > + assigned-clocks = <&k3_clks 367 0>; > + assigned-clock-parents = <&k3_clks 367 4>; > + status = "disabled"; > + }; > + > + mcu_watchdog1: watchdog@40610000 { > + compatible = "ti,j7-rti-wdt"; > + reg = <0x00 0x40610000 0x00 0x100>; > + clocks = <&k3_clks 368 1>; > + power-domains = <&k3_pds 368 TI_SCI_PD_EXCLUSIVE>; > + assigned-clocks = <&k3_clks 368 0>; > + assigned-clock-parents = <&k3_clks 368 4>; > + status = "disabled"; Explain in commit message as to why these are disabled. I believe it is because this RTI instances are tightly coupled to the micro controllers. but that information needs to be documented. > + }; > }; > -- > 2.17.1 >
On 9/25/2023 6:49 PM, Nishanth Menon wrote: > On 13:43-20230925, Keerthy wrote: >> There are totally 2 instances of watchdog module in MCU domain. >> >> Signed-off-by: Keerthy <j-keerthy@ti.com> >> --- >> .../boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi | 20 +++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi >> index a7b5c4cb7d3e..0b7cc277a567 100644 >> --- a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi >> @@ -714,4 +714,24 @@ >> ti,esm-pins = <63>; >> bootph-pre-ram; >> }; >> + >> + mcu_watchdog0: watchdog@40600000 { >> + compatible = "ti,j7-rti-wdt"; >> + reg = <0x00 0x40600000 0x00 0x100>; >> + clocks = <&k3_clks 367 1>; >> + power-domains = <&k3_pds 367 TI_SCI_PD_EXCLUSIVE>; >> + assigned-clocks = <&k3_clks 367 0>; >> + assigned-clock-parents = <&k3_clks 367 4>; >> + status = "disabled"; >> + }; >> + >> + mcu_watchdog1: watchdog@40610000 { >> + compatible = "ti,j7-rti-wdt"; >> + reg = <0x00 0x40610000 0x00 0x100>; >> + clocks = <&k3_clks 368 1>; >> + power-domains = <&k3_pds 368 TI_SCI_PD_EXCLUSIVE>; >> + assigned-clocks = <&k3_clks 368 0>; >> + assigned-clock-parents = <&k3_clks 368 4>; >> + status = "disabled"; > > Explain in commit message as to why these are disabled. I believe it is > because this RTI instances are tightly coupled to the micro > controllers. but that information needs to be documented. Sure. I will add that to the commit message. >> + }; >> }; >> -- >> 2.17.1 >> >
On 21:03-20230925, J, KEERTHY wrote: > > > On 9/25/2023 6:49 PM, Nishanth Menon wrote: > > On 13:43-20230925, Keerthy wrote: > > > There are totally 2 instances of watchdog module in MCU domain. > > > > > > Signed-off-by: Keerthy <j-keerthy@ti.com> > > > --- > > > .../boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi | 20 +++++++++++++++++++ > > > 1 file changed, 20 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi > > > index a7b5c4cb7d3e..0b7cc277a567 100644 > > > --- a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi > > > +++ b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi > > > @@ -714,4 +714,24 @@ > > > ti,esm-pins = <63>; > > > bootph-pre-ram; > > > }; > > > + > > > + mcu_watchdog0: watchdog@40600000 { > > > + compatible = "ti,j7-rti-wdt"; > > > + reg = <0x00 0x40600000 0x00 0x100>; > > > + clocks = <&k3_clks 367 1>; > > > + power-domains = <&k3_pds 367 TI_SCI_PD_EXCLUSIVE>; > > > + assigned-clocks = <&k3_clks 367 0>; > > > + assigned-clock-parents = <&k3_clks 367 4>; > > > + status = "disabled"; > > > + }; > > > + > > > + mcu_watchdog1: watchdog@40610000 { > > > + compatible = "ti,j7-rti-wdt"; > > > + reg = <0x00 0x40610000 0x00 0x100>; > > > + clocks = <&k3_clks 368 1>; > > > + power-domains = <&k3_pds 368 TI_SCI_PD_EXCLUSIVE>; > > > + assigned-clocks = <&k3_clks 368 0>; > > > + assigned-clock-parents = <&k3_clks 368 4>; > > > + status = "disabled"; > > > > Explain in commit message as to why these are disabled. I believe it is > > because this RTI instances are tightly coupled to the micro > > controllers. but that information needs to be documented. > > Sure. I will add that to the commit message. And inline to code for context, please.
diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi index a7b5c4cb7d3e..0b7cc277a567 100644 --- a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi +++ b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi @@ -714,4 +714,24 @@ ti,esm-pins = <63>; bootph-pre-ram; }; + + mcu_watchdog0: watchdog@40600000 { + compatible = "ti,j7-rti-wdt"; + reg = <0x00 0x40600000 0x00 0x100>; + clocks = <&k3_clks 367 1>; + power-domains = <&k3_pds 367 TI_SCI_PD_EXCLUSIVE>; + assigned-clocks = <&k3_clks 367 0>; + assigned-clock-parents = <&k3_clks 367 4>; + status = "disabled"; + }; + + mcu_watchdog1: watchdog@40610000 { + compatible = "ti,j7-rti-wdt"; + reg = <0x00 0x40610000 0x00 0x100>; + clocks = <&k3_clks 368 1>; + power-domains = <&k3_pds 368 TI_SCI_PD_EXCLUSIVE>; + assigned-clocks = <&k3_clks 368 0>; + assigned-clock-parents = <&k3_clks 368 4>; + status = "disabled"; + }; };