From patchwork Mon Sep 25 08:11:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lukasz Luba X-Patchwork-Id: 144261 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp1052455vqu; Mon, 25 Sep 2023 01:15:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGAlUTxqyzSAOFcDQsID7JVN+A93L9edQpDMdjDERwO+aCKk0P5zuJnHVi9HZl06XduTRs3 X-Received: by 2002:a17:902:aa41:b0:1c5:f110:efa0 with SMTP id c1-20020a170902aa4100b001c5f110efa0mr3364541plr.30.1695629750244; Mon, 25 Sep 2023 01:15:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695629750; cv=none; d=google.com; s=arc-20160816; b=l9ogFnDiw7Qn9uvm9b/RjdaTC8UeTfR2+juu+g/XR+FooulITnzIvETEv182XWT2JP gZ7Is4Thb4yX4Bhy1j3P6YRWHas/vBQj/mQXH3C0jK2i7iTjOYahePc52YMTGgweM2gW pMhGOXwfrMJK3KN5o4kTz6WBbSie1SmP274lsBozCdlIWK+P9HfsH8BK5Em+KiXZsOSR BeQGyHGD/OK/ttkA0IlwgJvD+yD+CLkH02B7lmdRPphf2KLqD1YvIT2MMtYAe9HKv731 +U1ESU68+7x0b6XoNRKrCeRrFAxfUiQFnlzkT7SCEjojRFpMAff9kEt6m0iPt+z3TK32 ZstA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=e9cA+0DkJFR+tPXa3CKCd2sCKzNan0sHKPOnU9erHAE=; fh=jF+j1UEDAwnYbShW3HmO1TshMsWh36Jt7pSLTP62NeE=; b=CGkyH7J81/WtXZOblJUIRWvJY8ztvBt8G7HtdW2GwbtQ5pn6e26FYANgbiudmAcXsA mt45jDDWMLiCa8k4HaXTVM/hALZWn7klmwL8ZXZAgHIq+jAUN6DbM8cNAFEZJoMoaliV NPf4x3fP0Oyyt1Qzc1v8WDWCDVRl8pEdNctjyFPetDO5ORQDWqPCUlJkm15nB/1WNi/t i8JUSC+40gziBPZXTWwPALCLwOsnCYfjLjL63ESKrzHMKZK/TR5k/rs6ny/kkjrBbT64 YSfrZYQNkHUgvaoCIVX8XPm69cuNOH2dCHl6SP90ZZESYnaj17AMSQMn+CLltkGlz4V2 A+Ew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id s11-20020a170903200b00b001b886a0c366si8522729pla.122.2023.09.25.01.15.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 01:15:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 393BA81A0C0E; Mon, 25 Sep 2023 01:11:53 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232673AbjIYILf (ORCPT + 30 others); Mon, 25 Sep 2023 04:11:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232693AbjIYIL0 (ORCPT ); Mon, 25 Sep 2023 04:11:26 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 00E5CFC; Mon, 25 Sep 2023 01:11:17 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9C4551474; Mon, 25 Sep 2023 01:11:55 -0700 (PDT) Received: from e129166.arm.com (unknown [10.57.93.139]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id F2E633F5A1; Mon, 25 Sep 2023 01:11:14 -0700 (PDT) From: Lukasz Luba To: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, rafael@kernel.org Cc: lukasz.luba@arm.com, dietmar.eggemann@arm.com, rui.zhang@intel.com, amit.kucheria@verdurent.com, amit.kachhap@gmail.com, daniel.lezcano@linaro.org, viresh.kumar@linaro.org, len.brown@intel.com, pavel@ucw.cz, mhiramat@kernel.org, qyousef@layalina.io, wvw@google.com Subject: [PATCH v4 02/18] PM: EM: Refactor em_cpufreq_update_efficiencies() arguments Date: Mon, 25 Sep 2023 09:11:23 +0100 Message-Id: <20230925081139.1305766-3-lukasz.luba@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230925081139.1305766-1-lukasz.luba@arm.com> References: <20230925081139.1305766-1-lukasz.luba@arm.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 25 Sep 2023 01:11:53 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777996660836311192 X-GMAIL-MSGID: 1777996660836311192 In order to prepare the code for the modifiable EM perf_state table, refactor existing function em_cpufreq_update_efficiencies(). Signed-off-by: Lukasz Luba --- kernel/power/energy_model.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/kernel/power/energy_model.c b/kernel/power/energy_model.c index 8b9dd4a39f63..42486674b834 100644 --- a/kernel/power/energy_model.c +++ b/kernel/power/energy_model.c @@ -237,10 +237,10 @@ static int em_create_pd(struct device *dev, int nr_states, return 0; } -static void em_cpufreq_update_efficiencies(struct device *dev) +static void +em_cpufreq_update_efficiencies(struct device *dev, struct em_perf_state *table) { struct em_perf_domain *pd = dev->em_pd; - struct em_perf_state *table; struct cpufreq_policy *policy; int found = 0; int i; @@ -254,8 +254,6 @@ static void em_cpufreq_update_efficiencies(struct device *dev) return; } - table = pd->table; - for (i = 0; i < pd->nr_perf_states; i++) { if (!(table[i].flags & EM_PERF_STATE_INEFFICIENT)) continue; @@ -397,7 +395,7 @@ int em_dev_register_perf_domain(struct device *dev, unsigned int nr_states, dev->em_pd->flags |= flags; - em_cpufreq_update_efficiencies(dev); + em_cpufreq_update_efficiencies(dev, dev->em_pd->table); em_debug_create_pd(dev); dev_info(dev, "EM: created perf domain\n");