diff mbox series

gnss: tell what GNSS means

Message ID 20230925054346.18065-1-rdunlap@infradead.org
State New
Headers
Series gnss: tell what GNSS means |

Commit Message

Randy Dunlap Sept. 25, 2023, 5:43 a.m. UTC 
  Tell users what GNSS means in the Kconfig prompt.

Fixes: 2b6a44035143 ("gnss: add GNSS receiver subsystem")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Johan Hovold <johan@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/gnss/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Johan Hovold Oct. 16, 2023, 2:38 p.m. UTC | #1 
On Sun, Sep 24, 2023 at 10:43:46PM -0700, Randy Dunlap wrote:
> Tell users what GNSS means in the Kconfig prompt.
 
>  menuconfig GNSS
> -	tristate "GNSS receiver support"
> +	tristate "GNSS (Global Navigation Satellite System) receiver support"

No, I don't like the way this clutters menuconfig. The above would make
this one of the longest entries and for very little gain.

We don't spell out NVMe or SPI either and I think the help text below
is clear enough as anyone not yet familiar with the concept of "GNSS
receivers" is sure to at least have heard of "GPS receivers" (which we
also don't spell out).

>  	help
>  	  Say Y here if you have a GNSS receiver (e.g. a GPS receiver).

Johan
Pavel Machek Oct. 29, 2023, 7:15 a.m. UTC | #2 
On Mon 2023-10-16 16:38:28, Johan Hovold wrote:
> On Sun, Sep 24, 2023 at 10:43:46PM -0700, Randy Dunlap wrote:
> > Tell users what GNSS means in the Kconfig prompt.
>  
> >  menuconfig GNSS
> > -	tristate "GNSS receiver support"
> > +	tristate "GNSS (Global Navigation Satellite System) receiver support"
> 
> No, I don't like the way this clutters menuconfig. The above would make
> this one of the longest entries and for very little gain.

Yeah, because everyone knows what GNSS means.

Except that most people know GNSS as GPS. You misnamed the subsystem,
so it now needs explanation :-(.
								Pavel
Randy Dunlap Oct. 29, 2023, 12:13 p.m. UTC | #3 
On 10/29/23 00:15, Pavel Machek wrote:
> On Mon 2023-10-16 16:38:28, Johan Hovold wrote:
>> On Sun, Sep 24, 2023 at 10:43:46PM -0700, Randy Dunlap wrote:
>>> Tell users what GNSS means in the Kconfig prompt.
>>  
>>>  menuconfig GNSS
>>> -	tristate "GNSS receiver support"
>>> +	tristate "GNSS (Global Navigation Satellite System) receiver support"
>>
>> No, I don't like the way this clutters menuconfig. The above would make
>> this one of the longest entries and for very little gain.
> 
> Yeah, because everyone knows what GNSS means.
> 
> Except that most people know GNSS as GPS. You misnamed the subsystem,
> so it now needs explanation :-(.
> 								Pavel

Thanks.  Obviously I agree.
Johan Hovold Oct. 30, 2023, 10:10 a.m. UTC | #4 
On Sun, Oct 29, 2023 at 08:15:41AM +0100, Pavel Machek wrote:
> On Mon 2023-10-16 16:38:28, Johan Hovold wrote:
> > On Sun, Sep 24, 2023 at 10:43:46PM -0700, Randy Dunlap wrote:
> > > Tell users what GNSS means in the Kconfig prompt.
> >  
> > >  menuconfig GNSS
> > > -	tristate "GNSS receiver support"
> > > +	tristate "GNSS (Global Navigation Satellite System) receiver support"
> > 
> > No, I don't like the way this clutters menuconfig. The above would make
> > this one of the longest entries and for very little gain.
> 
> Yeah, because everyone knows what GNSS means.

It's an established term (e.g. see [1]), and as I mentioned in the
context you dropped we don't spell out what NVMe or SPI stands for
either.

> Except that most people know GNSS as GPS. You misnamed the subsystem,
> so it now needs explanation :-(.

No, naming it GPS would have been too specific as these receivers are
not just for GPS.

Either way, this is about not cluttering up menuconfig and making that
harder to navigate for no good reason.

Johan

[1] https://www.u-blox.com/en/positioning-chips-and-modules
diff mbox series

Patch

diff -- a/drivers/gnss/Kconfig b/drivers/gnss/Kconfig
--- a/drivers/gnss/Kconfig
+++ b/drivers/gnss/Kconfig
@@ -4,7 +4,7 @@ 
 #
 
 menuconfig GNSS
-	tristate "GNSS receiver support"
+	tristate "GNSS (Global Navigation Satellite System) receiver support"
 	help
 	  Say Y here if you have a GNSS receiver (e.g. a GPS receiver).