From patchwork Sun Sep 24 19:25:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Jernej_=C5=A0krabec?= X-Patchwork-Id: 144136 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp808363vqu; Sun, 24 Sep 2023 12:31:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFgBELYf24M1YTnbGtVvGuZE912U4y0SXkQjiW9PsZKCa2ML2CgeVOajQ/kid5smUH59hFx X-Received: by 2002:a05:6a21:3e07:b0:147:d861:50e4 with SMTP id bk7-20020a056a213e0700b00147d86150e4mr3132523pzc.33.1695583912220; Sun, 24 Sep 2023 12:31:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695583912; cv=none; d=google.com; s=arc-20160816; b=uRDcn1q0mg8ZEa3KFEVGyGjJxXr4+NI9XfgIbeUfM0mFNDxLnC6CpDJnyiwhBmTm79 vuyXIp5ahuI1Mb575re0xtKR0u1vuG9FWcQJrCIGWuwcy94e6o+pe6mJ19GFsXrd7hFj sNdTPOKkZZEfVMDUnXBLg+R3sMD1r987akui0PRNlJ5CAzf+ZcdgZPXd13vDWh+gSiBi QSdYfm++664bTWaOavmZxfO6Q+P1trreltNtMAQGDjiJlT2qt7RydIhxLBZOEArTx8VB JiYux8udVzfTMhA215ddZd+3jbnROZbIHT70Ka48jK0GgKM29/osnd62CHvrLb28Aog1 3RWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=d66F58Zyq56V9Vs4Hyo0TkmljKT89gyNoM7Khlph/EE=; fh=ythuQA64SNE7wujD11OFYiH8HaGGRVN0m1KGJA3eIXU=; b=Vc/UTkt78YUFHRLOulnO7qXCWc+dfYzQ3R1KNpp527T9dViN9EbwPJ/u4TQIE1hNTU abnKae2dJb4Zysa9EZkzDeI7c4bX0X0Jah74oqqM3HTLgXnhSgbKEhkOB8ClsfBKQBfX +3qkHKhcEkDjODgU2ON978WDWOZC9qPy3RTuYMb5i062puMrEorQnJ1ssJMB2Tb4+reF /4MHB8wrrimbEeNNb50k8NCLsocU21QL7mKSUb5JcbN28fAIh/9yOX7I0BQO8NPSi0dt oG53TR1KymRaGrO/prUFDoD9I9gxEujdqJR4ZUZ3x31cunO8qPxvGS1X79xcIYkwU/h3 AZnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=XQ+ERoKk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id kz4-20020a170902f9c400b001bda93595d9si1271469plb.604.2023.09.24.12.31.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Sep 2023 12:31:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=XQ+ERoKk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 631EC808EF49; Sun, 24 Sep 2023 12:26:53 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229883AbjIXT0X (ORCPT + 30 others); Sun, 24 Sep 2023 15:26:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbjIXT0V (ORCPT ); Sun, 24 Sep 2023 15:26:21 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68E2EFA for ; Sun, 24 Sep 2023 12:26:15 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-9ae7383b7ecso893672566b.0 for ; Sun, 24 Sep 2023 12:26:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695583574; x=1696188374; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=d66F58Zyq56V9Vs4Hyo0TkmljKT89gyNoM7Khlph/EE=; b=XQ+ERoKkivTUgW0gcspZnVZ84aEm/rPMUHkgMDsgLqxjI8bCErRo0ww0iEW3Faztxe KHJIujXXIu20Npr+GVtxZYZ+dx+TxAa2AY0eHxDgN9K+Z5oW0alqZNs6uu4Ru+nvWtqJ hTahv5ZKqJJZN5IwClKPxoh1UIyZhoMk/QOm3YQzzgBcM7tiAEAM4u7kR/Y9GjOD2fzg kmjGamcnusJxHBpPghQsvddBNq2SOuuWSGH8NNldDDKeCH24ZLWpFi2VjrmTTnww/e9v z2ClAo3WJ+i4H/W4EqqoG/CeQEuFep2FJP/8qLXE2n943ez7HWT5xUYpqQbHBm0vl25k Swbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695583574; x=1696188374; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d66F58Zyq56V9Vs4Hyo0TkmljKT89gyNoM7Khlph/EE=; b=nU8hoOnumPzyQuiq5cbhcY3I1UIxI5r7AMTV5blIy/gzUINCDbfp7sUh97tPvRzvA6 PlCfIB26p/TLnRCgnmPErbCG4XXDaaYhCve/71CjB4Qb+/1/BFwvCKBuYydXmg6Hfb0A CbCz3CJx8DyUBo2qESP91Kthcq8O1to4oqMcgOa/N8QLlmET7N2q+Em0ZrdP1Q3AFP/h jjiPOwRHUMsp3MA2vqB3VwmugViza5gxPwhg+OrvzcX9UJvvynjvdFmrjkvzk+ioHk9T O9c7JGBmeU8SBOZAyIZAY3YAE9GWPVwT3Te1t+Kp2QxQE7MWpqAhb9rG1/tROdzPjiSp Zy8A== X-Gm-Message-State: AOJu0YyogqECgKM4uEv10eKo9PKKdzcARoVRi1sbpyBWsJy4mc0AJNu3 jFTlUWBnQocgsGOMhqCasG4= X-Received: by 2002:a17:906:74d3:b0:9ae:614e:4560 with SMTP id z19-20020a17090674d300b009ae614e4560mr7802850ejl.29.1695583573619; Sun, 24 Sep 2023 12:26:13 -0700 (PDT) Received: from localhost.localdomain (82-149-12-148.dynamic.telemach.net. [82.149.12.148]) by smtp.gmail.com with ESMTPSA id z21-20020a1709063a1500b0099d0c0bb92bsm5317632eje.80.2023.09.24.12.26.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Sep 2023 12:26:13 -0700 (PDT) From: Jernej Skrabec To: mripard@kernel.org, wens@csie.org Cc: airlied@gmail.com, daniel@ffwll.ch, samuel@sholland.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Jernej Skrabec Subject: [PATCH 1/7] drm/sun4i: dw-hdmi: Deinit PHY in fail path Date: Sun, 24 Sep 2023 21:25:58 +0200 Message-ID: <20230924192604.3262187-2-jernej.skrabec@gmail.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20230924192604.3262187-1-jernej.skrabec@gmail.com> References: <20230924192604.3262187-1-jernej.skrabec@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Sun, 24 Sep 2023 12:26:53 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777948596436328790 X-GMAIL-MSGID: 1777948596436328790 Commit 9bf3797796f5 ("drm/sun4i: dw-hdmi: Make HDMI PHY into a platform device") removed code for PHY deinitialization in fail path. Add it back. Fixes: 9bf3797796f5 ("drm/sun4i: dw-hdmi: Make HDMI PHY into a platform device") Signed-off-by: Jernej Skrabec Acked-by: Maxime Ripard --- drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c index 4727dfaa8fb9..0b647b030b15 100644 --- a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c +++ b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c @@ -203,6 +203,7 @@ static int sun8i_dw_hdmi_bind(struct device *dev, struct device *master, cleanup_encoder: drm_encoder_cleanup(encoder); + sun8i_hdmi_phy_deinit(hdmi->phy); err_disable_clk_tmds: clk_disable_unprepare(hdmi->clk_tmds); err_assert_ctrl_reset: