From patchwork Sun Sep 24 17:23:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Biju Das X-Patchwork-Id: 144127 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp764925vqu; Sun, 24 Sep 2023 10:23:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEiFopeBRfEfxaiFVzBza2sBHchNnDcxh1uwP4/586LdT8MPruEj2XXRxigyYmvm2euy34b X-Received: by 2002:a05:6a20:1614:b0:15e:1486:1e08 with SMTP id l20-20020a056a20161400b0015e14861e08mr6184550pzj.19.1695576220056; Sun, 24 Sep 2023 10:23:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695576220; cv=none; d=google.com; s=arc-20160816; b=j5RhXaq4pZN4d1cPSd0OGV6BAR4Ahrnj7zd6axLjsQofbjAe7TCM4lyKB9ljkFHVX5 8nKwiQjzJr9lJW+wtL+SKxb2bfYGjqk0baiVWDRAMzcpqwv2sfs5aHWW3Wi1dkM2eGlZ /1wbJDIKBdsxKSMAccu2OkxAqZko33rP3tuLLn2oJfa+ClWovZWDNbG/xeRsZ8ELMu6I DsuDsDmhoTAAtRaUyQoj6272psw2lRi7WchXARBkJ1TMFs3/ofYKThUbN9JnA4AAAWAl xvmuh0XYbHZlaga1/vAt0NGZGPJrOxIeynpuLIfr1QQg7BMPALcGLlWOnO/ymUMH0bSF pKZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=R8jvPd0r1RD6yq16U8YauBHM/b/06n7bmG5MYCYD0ZI=; fh=xeSrQ7kCdgcCVb2zAn5rBkDAdtmCo24cOODwKpU9NDo=; b=AQdQIF3+Z3lGQhgw1qL8FFLprRREqJsSrVepZ1RmBhMgjcjUjbD8vs2QJ+rBM47Uux 7L0kE9F14je99SFgL9iwQFhB6JfBasZ5tEtfHSaJKgxyShZdyq9ewSOULvDnWspd60yZ o1esnHNLT8ki8TOs9ohPjG703BcehxdJ1KW5aH/Ddm6mNvAcoUDuNDxJ/ElLZqkRC6Q7 a4UvwMODcLK/KUcJTc9K933VFLL8qdx1LHaR0/mYimVzFPGCvMVxBVp1egVMeYqn0kXv SS4/U9RfEMUwMXRhK8APCg5iqhvVhVkw0diYkXIZXmOGrmytDq++dzrq0flLm48lDHZ+ XTyw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=renesas.com Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id cd10-20020a056a00420a00b006875398611csi8147737pfb.80.2023.09.24.10.23.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Sep 2023 10:23:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=renesas.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 5481A8283A4C; Sun, 24 Sep 2023 10:23:39 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230218AbjIXRXh (ORCPT + 30 others); Sun, 24 Sep 2023 13:23:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230190AbjIXRXg (ORCPT ); Sun, 24 Sep 2023 13:23:36 -0400 Received: from relmlie6.idc.renesas.com (relmlor2.renesas.com [210.160.252.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 748E4FC; Sun, 24 Sep 2023 10:23:29 -0700 (PDT) X-IronPort-AV: E=Sophos;i="6.03,173,1694703600"; d="scan'208";a="180780918" Received: from unknown (HELO relmlir6.idc.renesas.com) ([10.200.68.152]) by relmlie6.idc.renesas.com with ESMTP; 25 Sep 2023 02:23:29 +0900 Received: from localhost.localdomain (unknown [10.226.92.4]) by relmlir6.idc.renesas.com (Postfix) with ESMTP id 47405402D0AE; Mon, 25 Sep 2023 02:23:27 +0900 (JST) From: Biju Das To: Linus Walleij Cc: Biju Das , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Biju Das , Andy Shevchenko Subject: [PATCH v3 1/3] pinctrl: mcp23s08_i2c: Extend match support for OF tables Date: Sun, 24 Sep 2023 18:23:18 +0100 Message-Id: <20230924172320.15165-2-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230924172320.15165-1-biju.das.jz@bp.renesas.com> References: <20230924172320.15165-1-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Sun, 24 Sep 2023 10:23:39 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777940530152433174 X-GMAIL-MSGID: 1777940530152433174 The driver has OF match table, still it uses ID lookup table for retrieving match data. Currently the driver is working on the assumption that a I2C device registered via OF will always match a legacy I2C device ID. The correct approach is to have an OF device ID table using of_device_match_data() if the devices are registered via OF. Signed-off-by: Biju Das Reviewed-by: Andy Shevchenko --- v2->v3: * Added Rb tag from Andy. v1->v2: * Arranged variable declaration in reverse xmas tree. --- drivers/pinctrl/pinctrl-mcp23s08_i2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/pinctrl-mcp23s08_i2c.c b/drivers/pinctrl/pinctrl-mcp23s08_i2c.c index 3dd1bd8e73eb..41ea2650a7e4 100644 --- a/drivers/pinctrl/pinctrl-mcp23s08_i2c.c +++ b/drivers/pinctrl/pinctrl-mcp23s08_i2c.c @@ -10,16 +10,16 @@ static int mcp230xx_probe(struct i2c_client *client) { - const struct i2c_device_id *id = i2c_client_get_device_id(client); struct device *dev = &client->dev; - unsigned int type = id->driver_data; struct mcp23s08 *mcp; + unsigned int type; int ret; mcp = devm_kzalloc(dev, sizeof(*mcp), GFP_KERNEL); if (!mcp) return -ENOMEM; + type = (uintptr_t)i2c_get_match_data(client); switch (type) { case MCP_TYPE_008: mcp->regmap = devm_regmap_init_i2c(client, &mcp23x08_regmap);