From patchwork Sun Sep 24 00:23:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fenghua Yu X-Patchwork-Id: 144039 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp487337vqu; Sat, 23 Sep 2023 21:16:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE4zr+OG9g74i7iyvLCDPBHk8WxU7qTHoSLkoK6gc8OCMK1VchL1T0fs+mh1PHcY4bTCrxQ X-Received: by 2002:a05:6808:df1:b0:3a9:9f9d:90df with SMTP id g49-20020a0568080df100b003a99f9d90dfmr3253632oic.23.1695529018006; Sat, 23 Sep 2023 21:16:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695529017; cv=none; d=google.com; s=arc-20160816; b=f9X28UHOlanG+QBnzHMlTvGI95W8FBvt65MHeuQ6uvBlxT5KkHpqOXrMZBGrc/3DOq L8pQwQOQOWgjlAZPjbwnI+fdfBloLpHPgJdtxZTC88OvQRcwNo0doxlTd7VxqXlB9X4B 1uTej37v1bmLWA2DtiC/0+uWTPCepQYtfvz+J6eOLFPvKg1iGWsranvXOWpqYAjlDbBD 5En+L3C1EwWroxa3zdQcEWd2t31YgQjaUKRGIQFwGodSVsayhHLj8TQhUsQuVKh9Ro5L 1+6AKg5vAikw6xDDo60Kd8ZDTLupAGmfGGqU8y3gHIjbawPMES0MaiR19QOK3NkAJt8u NTVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=fgQxZ/YWZ8Ce3zaZoRBFPh+3SdKz0bkTXYoSBmSn9Ks=; fh=ACKv3AuadEL63QrIfFMrPOJkQRAvxrVXth1Zol5I004=; b=iNukURbj5KHtjtnvHUZqxOuRUJGHpZcSEg3650+2lixeEyC01yheqUazHaLkQX8NaO 1VtlfQmo/SRtxduiSwqPux7gCqnTcoA15YpeZvqA68Zm1Tg1+R+LwDx/xCvk2CMl3egL 8v6ew8qOZgRfWhbJ9aTFneBCEn1PTevkg0OY/urVtjuHwH+LPwmDOuA9BfIKZo3RQnYv 8kXXyW1JdtkFGVpaI27ne2Jri6fU8L12lbY+t+mYKdMTHHjOAlhZcUh06sZL+u5GcfqJ rev+okwOWcoaL7BwGSR5CZIZPeOP/vZBi76BoTyzu6nA2+xvBbf0LKvHX5JBTFA1HQe/ Kf4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Wts1pFYF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id o19-20020a056a0015d300b0068e3efe866esi7786906pfu.146.2023.09.23.21.16.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Sep 2023 21:16:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Wts1pFYF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id CF621810835B; Sat, 23 Sep 2023 17:25:02 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229757AbjIXAYD (ORCPT + 30 others); Sat, 23 Sep 2023 20:24:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbjIXAYD (ORCPT ); Sat, 23 Sep 2023 20:24:03 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8219E136; Sat, 23 Sep 2023 17:23:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695515037; x=1727051037; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=e+IP2YTTfPQNfC51BuRVQ3FS282THHINwCwNMeWcoVM=; b=Wts1pFYFwC2R/EcT0g9M9QnLRBVrY8HOEuU7vb6Xr++0RH6PDDGiWjs7 bebC8YAJWTioUujvp1YgI42TD7pKsKkMwoZGPT93J+hJCmdsSDdbaWihC iIQ7CQfgTSQd5vSPpWn+FfTdne+qmPQ7zsF+w85PXJkLvvzj/f6QggUQj rKUe98SC96gCG/D2ux7g9pzRajlyJdp9YQJFnfIFPzal6fuSvfLl02nnb 6heh9ckcVMGesW/ZoOmr7Kq/4czJYLXjaiVawfYVouKhavBgvb0AcEjJX kWCHtGUfzfJY5sVoln/gxwRHsVKHmDwcSIhaQcn2ZOcyRFmh0bSYJcYg+ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10842"; a="378338267" X-IronPort-AV: E=Sophos;i="6.03,171,1694761200"; d="scan'208";a="378338267" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2023 17:23:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10842"; a="1078798374" X-IronPort-AV: E=Sophos;i="6.03,171,1694761200"; d="scan'208";a="1078798374" Received: from fyu1.sc.intel.com ([172.25.103.126]) by fmsmga005.fm.intel.com with ESMTP; 23 Sep 2023 17:23:56 -0700 From: Fenghua Yu To: "Vinod Koul" , dmaengine@vger.kernel.org, "linux-kernel" Cc: Dave Jiang , Sanjay Kumar , Fenghua Yu Subject: [PATCH] dmaengine: idxd: rate limit printk in misc interrupt thread Date: Sat, 23 Sep 2023 17:23:47 -0700 Message-Id: <20230924002347.1117757-1-fenghua.yu@intel.com> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Sat, 23 Sep 2023 17:25:02 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777891035900392102 X-GMAIL-MSGID: 1777891035900392102 From: Dave Jiang Add rate limit to the dev_warn() call in the misc interrupt thread. This limits dmesg getting spammed if a descriptor submitter is spamming bad descriptors with invalid completion records and resulting the errors being continuously reported by the misc interrupt handling thread. Reported-by: Sanjay Kumar Signed-off-by: Dave Jiang Reviewed-by: Fenghua Yu Acked-by: Lijun Pan --- This patch was sent to dmaengine mailing list before: https://lore.kernel.org/all/165125377735.312075.15715853788802098990.stgit@djiang5-desk3.ch.intel.com/ But it hasn't be merged into upstream yet. Add my Reviewed-by tag and re-send it. No code or commit message change. drivers/dma/idxd/irq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma/idxd/irq.c b/drivers/dma/idxd/irq.c index 041be6a4dec4..8e895a1e1881 100644 --- a/drivers/dma/idxd/irq.c +++ b/drivers/dma/idxd/irq.c @@ -430,8 +430,8 @@ irqreturn_t idxd_misc_thread(int vec, void *data) val |= IDXD_INTC_ERR; for (i = 0; i < 4; i++) - dev_warn(dev, "err[%d]: %#16.16llx\n", - i, idxd->sw_err.bits[i]); + dev_warn_ratelimited(dev, "err[%d]: %#16.16llx\n", + i, idxd->sw_err.bits[i]); err = true; }