From patchwork Sat Sep 23 09:41:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Li, Xin3" X-Patchwork-Id: 143929 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp235798vqu; Sat, 23 Sep 2023 08:19:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFluUIGyTII8JSIBEXNwJNr+FV+Y7fe0pJMow1lfepBcv+TBjef4BZOtAe/jo0hSbqNQBhR X-Received: by 2002:a17:902:f551:b0:1c0:ad3c:c723 with SMTP id h17-20020a170902f55100b001c0ad3cc723mr2442044plf.10.1695482394773; Sat, 23 Sep 2023 08:19:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695482394; cv=none; d=google.com; s=arc-20160816; b=AvTiau/PZBJu8JFjFcU0TcwYJTGMpi9rMnhwv6G5odBaDHjTd4DwAKbUffWE0rAWwX rHuQbU/f71kOTXQTJGtzygHhLAFJwJ1VSzUYropZGZCV4vdp+wHyryvJnEFDAoOhOgJw jIvHoYLhmj1aNPgTtNg3rIkJT+KbuIC21Jbo77+TsnUiULtsqJogLQEialh6XLgnBM6p yML9dD/q+uletuxUR0aiMI7GNVaRHeyDqvZjzTGHxW0TUz/m43Ak8kFY748/cfZJDY3/ UJkUOsP+Alq89WAcRKcRMs0VCmtLBFKGQClPx6ZnmbCptmRIuKefG041DSajdfRC36Ia aLTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=D2H/5ASQ5HFvLJe5JUNOg/dCSzOxa+wHfoN1Xho0nPs=; fh=Tb1p8S3iOxe/kX/WSNC3xEJzSVgGJ5DaxSrKb+pzH+4=; b=ndoiSlFJX827pdMPwQ1S3dLRsMTn4GCkJ3BGM62bkVa1wHieRiN/vIT9tE8Gl5hO67 WRFfIE0NSK5zP8TNFQ7Bw+Xn67A9u9l3UXoVxUcSrn1Z7RAbo4hSr+SK82c6javTSW6H 4NW/FU0PYhL9y0q1OfgOdQEPBlKvp6UVZEo/U7WEeOhjCCpV4rVCDW5sIuYmaVnrsoCJ zWBKKasQPUmRLHLqXrXASFubhE1/6o9kqBPI8UySLB/sw8hyxnqkA2iDy88AWQM6ls94 KM0dt3QBah7ETL9XwGfa4YdYOgnFKo+BipHUZij9zPe0hNfUyaXjzWmxgCqLkbN5Kg8T i7GQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=jEL8tLXP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id h6-20020a170902680600b001c434927d8dsi6196379plk.131.2023.09.23.08.19.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Sep 2023 08:19:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=jEL8tLXP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 746D185FED91; Sat, 23 Sep 2023 03:13:08 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231572AbjIWKMs (ORCPT + 29 others); Sat, 23 Sep 2023 06:12:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231461AbjIWKL5 (ORCPT ); Sat, 23 Sep 2023 06:11:57 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 215471B3; Sat, 23 Sep 2023 03:11:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695463907; x=1726999907; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=HaNFd9+f6o42v45n40NutGcoZldX+CMRVlEU3cDygtg=; b=jEL8tLXPUHJRQLVSuI6qyrNJxohs3fISpFjBgeeeXU+sYKhsCTXwz5Bb TYEglSxovRDRIzRh7MWvQzb0/rhgmS7r3ksmhPbad3DgPJLcmPLLW5LoH o4ypyAwSNx9KcUtfQQC9oHo6O3VAWszAQYSHisQvB9hzRAWqaozAOv9wh WY/a53Z6o6UPB12m8SDlnpy3+KscD0sT8dHWKNUTiX21r7+tQzjcauKGb pIrRRQot4oKGDblcaduq4fB1WzBGzt09FJMDjOHBjqYD2T3DKQdH+Dkad SBHRwNfqEVtBrSRGIRDCE2ZmZw2o6FuNBKljLWugRVMZ//MYnjwdrHH82 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10841"; a="447492314" X-IronPort-AV: E=Sophos;i="6.03,171,1694761200"; d="scan'208";a="447492314" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2023 03:11:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10841"; a="813388171" X-IronPort-AV: E=Sophos;i="6.03,171,1694761200"; d="scan'208";a="813388171" Received: from unknown (HELO fred..) ([172.25.112.68]) by fmsmga008.fm.intel.com with ESMTP; 23 Sep 2023 03:11:45 -0700 From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, luto@kernel.org, pbonzini@redhat.com, seanjc@google.com, peterz@infradead.org, jgross@suse.com, ravi.v.shankar@intel.com, mhiramat@kernel.org, andrew.cooper3@citrix.com, jiangshanlai@gmail.com, nik.borisov@suse.com Subject: [PATCH v11 20/37] x86/fred: Disallow the swapgs instruction when FRED is enabled Date: Sat, 23 Sep 2023 02:41:55 -0700 Message-Id: <20230923094212.26520-21-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230923094212.26520-1-xin3.li@intel.com> References: <20230923094212.26520-1-xin3.li@intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Sat, 23 Sep 2023 03:13:08 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777842147745416318 X-GMAIL-MSGID: 1777842147745416318 From: "H. Peter Anvin (Intel)" SWAPGS is no longer needed thus NOT allowed with FRED because FRED transitions ensure that an operating system can _always_ operate with its own GS base address: - For events that occur in ring 3, FRED event delivery swaps the GS base address with the IA32_KERNEL_GS_BASE MSR. - ERETU (the FRED transition that returns to ring 3) also swaps the GS base address with the IA32_KERNEL_GS_BASE MSR. And the operating system can still setup the GS segment for a user thread without the need of loading a user thread GS with: - Using LKGS, available with FRED, to modify other attributes of the GS segment without compromising its ability always to operate with its own GS base address. - Accessing the GS segment base address for a user thread as before using RDMSR or WRMSR on the IA32_KERNEL_GS_BASE MSR. Note, LKGS loads the GS base address into the IA32_KERNEL_GS_BASE MSR instead of the GS segment’s descriptor cache. As such, the operating system never changes its runtime GS base address. Signed-off-by: H. Peter Anvin (Intel) Tested-by: Shan Kang Signed-off-by: Xin Li --- Changes since v8: * Explain why writing directly to the IA32_KERNEL_GS_BASE MSR is doing the right thing (Thomas Gleixner). --- arch/x86/kernel/process_64.c | 27 +++++++++++++++++++++++++-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c index 0f78b58021bb..4f87f5987ae8 100644 --- a/arch/x86/kernel/process_64.c +++ b/arch/x86/kernel/process_64.c @@ -166,7 +166,29 @@ static noinstr unsigned long __rdgsbase_inactive(void) lockdep_assert_irqs_disabled(); - if (!cpu_feature_enabled(X86_FEATURE_XENPV)) { + /* + * SWAPGS is no longer needed thus NOT allowed with FRED because + * FRED transitions ensure that an operating system can _always_ + * operate with its own GS base address: + * - For events that occur in ring 3, FRED event delivery swaps + * the GS base address with the IA32_KERNEL_GS_BASE MSR. + * - ERETU (the FRED transition that returns to ring 3) also swaps + * the GS base address with the IA32_KERNEL_GS_BASE MSR. + * + * And the operating system can still setup the GS segment for a + * user thread without the need of loading a user thread GS with: + * - Using LKGS, available with FRED, to modify other attributes + * of the GS segment without compromising its ability always to + * operate with its own GS base address. + * - Accessing the GS segment base address for a user thread as + * before using RDMSR or WRMSR on the IA32_KERNEL_GS_BASE MSR. + * + * Note, LKGS loads the GS base address into the IA32_KERNEL_GS_BASE + * MSR instead of the GS segment’s descriptor cache. As such, the + * operating system never changes its runtime GS base address. + */ + if (!cpu_feature_enabled(X86_FEATURE_FRED) && + !cpu_feature_enabled(X86_FEATURE_XENPV)) { native_swapgs(); gsbase = rdgsbase(); native_swapgs(); @@ -191,7 +213,8 @@ static noinstr void __wrgsbase_inactive(unsigned long gsbase) { lockdep_assert_irqs_disabled(); - if (!cpu_feature_enabled(X86_FEATURE_XENPV)) { + if (!cpu_feature_enabled(X86_FEATURE_FRED) && + !cpu_feature_enabled(X86_FEATURE_XENPV)) { native_swapgs(); wrgsbase(gsbase); native_swapgs();