From patchwork Fri Sep 22 15:16:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Liu, Jingqi" X-Patchwork-Id: 143566 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp5772200vqi; Fri, 22 Sep 2023 11:03:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHNGjR+Zhq3e7QemBlj1bH1lhRd/cKR3szNbWO0YAZl3kCZWuEq9mr7k8g6B+k5pIDENdVO X-Received: by 2002:a05:6a21:601:b0:14c:ca56:69f7 with SMTP id ll1-20020a056a21060100b0014cca5669f7mr331203pzb.28.1695405835427; Fri, 22 Sep 2023 11:03:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695405835; cv=none; d=google.com; s=arc-20160816; b=t+n1jzoBpY0tilkhuQHk7T1AIDvMsg15A0sK23wXU4ZLkWAiX/mBK0hFkiW/Uh+rxB +zUz4rbebggAbb/H6YbfcKva+ekWHi0qBTwalj03Rf2yvVZe9I5A/0xK+SvZ2iml6oSP HwOVbtpjdeH55Esyq0X+6CwIvRmVOpZ+h1mlVPd4xbjMvg4KlKaZQVo4rjjkqrkfbRnU XLH6mlCilvEZvB2Y+UbL3A7ZoKygfN6ekkkFbTbf2+McM3Kmbuwk+6Z30/h5+jS2iS83 Ed07IITAR1kMOYHROkQaDaBXzfkueVVzKJI8wwDlKWqIHaM+OyKPmMdrEU+UkEO1wAvb Snwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=KGkY4V0xrQ9tbMwZo8FHmbPBFzUnQZcFTV81kv5+5YY=; fh=XFDRxS7z/mPiLWcvDFNXxtez86tw5VSUEAZ1VPulNcQ=; b=BbsBDh/j93HNJbJQkGMNW7LcEP/ve09FYVldr8AFFTqTPdOncg+OU2MaiFfehiUYca Ik7olRamcA8ZxwOViKFK0A8pJUZAbNaUbikP+I4G0/NduMH+BoPLEmvzebNhumxQ+R+T q6TMq45dCwOU+0c1TYfSrkk/kqm881d3CRZIHZrXCHZ1zOgKSXpL5SEIP7IAfLCvziCX dL4g+iygfeIj4dNxw9Q6Kizu2scag0DYqg9fY+DWM4ZlCkjnyWnFJA/p0pDQ4Zcummpu Kuo5V9qU9H+Qnm9to8MgplFOirQMIBqBz/Ue7S397tWh8DLHdP903Uvg6PWFyDgQ39PQ wAyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=n5ibx8kS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id k2-20020a632402000000b00578b258800bsi4314203pgk.38.2023.09.22.11.03.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Sep 2023 11:03:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=n5ibx8kS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id E5ED4875F482; Fri, 22 Sep 2023 08:19:52 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232934AbjIVPTt (ORCPT + 29 others); Fri, 22 Sep 2023 11:19:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232849AbjIVPTo (ORCPT ); Fri, 22 Sep 2023 11:19:44 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4291A100 for ; Fri, 22 Sep 2023 08:19:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695395978; x=1726931978; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=5JiJ3ki9XOt9pmx24LVzMFsOP2njaM1lOzq256mNqVQ=; b=n5ibx8kSlMi4mLC7U2QndFirF5TQvj2M8DeThhYUKXtxv1VHB5e3Ryvc 76Pf3u35xr+6nSSxsetOjR+CR51j7/Fnzexu5KVRd7h68Jk2B48yUUNBo O3U3fDm6BiYc25a98VvkCiEdHMyOheRlpitHGohDdC98MnKv7ZRgr+339 SzmW9TOy7/h4L2CcLhk9nUj35Lo2MXfKNSG20O/Gd2AaZVvIpJl9ylD+c reo67EiB8sXkpvUhloqVk337usj4I1Hkj86LVRHTAOvEmETF65KGhHfQj xCQ7Of5/WABMhTaXppQsklcx+XRpJKcCfRP9hGHFKbrxebsKioWRP2fuq w==; X-IronPort-AV: E=McAfee;i="6600,9927,10841"; a="360235292" X-IronPort-AV: E=Sophos;i="6.03,167,1694761200"; d="scan'208";a="360235292" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2023 08:19:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10841"; a="741133231" X-IronPort-AV: E=Sophos;i="6.03,167,1694761200"; d="scan'208";a="741133231" Received: from cascade.sh.intel.com ([10.239.48.35]) by orsmga007.jf.intel.com with ESMTP; 22 Sep 2023 08:19:34 -0700 From: Jingqi Liu To: iommu@lists.linux.dev, Lu Baolu , Tian Kevin , Joerg Roedel , Will Deacon , Robin Murphy Cc: linux-kernel@vger.kernel.org, Jingqi Liu Subject: [PATCH v2 3/3] iommu/vt-d: debugfs: Support dumping a specified page table Date: Fri, 22 Sep 2023 23:16:36 +0800 Message-Id: <20230922151636.77139-4-Jingqi.liu@intel.com> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20230922151636.77139-1-Jingqi.liu@intel.com> References: <20230922151636.77139-1-Jingqi.liu@intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Fri, 22 Sep 2023 08:19:52 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777761869483988868 X-GMAIL-MSGID: 1777761869483988868 The original debugfs only dumps all page tables without pasid. With pasid supported, the page table with pasid also needs to be dumped. This patch supports dumping a specified page table in legacy mode or scalable mode with or without a specified pasid. For legacy mode, according to bus number and DEVFN, traverse the root table and context table to get the pointer of page table in the context table entry, then dump the specified page table. For scalable mode, according to bus number, DEVFN and pasid, traverse the root table, context table, pasid directory and pasid table to get the pointer of page table in the pasid table entry, then dump the specified page table.. Examples are as follows: 1) Dump the page table of device "0000:00:1f.0" that only supports legacy mode. $ sudo cat /sys/kernel/debug/iommu/intel/0000:00:1f.0/0/domain_translation_struct 2) Dump the page table of device "0000:00:0a.0" with PASID "1" that supports scalable mode. $ sudo cat /sys/kernel/debug/iommu/intel/0000:00:0a.0/1/domain_translation_struct Suggested-by: Kevin Tian Signed-off-by: Jingqi Liu --- drivers/iommu/intel/debugfs.c | 163 +++++++++++++++++++++++++--------- 1 file changed, 121 insertions(+), 42 deletions(-) diff --git a/drivers/iommu/intel/debugfs.c b/drivers/iommu/intel/debugfs.c index 9128febba3c6..51f0e022c06e 100644 --- a/drivers/iommu/intel/debugfs.c +++ b/drivers/iommu/intel/debugfs.c @@ -352,58 +352,137 @@ static void pgtable_walk_level(struct seq_file *m, struct dma_pte *pde, } } -static int __show_device_domain_translation(struct device *dev, void *data) +static int domain_translation_struct_show(struct seq_file *m, void *unused) { - struct dmar_domain *domain; - struct seq_file *m = data; - u64 path[6] = { 0 }; + struct device_domain_info *info; + struct show_domain_info *sinfo; + bool scalable, found = false; + struct dmar_drhd_unit *drhd; + struct intel_iommu *iommu; + u16 devfn, bus, seg; - domain = to_dmar_domain(iommu_get_domain_for_dev(dev)); - if (!domain) - return 0; + if (!m || !m->private) { + seq_puts(m, "Invalid device or pasid!\n"); + return -EINVAL; + } - seq_printf(m, "Device %s @0x%llx\n", dev_name(dev), - (u64)virt_to_phys(domain->pgd)); - seq_puts(m, "IOVA_PFN\t\tPML5E\t\t\tPML4E\t\t\tPDPE\t\t\tPDE\t\t\tPTE\n"); + sinfo = (struct show_domain_info*)m->private; + if (!sinfo->dev || + !dev_iommu_priv_get(sinfo->dev) || + (sinfo->pasid == IOMMU_PASID_INVALID)) { + seq_puts(m, "Please specify device or pasid!\n"); + return -ENODEV; + } - pgtable_walk_level(m, domain->pgd, domain->agaw + 2, 0, path); - seq_putc(m, '\n'); + info = dev_iommu_priv_get(sinfo->dev); + bus = info->bus; + devfn = info->devfn; + seg = info->segment; - /* Don't iterate */ - return 1; -} + rcu_read_lock(); + for_each_active_iommu(iommu, drhd) { + struct context_entry *context; + u64 pgd, path[6] = { 0 }; + u32 sts, agaw; -static int show_device_domain_translation(struct device *dev, void *data) -{ - struct iommu_group *group; + if (seg != iommu->segment) + continue; - device_lock(dev); - group = iommu_group_get(dev); - device_unlock(dev); - if (!group) - return 0; + sts = dmar_readl(iommu->reg + DMAR_GSTS_REG); + if (!(sts & DMA_GSTS_TES)) { + seq_printf(m, "DMA Remapping is not enabled on %s\n", + iommu->name); + continue; + } + if (dmar_readq(iommu->reg + DMAR_RTADDR_REG) & DMA_RTADDR_SMT) + scalable = true; + else + scalable = false; - /* - * The group->mutex is held across the callback, which will - * block calls to iommu_attach/detach_group/device. Hence, - * the domain of the device will not change during traversal. - * - * All devices in an iommu group share a single domain, hence - * we only dump the domain of the first device. Even though, - * this code still possibly races with the iommu_unmap() - * interface. This could be solved by RCU-freeing the page - * table pages in the iommu_unmap() path. - */ - iommu_group_for_each_dev(group, data, __show_device_domain_translation); - iommu_group_put(group); + /* + * The iommu->lock is held across the callback, which will + * block calls to domain_attach/domain_detach. Hence, + * the domain of the device will not change during traversal. + * + * Traversing page table possibly races with the iommu_unmap() + * interface. This could be solved by RCU-freeing the page + * table pages in the iommu_unmap() path. + */ + spin_lock(&iommu->lock); - return 0; -} + context = iommu_context_addr(iommu, bus, devfn, 0); + if (!context || !context_present(context)) + goto iommu_unlock; -static int domain_translation_struct_show(struct seq_file *m, void *unused) -{ - return bus_for_each_dev(&pci_bus_type, NULL, m, - show_device_domain_translation); + if (scalable) { /* scalable mode */ + struct pasid_dir_entry *dir_tbl, *dir_entry; + struct pasid_entry *pasid_tbl, *pasid_tbl_entry; + u16 pasid_dir_size, dir_idx, tbl_idx, pgtt; + u64 pasid_dir_ptr; + + pasid_dir_ptr = context->lo & VTD_PAGE_MASK; + pasid_dir_size = get_pasid_dir_size(context); + + /* Dump specified device domain mappings with PASID. */ + dir_idx = sinfo->pasid >> PASID_PDE_SHIFT; + tbl_idx = sinfo->pasid & PASID_PTE_MASK; + + dir_tbl = phys_to_virt(pasid_dir_ptr); + dir_entry = &dir_tbl[dir_idx]; + + pasid_tbl = get_pasid_table_from_pde(dir_entry); + if (!pasid_tbl) + goto iommu_unlock; + + pasid_tbl_entry = &pasid_tbl[tbl_idx]; + if (!pasid_pte_is_present(pasid_tbl_entry)) + goto iommu_unlock; + + /* + * According to PASID Granular Translation Type(PGTT), + * get the page table pointer. + */ + pgtt = (u16)(pasid_tbl_entry->val[0] & GENMASK_ULL(8, 6)) >> 6; + agaw = (u8)(pasid_tbl_entry->val[0] & GENMASK_ULL(4, 2)) >> 2; + + switch (pgtt) { + case PASID_ENTRY_PGTT_FL_ONLY: + pgd = pasid_tbl_entry->val[2]; + break; + case PASID_ENTRY_PGTT_SL_ONLY: + case PASID_ENTRY_PGTT_NESTED: + pgd = pasid_tbl_entry->val[0]; + break; + default: + goto iommu_unlock; + } + pgd &= VTD_PAGE_MASK; + } else { /* legacy mode */ + pgd = context->lo & VTD_PAGE_MASK; + agaw = context->hi & 7; + } + + seq_printf(m, "Device %04x:%02x:%02x.%x ", + iommu->segment, bus, PCI_SLOT(devfn), PCI_FUNC(devfn)); + + if (scalable) + seq_printf(m, "with pasid %x @0x%llx\n", sinfo->pasid, pgd); + else + seq_printf(m, "@0x%llx\n", pgd); + + seq_printf(m, "%-17s\t%-18s\t%-18s\t%-18s\t%-18s\t%-s\n", + "IOVA_PFN", "PML5E", "PML4E", "PDPE", "PDE", "PTE"); + pgtable_walk_level(m, phys_to_virt(pgd), agaw + 2, 0, path); + + found = true; +iommu_unlock: + spin_unlock(&iommu->lock); + if (found) + break; + } + rcu_read_unlock(); + + return 0; } DEFINE_SHOW_ATTRIBUTE(domain_translation_struct);