From patchwork Thu Sep 21 14:43:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 143026 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp5225553vqi; Thu, 21 Sep 2023 17:15:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHue1QfvjF9+oFI47cOsZxjvwlOWCCRL10d3xH6GBu9ThW7/2JFbVhVhykyaTChzov3W9jY X-Received: by 2002:a05:6a21:1a0:b0:14c:d494:77d1 with SMTP id le32-20020a056a2101a000b0014cd49477d1mr8486686pzb.10.1695341754377; Thu, 21 Sep 2023 17:15:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695341754; cv=none; d=google.com; s=arc-20160816; b=A+WJxdXRDIwWPzyIEzPcjliXyUbObTH0L1XERsfEif1jstsiHywR6/CRmhjTz6iA3d 7b9WQQjV4gcG9MRZGmCR8vWUx0Z1Up1Oi8ZUCO1RQtzfqGHQQOn3hNM0JLEQR4A4nt72 c59CpL12+28jRdGbrpEH7rEv/D5ltQ/qA1xyBuHNdt34UUAuFJaLYlwzpMVoyz9qGgnz yZRCXEi3SNWB/z2pErZaiixRp+i9lbnk9CqIG3U5ZbhqVDxfxfb2POSOQIQvcqVZg7O5 UfKpTn18p96EX3P6jswd47oxOa1z3+6n1zqTNBh7OuLtHdfr97D09Q/UDPXLtUxyaMKw tgDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=gabiCx8aQ+iMVEJft2DL0LHbd3RWq71VIbUUi+w3JfM=; fh=rOC7q8UJisRayejF6PsoKdRfRTtXVZOwgDCXOG0B/ws=; b=vsOOBChIQec3A3QD+8/yxhQTIU1N5zJKB868nNVb3klWlWmYf4QSehgmDh07FjPP6O JruqyZD38IjRwfWGT5x7Pe6T5VmClPmfnCWtDPhKNCUzKmyo2cE2sJPP0qibXumLMTqJ HjJQYfVY9nWoFzkLWeeGD5FDrvmYXfl7r3tLTQCkWrGmHHHXbMWgU2j8k5jscETdigIX SvYG3IjbsPRKIb7OVvwtLCSLewWJgCu0dyzgabpnd4PVvcjSzBKWPAzh4Xuv7EOScC6f HrmafVif9nNJVlQ8COeVYauRsb3pIjzvcWBXgzA0zJl6JkwOMI9PJZmKmNboR8pYhLJ8 od0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b=xGCIO8Gh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id e20-20020a170902f1d400b001c5bfe458a1si2397497plc.356.2023.09.21.17.15.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 17:15:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b=xGCIO8Gh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 14DBE82E3C75; Thu, 21 Sep 2023 13:02:26 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231442AbjIUUCV (ORCPT + 28 others); Thu, 21 Sep 2023 16:02:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231298AbjIUUB5 (ORCPT ); Thu, 21 Sep 2023 16:01:57 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D91F5FF9 for ; Thu, 21 Sep 2023 10:26:33 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-99bf3f59905so150335966b.3 for ; Thu, 21 Sep 2023 10:26:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1695317188; x=1695921988; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gabiCx8aQ+iMVEJft2DL0LHbd3RWq71VIbUUi+w3JfM=; b=xGCIO8GhGgIu/zVimnGMfMtEq8vXj6YV7MglFnLBjjEy+vrm7BbFLBNjze1YKeDKf+ KlD+eoNmLbpjQF/va/d3Wp594g3RAECBD2CIZa8eTLxHCD1hwRZd8iXF8JS+gtzqTis9 O38GMxhr9+xlZQ6ZY2bPa57WSAUdXx4SWVwk9ryaJtgtfk3m66KxnCQZwV8Pve97rSDc py3GGM95HQ5lxcyVJ9F1VVI9l6s/gY735I5ZdgAnZBERZzsL2JdMuy7kKKR+09Bw1Ohn wHrLKoIToQ4jXEW318iH5Kh49egtk1b76piDtoWkntSNjVxZJinjBfDPtO6S8PNnkD7w mXIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695317188; x=1695921988; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gabiCx8aQ+iMVEJft2DL0LHbd3RWq71VIbUUi+w3JfM=; b=uTlkcmhjJQCXpmcahfAWopdTp1uvWvVVQTS1obXp4bmW1wFNRlPUG6BGQVjuEZNVKV Uq/YPvl77QWZt6jHMcihBKB5Q5yag/fE+0R0F+Nz4t+iwrtsp0aZ17L08/8kCWS8gZke pdJBLzSSCbgJB+cssi6AYjn8aMnkHncu0WMtdhzT00wMxMX8yN740LBqIm1gDoUiUC4A UoWtz8kn+jsHFPvp87zdbbZwP3NnJn8WLEBx5MZSdOCpR69r4d3/yELdh3BZzhZUBMbE Ky9ejbmv5ZdZoPN8ScicUF7dPHzY8JLjEgfi5JM2IFRgV/v18+9O37EAE4qN0C9sdaTt VCdw== X-Gm-Message-State: AOJu0Yx8LSJbPIUNK1gyTbO3LnObsQffSssAGuFoKa4UhONE8rGBpiHH AqML9B94hleA48TTK5CQZ4WQbLUWz8LO8CArp6O7xl1a X-Received: by 2002:a05:600c:ad4:b0:3f9:b430:199b with SMTP id c20-20020a05600c0ad400b003f9b430199bmr5382331wmr.15.1695307457930; Thu, 21 Sep 2023 07:44:17 -0700 (PDT) Received: from localhost.localdomain (abordeaux-655-1-129-86.w90-5.abo.wanadoo.fr. [90.5.10.86]) by smtp.gmail.com with ESMTPSA id s17-20020a1cf211000000b003fe2a40d287sm2125515wmc.1.2023.09.21.07.44.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 07:44:17 -0700 (PDT) From: David Lechner To: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-staging@lists.linux.dev Cc: linux-kernel@vger.kernel.org, Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Hennerich , =?utf-8?q?Nuno_S=C3=A1?= , Axel Haslam , Philip Molloy , David Lechner Subject: [PATCH v2 06/19] staging: iio: resolver: ad2s1210: always use 16-bit value for raw read Date: Thu, 21 Sep 2023 09:43:47 -0500 Message-Id: <20230921144400.62380-7-dlechner@baylibre.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230921144400.62380-1-dlechner@baylibre.com> References: <20230921144400.62380-1-dlechner@baylibre.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 21 Sep 2023 13:02:26 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777694675393664732 X-GMAIL-MSGID: 1777694675393664732 This removes the special handling for resolutions lower than 16 bits. This will allow us to use a fixed scale independent of the resolution. Also, for the record, according to the datasheet, the logic for the special handling based on hysteresis that was removed was incorrect. Signed-off-by: David Lechner --- drivers/staging/iio/resolver/ad2s1210.c | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c index 9c7f76114360..985b8fecd65a 100644 --- a/drivers/staging/iio/resolver/ad2s1210.c +++ b/drivers/staging/iio/resolver/ad2s1210.c @@ -465,10 +465,7 @@ static int ad2s1210_read_raw(struct iio_dev *indio_dev, long m) { struct ad2s1210_state *st = iio_priv(indio_dev); - u16 negative; int ret = 0; - u16 pos; - s16 vel; mutex_lock(&st->lock); gpiod_set_value(st->gpios[AD2S1210_SAMPLE], 0); @@ -494,20 +491,11 @@ static int ad2s1210_read_raw(struct iio_dev *indio_dev, switch (chan->type) { case IIO_ANGL: - pos = be16_to_cpup((__be16 *)st->rx); - if (st->hysteresis) - pos >>= 16 - st->resolution; - *val = pos; + *val = be16_to_cpup((__be16 *)st->rx); ret = IIO_VAL_INT; break; case IIO_ANGL_VEL: - vel = be16_to_cpup((__be16 *)st->rx); - vel >>= 16 - st->resolution; - if (vel & 0x8000) { - negative = (0xffff >> st->resolution) << st->resolution; - vel |= negative; - } - *val = vel; + *val = (s16)be16_to_cpup((__be16 *)st->rx); ret = IIO_VAL_INT; break; default: