From patchwork Thu Sep 21 14:43:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 142869 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp5099362vqi; Thu, 21 Sep 2023 12:53:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEn+VgnWSR+RhkYOHArCxT6itMAKghzjmZco+LSLGgAPzMkSmfAh1KRIrItkG8QkuxLpGOW X-Received: by 2002:a05:6a20:3d89:b0:158:7fdf:66df with SMTP id s9-20020a056a203d8900b001587fdf66dfmr7699169pzi.18.1695326010332; Thu, 21 Sep 2023 12:53:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695326010; cv=none; d=google.com; s=arc-20160816; b=jXw/AMyFxamHkrx+JOpeVkL5EsCpQL0DN9IPH9K8Gs8TIfZQ3LnCwSketb9xauINEc FklweEGJQTumrn0CDtWjgJldeXZfBSSw4zYpj9PASshy+ClyJAaRURc+D17rRIW8tS3T XNXUTgLnDrtPEuJvNuDbjfWjR2eBu4MeDSS1OG8RsAQVgUPo6ycV7JJc4RnrXA4EXtO4 tGRrR7KqtaB9I+BPmXo2IezKGoYbDbbfsLrmEHYK3WTCK4VjJKfDTUcdl3bxp5YxU+W1 RP3uctg2BuE7K41G2jZ55J9gIWC7uvA791IQJS0nxnJxJ38UzayO0ORQRejThuzrmjuZ 2sww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=AZybWEnlutF3BnUcq+xH7uoi35RICanW/277eMaA8Sc=; fh=rOC7q8UJisRayejF6PsoKdRfRTtXVZOwgDCXOG0B/ws=; b=TOY5VSYMCqQk5Ab4tVPuQfYwI4wdmyQoLXlbL+VwlNves68GMvWcFlY0oiphkoKOhV oYM16HoTqCjcwxCDWgws9op4C9Q2Jugs8tAlr6iIt8tW59CF5+SyAIrMgFJkqlRaKPbp Ps0THiPXG9hAFrrf5s4ozbf2Xkmrr8d39d6NPBv7CbDH9voPG+3xS0LMUI1leQ8w1GGf zPNbpRB466Szv7VB56DKAxZNZCniC7lg3atonGKbg1vTvrPors0s5myuhat/oKuuvJ0y wPmCi3iUWgEAv/me9dZSGCQAxJzH/XNXdVxQ09SngB9wMTpCG9aVt7kXOcrHxPleNvzb BVbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b=Wa+0TJfS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id cg19-20020a056a00291300b0068fc080f79dsi2122020pfb.122.2023.09.21.12.53.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 12:53:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b=Wa+0TJfS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id CC86981D2B76; Thu, 21 Sep 2023 10:29:35 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230345AbjIUR2z (ORCPT + 29 others); Thu, 21 Sep 2023 13:28:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229499AbjIUR2C (ORCPT ); Thu, 21 Sep 2023 13:28:02 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F45A15A1A for ; Thu, 21 Sep 2023 10:11:40 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-502e7d66c1eso2090880e87.1 for ; Thu, 21 Sep 2023 10:11:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1695316297; x=1695921097; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AZybWEnlutF3BnUcq+xH7uoi35RICanW/277eMaA8Sc=; b=Wa+0TJfSg/UDK+AC2TyH9GbNsYbpjZ9R1OPFodTI8y/QyRWWKKflfq3FAIij7Fk39H HlD3VIUBo49Q01QPS7P4nCvvaX0NaQcIvUqfXg6foGCSs8fOnvx8Me8ErmZaf/B3QEzH VlCzRxDgXHwdRhAWapJN76SssJhnTCpnx+DyEe9zGI4qI+E8VxXMx+arIIAKwfMyvyKo pMNn59bl63jroONgue0/wSazS2GCfJ65+hRpI3Z7AlgE+6SiYokBM5+IbdQnyzhCP/cz F78drs9bMNDlv6VHG9+0rlH4ifkdt1KBWXSybDtMrTk1y3caLuDEMjL+a6jKagNQEbfl evhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695316297; x=1695921097; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AZybWEnlutF3BnUcq+xH7uoi35RICanW/277eMaA8Sc=; b=oJs47N9d2XnKKjb8vtdf2UUqZ22TQShEzsNH4napJPY2fBhkqtuXgX89EBSs8OV357 xwSPtIA0SNPV7Pwe+Z+rtk57iGVsxo3qX40bMeK+gipF6U1G7cuTo909ea9INC3+GCQn 71W3Wkl6HuvvZZmk4fHUTQWh4+wSG3iGW7ZtdT7QK1sKzxk/xIEdP0pl3i2bHRXVbkkh l3SGtmJTDLid4vkGQNiZR5UFuo6MvorPQ0sSeVrBgkcc6kKScxuc9/pdgX8l4yaSpoEV IpsPjc/IrD6S75Pn2vgn2JxT/ur0plEySR4QIfqbzutCJAsuhUO+hTwtmMmAL389IaLG DyPg== X-Gm-Message-State: AOJu0Yw6CSsJ+XIf/iEcfWLIp4qd05qVtiFD+0oNTZWoOB3aSkpOAHes C/g5WVj5e6ofBK+GCsq4wQF3/pxLO6e8gL0e2KhhVDNs X-Received: by 2002:a05:600c:2312:b0:3fe:d71a:d84e with SMTP id 18-20020a05600c231200b003fed71ad84emr5046284wmo.1.1695307464020; Thu, 21 Sep 2023 07:44:24 -0700 (PDT) Received: from localhost.localdomain (abordeaux-655-1-129-86.w90-5.abo.wanadoo.fr. [90.5.10.86]) by smtp.gmail.com with ESMTPSA id s17-20020a1cf211000000b003fe2a40d287sm2125515wmc.1.2023.09.21.07.44.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 07:44:23 -0700 (PDT) From: David Lechner To: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-staging@lists.linux.dev Cc: linux-kernel@vger.kernel.org, Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Hennerich , =?utf-8?q?Nuno_S=C3=A1?= , Axel Haslam , Philip Molloy , David Lechner Subject: [PATCH v2 13/19] staging: iio: resolver: ad2s1210: implement hysteresis as channel attr Date: Thu, 21 Sep 2023 09:43:54 -0500 Message-Id: <20230921144400.62380-14-dlechner@baylibre.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230921144400.62380-1-dlechner@baylibre.com> References: <20230921144400.62380-1-dlechner@baylibre.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 21 Sep 2023 10:29:35 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777678166502488610 X-GMAIL-MSGID: 1777678166502488610 The AD2S1210 resolver has a hysteresis feature that can be used to prevent flicker in the LSB of the position register. This can be either enabled or disabled. Disabling hysteresis is useful for increasing precision by oversampling. Signed-off-by: David Lechner --- drivers/staging/iio/resolver/ad2s1210.c | 88 ++++++++++++++++++++++++- 1 file changed, 85 insertions(+), 3 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c index 7a1069d948eb..fe413759deb9 100644 --- a/drivers/staging/iio/resolver/ad2s1210.c +++ b/drivers/staging/iio/resolver/ad2s1210.c @@ -80,7 +80,6 @@ struct ad2s1210_state { /** The external oscillator frequency in Hz. */ unsigned long fclkin; unsigned int fexcit; - bool hysteresis; u8 resolution; u8 rx[2] __aligned(IIO_DMA_MINALIGN); u8 tx[2]; @@ -456,6 +455,27 @@ static int ad2s1210_read_raw(struct iio_dev *indio_dev, } break; + case IIO_CHAN_INFO_HYSTERESIS: + switch (chan->type) { + case IIO_ANGL: + mutex_lock(&st->lock); + ret = regmap_test_bits(st->regmap, AD2S1210_REG_CONTROL, + AD2S1210_ENABLE_HYSTERESIS); + if (ret < 0) + goto error_info_hysteresis; + + *val = !!ret; + ret = IIO_VAL_INT; + +error_info_hysteresis: + mutex_unlock(&st->lock); + break; + default: + ret = -EINVAL; + break; + } + break; + default: ret = -EINVAL; break; @@ -464,6 +484,64 @@ static int ad2s1210_read_raw(struct iio_dev *indio_dev, return ret; } +static int ad2s1210_read_avail(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, + const int **vals, int *type, + int *length, long mask) +{ + static const int available[] = { 0, 1 }; + int ret = -EINVAL; + + switch (mask) { + case IIO_CHAN_INFO_HYSTERESIS: + switch (chan->type) { + case IIO_ANGL: + *vals = available; + *type = IIO_VAL_INT; + *length = ARRAY_SIZE(available); + ret = IIO_AVAIL_LIST; + break; + default: + break; + } + default: + break; + } + + return ret; +} + +static int ad2s1210_write_raw(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, + int val, int val2, long mask) +{ + struct ad2s1210_state *st = iio_priv(indio_dev); + int ret = -EINVAL; + + switch (mask) { + case IIO_CHAN_INFO_HYSTERESIS: + switch (chan->type) { + case IIO_ANGL: + mutex_lock(&st->lock); + ret = regmap_update_bits(st->regmap, AD2S1210_REG_CONTROL, + AD2S1210_ENABLE_HYSTERESIS, + val ? AD2S1210_ENABLE_HYSTERESIS + : 0); + mutex_unlock(&st->lock); + break; + + default: + break; + } + break; + + default: + break; + } + + return ret; +} + static IIO_DEVICE_ATTR(fexcit, 0644, ad2s1210_show_fexcit, ad2s1210_store_fexcit, 0); static IIO_DEVICE_ATTR(bits, 0644, @@ -499,7 +577,10 @@ static const struct iio_chan_spec ad2s1210_channels[] = { .indexed = 1, .channel = 0, .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | - BIT(IIO_CHAN_INFO_SCALE), + BIT(IIO_CHAN_INFO_SCALE) | + BIT(IIO_CHAN_INFO_HYSTERESIS), + .info_mask_separate_available = + BIT(IIO_CHAN_INFO_HYSTERESIS), }, { .type = IIO_ANGL_VEL, .indexed = 1, @@ -573,6 +654,8 @@ static int ad2s1210_debugfs_reg_access(struct iio_dev *indio_dev, static const struct iio_info ad2s1210_info = { .read_raw = ad2s1210_read_raw, + .read_avail = ad2s1210_read_avail, + .write_raw = ad2s1210_write_raw, .attrs = &ad2s1210_attribute_group, .debugfs_reg_access = &ad2s1210_debugfs_reg_access, }; @@ -689,7 +772,6 @@ static int ad2s1210_probe(struct spi_device *spi) mutex_init(&st->lock); st->sdev = spi; - st->hysteresis = true; st->resolution = 12; st->fexcit = AD2S1210_DEF_EXCIT;