From patchwork Thu Sep 21 14:43:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 142853 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp5083289vqi; Thu, 21 Sep 2023 12:21:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHvSOHJdGWUa8AknfAvE2UQt6frRHFISnmK/hKVuxjPOjRuHbm0lUW63ZrFAdkNeR7lvtGv X-Received: by 2002:a05:6a21:6d90:b0:14d:e615:277c with SMTP id wl16-20020a056a216d9000b0014de615277cmr612647pzb.11.1695324102652; Thu, 21 Sep 2023 12:21:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695324102; cv=none; d=google.com; s=arc-20160816; b=rS4PFzWROImAsq3y/7wUuu+kwAf5dTIlSrX/vpuB1gR2DKcA11aoR1xPHPZOu269jY lXoOKDYt1SC+FmjuYtVhs8NcK9FYwCZPucdg8GIni/qH/5NNF9QlwaD9YC9jdgwUYgnZ fMBZrDNnd6mEVxZlJn26WpH2jmGOCsZmKe+EDbf/ecpah3mVAzuHnKYifBcsB3NhZ9+9 SP7uyYLCkX0Z5SOorIvNNZ5SgLvOI4jJdn8Q2UqS5f45hveIMsz/5X5VMZv/Wgs5h2QY KuDiQpFY54R+4s+8cUH6TneK0A/8D9RWynSrrP6HdvFdp83TyyaoW+gg3MFg+MUTsnEi Qb5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=T9WVKxDU/WCTxqQ52/M5ua8wasfSRRcZpI1eeblkSC8=; fh=rOC7q8UJisRayejF6PsoKdRfRTtXVZOwgDCXOG0B/ws=; b=rmAIfY/0/QuEPNGTjmhWpheX9Rf16rfStn3aBjIrKz5f8sqU1m5Xr1waVTFSAjzTYS /ZCV67UshY1vxJxesRBOUQVbPm6K2935xEZ/WkMXt+e1WQX2qvJ+ip2tB1CW3G3MdgL8 yMQ+K28qZRYZodzS4c1KNPzkPzDokTmhl8f+Usm2hfOrBo6iRdZte9LNbnqpKoxMMQ61 BXtXsxiuEDDpMnGKXiugc+UUxSlX3D0kOufTiloHuYGmEbUizN8GCje1sa3m1fazh3L5 El8EMzhzTkHdZrwb5OV2OBxDmnmkpGD+HdasAFs3/xur/IYw9fMnfZ5fHlmMDW2YXbLS Q23w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b=YHRnfXMh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id a2-20020a056a000c8200b0064f78c32b89si2198369pfv.95.2023.09.21.12.21.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 12:21:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b=YHRnfXMh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id D646E812E00F; Thu, 21 Sep 2023 12:02:28 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231150AbjIUTBp (ORCPT + 28 others); Thu, 21 Sep 2023 15:01:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230372AbjIUTBS (ORCPT ); Thu, 21 Sep 2023 15:01:18 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 298108A83C for ; Thu, 21 Sep 2023 10:41:00 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-32155a45957so1268433f8f.0 for ; Thu, 21 Sep 2023 10:41:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1695318058; x=1695922858; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=T9WVKxDU/WCTxqQ52/M5ua8wasfSRRcZpI1eeblkSC8=; b=YHRnfXMhVBk2dvvmkqmAOc1C4QYUs0kKnOkjW+E8mLcmyFl36HQjoh9GgkL3P8vUzO HWZSgoyKC0Ufvoia0cmNKgulSRNWvSNRnJ8UhKAiUpSJOS1lnYtesZ+VH0+XQLE5bQ2u OHIukkHUmrgx3j0j0XrAScdodoKsKKg0uu7qPtL6Tn+M4z30KGTy4lBC+ZeGxY8H5zJQ VL4Ye11HaycTBGVmrzTNbA5B6cN1mR41dci9VNugZxqlJL9+xFYAUgZP3EVR82f9dEuw xxnnyLd94qYjlLIrcOiPnka8LDuljtmaWlmOp7W3DcJsyQYlsYSPtXJpcLYnqcSbPVgu FMtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695318058; x=1695922858; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T9WVKxDU/WCTxqQ52/M5ua8wasfSRRcZpI1eeblkSC8=; b=sneitSQV8TVZbvGUIUQxV+xDXfIGNHoAYXDiSqzXWNNLH1bbj3QtaUcGz7w8yONiJk fvuKGV9KIRMCEUk4bWkultP13318jrDCNJy22cG6jlwoGQ5ur20+BGu74VCPFVaBhVVW TVD6Y2rl1dlnbyHb/7Xufcsi0OKivQWObMYHARd9OkdXFkgenSX1ZolCvt3Pw9Ctu3Ji AGtPwplIcRNTTTZHkrWmIBNpk0bHQZNOppu3qNtGM1QPrudGvrmglwhk08/qqHXWU84y oMptoEqI2A1d6PMxSbOzXWo4pu1aWCYAUaJOPTZPbrMeCJjaNv6PSzj5Y3YD3UV+WCHA MTeg== X-Gm-Message-State: AOJu0YzSFANDVhcxefla/a9AUeak8zPwNsyvYMk/NESOFsDgQxDqqYs6 Mv94ZxTJGYRWjnbibiWQJsfI+aNQUg3aqmnd+jKuo0HS X-Received: by 2002:a5d:500d:0:b0:317:58e4:e941 with SMTP id e13-20020a5d500d000000b0031758e4e941mr5405435wrt.33.1695307462223; Thu, 21 Sep 2023 07:44:22 -0700 (PDT) Received: from localhost.localdomain (abordeaux-655-1-129-86.w90-5.abo.wanadoo.fr. [90.5.10.86]) by smtp.gmail.com with ESMTPSA id s17-20020a1cf211000000b003fe2a40d287sm2125515wmc.1.2023.09.21.07.44.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 07:44:21 -0700 (PDT) From: David Lechner To: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-staging@lists.linux.dev Cc: linux-kernel@vger.kernel.org, Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Hennerich , =?utf-8?q?Nuno_S=C3=A1?= , Axel Haslam , Philip Molloy , David Lechner Subject: [PATCH v2 11/19] staging: iio: resolver: ad2s1210: remove config attribute Date: Thu, 21 Sep 2023 09:43:52 -0500 Message-Id: <20230921144400.62380-12-dlechner@baylibre.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230921144400.62380-1-dlechner@baylibre.com> References: <20230921144400.62380-1-dlechner@baylibre.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 21 Sep 2023 12:02:33 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777676165929516098 X-GMAIL-MSGID: 1777676165929516098 This removes the config register sysfs attribute. Writing to the config register directly can be dangerous and userspace should not need to have to know the register layout. This register can still be accessed though debugfs if needed. We can add new attributes to set specific flags in the config register in the future if needed (e.g. `enable_hysterisis` and `phase_lock_range`). Signed-off-by: David Lechner --- drivers/staging/iio/resolver/ad2s1210.c | 47 ------------------------- 1 file changed, 47 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c index b99928394e3f..223cc4702188 100644 --- a/drivers/staging/iio/resolver/ad2s1210.c +++ b/drivers/staging/iio/resolver/ad2s1210.c @@ -269,50 +269,6 @@ static ssize_t ad2s1210_store_fexcit(struct device *dev, return ret < 0 ? ret : len; } -static ssize_t ad2s1210_show_control(struct device *dev, - struct device_attribute *attr, - char *buf) -{ - struct ad2s1210_state *st = iio_priv(dev_to_iio_dev(dev)); - unsigned int value; - int ret; - - mutex_lock(&st->lock); - ret = regmap_read(st->regmap, AD2S1210_REG_CONTROL, &value); - mutex_unlock(&st->lock); - return ret < 0 ? ret : sprintf(buf, "0x%x\n", value); -} - -static ssize_t ad2s1210_store_control(struct device *dev, - struct device_attribute *attr, - const char *buf, size_t len) -{ - struct ad2s1210_state *st = iio_priv(dev_to_iio_dev(dev)); - unsigned char udata; - unsigned char data; - int ret; - - ret = kstrtou8(buf, 16, &udata); - if (ret) - return -EINVAL; - - mutex_lock(&st->lock); - data = udata & ~AD2S1210_ADDRESS_DATA; - ret = regmap_write(st->regmap, AD2S1210_REG_CONTROL, data); - if (ret < 0) - goto error_ret; - - st->resolution = - ad2s1210_resolution_value[data & AD2S1210_SET_RES]; - ad2s1210_set_resolution_pin(st); - ret = len; - st->hysteresis = !!(data & AD2S1210_ENABLE_HYSTERESIS); - -error_ret: - mutex_unlock(&st->lock); - return ret; -} - static ssize_t ad2s1210_show_resolution(struct device *dev, struct device_attribute *attr, char *buf) @@ -519,8 +475,6 @@ static int ad2s1210_read_raw(struct iio_dev *indio_dev, static IIO_DEVICE_ATTR(fexcit, 0644, ad2s1210_show_fexcit, ad2s1210_store_fexcit, 0); -static IIO_DEVICE_ATTR(control, 0644, - ad2s1210_show_control, ad2s1210_store_control, 0); static IIO_DEVICE_ATTR(bits, 0644, ad2s1210_show_resolution, ad2s1210_store_resolution, 0); static IIO_DEVICE_ATTR(fault, 0644, @@ -566,7 +520,6 @@ static const struct iio_chan_spec ad2s1210_channels[] = { static struct attribute *ad2s1210_attributes[] = { &iio_dev_attr_fexcit.dev_attr.attr, - &iio_dev_attr_control.dev_attr.attr, &iio_dev_attr_bits.dev_attr.attr, &iio_dev_attr_fault.dev_attr.attr, &iio_dev_attr_los_thrd.dev_attr.attr,