From patchwork Thu Sep 21 14:19:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 142945 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp5162319vqi; Thu, 21 Sep 2023 14:58:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHJWSFct/nRxoi7yc68chOxZkgsiLZJqXwBgapcaM8Q7SSI4jqfdrTkjB+Vyki1iqM4KXjg X-Received: by 2002:a05:6359:3201:b0:143:9235:9f1f with SMTP id rj1-20020a056359320100b0014392359f1fmr653035rwb.12.1695333497601; Thu, 21 Sep 2023 14:58:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695333497; cv=none; d=google.com; s=arc-20160816; b=0zPiWdshn/EIdWhHZdHRN0SY/LtZZCzGZP/FfjTISmHJXDobd0oIwcBbd0ZqpH8OyR UuFHi7ciy7Eehd9VFf9FhsZGi8Vv1UEYrxDLB0YFTXvonK/Gx0Rsavwpc2T+wk0sWOzN YgpbguBXmpJKgEYzeg7+Owj6oHlf6pxLXyTN9AAQ/UZusla4O7Nq+i9EfQsmv6kHPXb4 cJk+D4kPLmpp3zQIPikBmrJod/D0Q+WQ8WhjqNPTUCLjj1ZQk9xxnEPA3zWw/BJ8fMkg eKLslphNRRvB70ZOsyEYjczztwAxJjAPg+DMv3qQPkmQHK2pcdJ16sVDNhEi7XgcpSUF N4PQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=gabiCx8aQ+iMVEJft2DL0LHbd3RWq71VIbUUi+w3JfM=; fh=rOC7q8UJisRayejF6PsoKdRfRTtXVZOwgDCXOG0B/ws=; b=VAAgwzCEdIql/vuN5UWTX9zxT9fVg2C+u750mi4BMnE4YrbjSa7MveVRaveLewOhqV +RDV9ok7HhV8i0dyLe5/p7HPHBRyaVgixDUKmks50sAzut4lVg0hZYRFeAlLtS4i9nJS VAklBhjDq+5SzK5MBtJ4ilxRallNnkPuRgZqKBboyblVUfzVaVdL0ViANnqXNJOZYHM6 8TiafZEfaNJaDJsAQhgBKvhjuoNjw53Q2sE1F4o8dRkxpdaw0wvvVQKLLPFHcwzAT4ft yrRanJBusZbvbc9nRWkNvWPRDBsQM+09vh93ax3IyVw1V5hb+H0PdfB4rbejj4q3/yXj cNPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b=Gj1N929O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id m1-20020a656a01000000b0054fbd904b6dsi2503073pgu.500.2023.09.21.14.58.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 14:58:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b=Gj1N929O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id AEE418082861; Thu, 21 Sep 2023 10:52:23 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230193AbjIURve (ORCPT + 29 others); Thu, 21 Sep 2023 13:51:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229747AbjIURvQ (ORCPT ); Thu, 21 Sep 2023 13:51:16 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BB991BF for ; Thu, 21 Sep 2023 10:22:14 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-501eec0a373so2194305e87.3 for ; Thu, 21 Sep 2023 10:22:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1695316932; x=1695921732; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gabiCx8aQ+iMVEJft2DL0LHbd3RWq71VIbUUi+w3JfM=; b=Gj1N929OQhSew4rZWjj1I9EtfgztYKeM9fj6JuUS07OyUy9qA1gjz3i35SI5Czt1MN Y8Ri5S+zC+BTTYP6zdrVJTkxW+Yh5QM9FkyCOK29dAhm9LE3YdkcSWjHdgdvqP4t3gXF jQlOx6CQZImywvD5iOm1mfe73sf+/ejCHlBwPBket5W+9JW7rUqBeAloA2vTg9MzCZIm SwS4HvbXwPF1X+TkWh4J9wvrlgc9MOB4YquWu4Nx7iVcw5p4jb5ngw9COMMEURCMdwK7 biZX5to2UTYSBOVASai28EfL0Sv9Y3mqkUlx6hIej4oaYx//bx2RQ7q//O3Ikcb1UMld mp2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695316932; x=1695921732; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gabiCx8aQ+iMVEJft2DL0LHbd3RWq71VIbUUi+w3JfM=; b=nG9L4K9XUiUlukpbtajj9nBkKkSRQF9AAJvhujkdk9sW6r28f7HhDeJvBHfKvQXKpV bi4mogdt9daNNH7N1WXUbPEvTljz5/V3funt6GMsL3ie00JHcNqhWihWlvJMCJIdlg8g tVDSm6H1maKzcC6ZFUzy9JSKPsnR73vXETa2DeKUfUkQZ61lvKj2LE05c7Yq5u4sK2O5 uZ3a0MbC3FKL8EWwcokejQZoKJXYaned8Kvgg+MReWkpq5e8hfILYlIS+f8mPopf93cB 15Lclj9ezNQuchPgXHSbABkopmWWLS4RPaXP4gmhWAh4M0a3DIyhUcVA3NiFXYnlhLZZ GHzA== X-Gm-Message-State: AOJu0YyIZd5eF9VjBOHzvXydczZ6kiHK5E178HCo3wddxWBv2gtqJKGw J7vdS8MtgJ+mvUNfgTrCKmMeIVqYgpxX3prmpI6A4NQL X-Received: by 2002:a5d:6e54:0:b0:31a:e8e6:8a96 with SMTP id j20-20020a5d6e54000000b0031ae8e68a96mr5153996wrz.67.1695306157156; Thu, 21 Sep 2023 07:22:37 -0700 (PDT) Received: from localhost.localdomain (abordeaux-655-1-129-86.w90-5.abo.wanadoo.fr. [90.5.10.86]) by smtp.gmail.com with ESMTPSA id n11-20020a5d4c4b000000b0031fbbe347ebsm1901426wrt.22.2023.09.21.07.22.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 07:22:36 -0700 (PDT) From: David Lechner To: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-staging@lists.linux.dev Cc: linux-kernel@vger.kernel.org, Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Hennerich , =?utf-8?q?Nuno_S=C3=A1?= , Axel Haslam , Philip Molloy , David Lechner Subject: [v2 06/19] staging: iio: resolver: ad2s1210: always use 16-bit value for raw read Date: Thu, 21 Sep 2023 09:19:34 -0500 Message-Id: <20230921141947.57784-9-dlechner@baylibre.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230921141947.57784-1-dlechner@baylibre.com> References: <20230921141947.57784-1-dlechner@baylibre.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 21 Sep 2023 10:52:23 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777686017550511851 X-GMAIL-MSGID: 1777686017550511851 This removes the special handling for resolutions lower than 16 bits. This will allow us to use a fixed scale independent of the resolution. Also, for the record, according to the datasheet, the logic for the special handling based on hysteresis that was removed was incorrect. Signed-off-by: David Lechner --- drivers/staging/iio/resolver/ad2s1210.c | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c index 9c7f76114360..985b8fecd65a 100644 --- a/drivers/staging/iio/resolver/ad2s1210.c +++ b/drivers/staging/iio/resolver/ad2s1210.c @@ -465,10 +465,7 @@ static int ad2s1210_read_raw(struct iio_dev *indio_dev, long m) { struct ad2s1210_state *st = iio_priv(indio_dev); - u16 negative; int ret = 0; - u16 pos; - s16 vel; mutex_lock(&st->lock); gpiod_set_value(st->gpios[AD2S1210_SAMPLE], 0); @@ -494,20 +491,11 @@ static int ad2s1210_read_raw(struct iio_dev *indio_dev, switch (chan->type) { case IIO_ANGL: - pos = be16_to_cpup((__be16 *)st->rx); - if (st->hysteresis) - pos >>= 16 - st->resolution; - *val = pos; + *val = be16_to_cpup((__be16 *)st->rx); ret = IIO_VAL_INT; break; case IIO_ANGL_VEL: - vel = be16_to_cpup((__be16 *)st->rx); - vel >>= 16 - st->resolution; - if (vel & 0x8000) { - negative = (0xffff >> st->resolution) << st->resolution; - vel |= negative; - } - *val = vel; + *val = (s16)be16_to_cpup((__be16 *)st->rx); ret = IIO_VAL_INT; break; default: