From patchwork Thu Sep 21 14:19:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 142909 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp5136736vqi; Thu, 21 Sep 2023 14:03:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE72ZKSBZzQAlaiunNsmvShoZU/KJyXnb4JvI3RKEUOyhu36oAgQYmGVt8ekBIOhXpOzebD X-Received: by 2002:a05:6a20:918b:b0:140:a6ec:b55f with SMTP id v11-20020a056a20918b00b00140a6ecb55fmr7475702pzd.16.1695330197081; Thu, 21 Sep 2023 14:03:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695330197; cv=none; d=google.com; s=arc-20160816; b=a90YJLDUfB2UkvD5PRLSNFJUPG6obRC4vke2qf0w9fseeIrqMKmltGLYKglAfSild4 H4r1aAQ+MvNUwVkWzZkuiHT5BE/wDFVMriUXuryYBMkJOrVWb2gfMkYPkwLR6KB0g398 YpDKMMhN1EEwSXf7HLLZ2bLLdPG8YFyfMlAQFqgCOR8GCunLbu3k53SCOmIXnZEPkW0a 43GyvSTRx+HdnplXptinLg2LdezBLJjwRLPgeMTx8oOWad4OWBZ/rmNaQBZNLFwM0uSM zXPaJ2RycmzwANwP2WGqq+MUt1TyYrdc1cp29dZxz4moXD3UMA6Jpyk0xKLB7mwDUVZM pHyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=x9YCZ78k5Zg5KKitr5PpHsZw/Rz0qYyLXQR2L135bIs=; fh=rOC7q8UJisRayejF6PsoKdRfRTtXVZOwgDCXOG0B/ws=; b=fvPOYvPkLBiijFWiamcj0M8zLEdvVDhZxvqcnpfIZJ9bK+gn0C6O9FLm/iPKQYnQWs nn4xBWYD/6GxvN4XGTj1ijzplz6T3tDXFXJQFj0lYdPrfUvBZpP/QbQjx22ljJy6cRr1 mLIjMfrxiCSyUn5E2LJZ93umDUtE24P8XoNmaH7QLcobF0vtS44hOrxOz27M+hF/thse n8PbbIwkqQ1f3lEZMNJdXWh353UL2sZ0kxGceauY/OC/TkqCHEEJMwBmvcut2KrPHNc9 H+raUKPgHienyRbOy473QnQFruVYkvYuPIYha4lqY8rZId4SerVxAm1KDxtSFfGv2rR1 1+7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b="p725f+u/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id e9-20020a636909000000b0056a9544e894si2163157pgc.397.2023.09.21.14.03.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 14:03:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b="p725f+u/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id E432181CDE02; Thu, 21 Sep 2023 13:02:57 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231561AbjIUUBs (ORCPT + 28 others); Thu, 21 Sep 2023 16:01:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230089AbjIUUBI (ORCPT ); Thu, 21 Sep 2023 16:01:08 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BDB057B08 for ; Thu, 21 Sep 2023 10:18:48 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-503f39d3236so2125504e87.0 for ; Thu, 21 Sep 2023 10:18:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1695316726; x=1695921526; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=x9YCZ78k5Zg5KKitr5PpHsZw/Rz0qYyLXQR2L135bIs=; b=p725f+u/GCXMgTcmvd17mKS+XZWOteY2gYOCuBCh3vzHoy4MPBVGu8WPx52QLOOrxJ /YD14zD1WxUTKzA2AjDjFfdV9UNlqtY9DrGghfgJ5F2KSjb/xJmhhQNS2EApCbOFz/GA LTrqISiUfpoTveqcCnArZJWaHZhqo/E0InpkUaDXWv2GcZBnfSkYbz/dlD9+7YyFguFR gI2LWTPZBBXU/H35iS4XTC0FaShVnZGoC5soqgO4C2AyqcRaD5J799xNJXZRDUc8QbuW ++AcZviGCZZARa6wMF5gGVps2bi3DFxPpMw4pDVhEYPCbx5a3GxhCsbXWW6lJM37f5/m oTOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695316726; x=1695921526; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x9YCZ78k5Zg5KKitr5PpHsZw/Rz0qYyLXQR2L135bIs=; b=i6mLRe7MfYJ1Wcfl7IKifNASPdE+i9SybKXCY4Hs2hsQb5wwJ7rCahgMAakC9dHwsc glWkaKEFQodtq7r4tDsi1pLXMzinfBqZgjJAVkvX3WLL0X9i/RWrlarwESARqFd4QQ23 SfGzmjg8IdvuolRx2f4hHcQo/kNwb2ERuPrkF7n5nE2SNRzgzbji9TUIWo61QzvaDftA hfrrslY+cwQg/AZYRMY5VudEHkGCfqp3TjMA4/0EK3SCOKUxUkiIeDGHxqJUAaHGAbQ+ NwAkYNb7uTKf2M7J9Ty5G72zVE2hwGy9Se+FRgySW8VoDVWRR7Wdj0AHVRLrJnxP7nxG c35w== X-Gm-Message-State: AOJu0YwcPqN9AQYkIZ/nV5GioALAxL+4fbZ50LKl9EcHoXxQn9PvLI3b FO5JE70pwEHAsIrDLvA2rDPIkIoMYbA2RepfcbO96NQl X-Received: by 2002:adf:fe8e:0:b0:319:f9d6:a769 with SMTP id l14-20020adffe8e000000b00319f9d6a769mr5207822wrr.45.1695306155398; Thu, 21 Sep 2023 07:22:35 -0700 (PDT) Received: from localhost.localdomain (abordeaux-655-1-129-86.w90-5.abo.wanadoo.fr. [90.5.10.86]) by smtp.gmail.com with ESMTPSA id n11-20020a5d4c4b000000b0031fbbe347ebsm1901426wrt.22.2023.09.21.07.22.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 07:22:35 -0700 (PDT) From: David Lechner To: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-staging@lists.linux.dev Cc: linux-kernel@vger.kernel.org, Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Hennerich , =?utf-8?q?Nuno_S=C3=A1?= , Axel Haslam , Philip Molloy , David Lechner Subject: [v2 04/19] staging: iio: resolver: ad2s1210: fix not restoring sample gpio in channel read Date: Thu, 21 Sep 2023 09:19:32 -0500 Message-Id: <20230921141947.57784-7-dlechner@baylibre.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230921141947.57784-1-dlechner@baylibre.com> References: <20230921141947.57784-1-dlechner@baylibre.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 21 Sep 2023 13:02:57 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777682557010777689 X-GMAIL-MSGID: 1777682557010777689 In theory, this code path should not be reachable because of the previous switch statement. But just in case we should make sure we are restoring the SAMPLE gpio to its original state before returning in addition to releasing the mutex lock. Signed-off-by: David Lechner --- drivers/staging/iio/resolver/ad2s1210.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c index 84743e31261a..0bdd5a30d45d 100644 --- a/drivers/staging/iio/resolver/ad2s1210.c +++ b/drivers/staging/iio/resolver/ad2s1210.c @@ -510,8 +510,8 @@ static int ad2s1210_read_raw(struct iio_dev *indio_dev, ret = IIO_VAL_INT; break; default: - mutex_unlock(&st->lock); - return -EINVAL; + ret = -EINVAL; + break; } error_ret: