From patchwork Thu Sep 21 14:19:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 143077 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp5264463vqi; Thu, 21 Sep 2023 18:57:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE5GGh/5/bh0XVA+BaVw9TrWcG0vYD7S1d0xQIa7/bcfgvIzofIC7tIgl9qUoFq/Dq48ijG X-Received: by 2002:a05:620a:29d6:b0:773:a5fd:6f2a with SMTP id s22-20020a05620a29d600b00773a5fd6f2amr10154153qkp.53.1695347842929; Thu, 21 Sep 2023 18:57:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695347842; cv=none; d=google.com; s=arc-20160816; b=Bsvv6NdI5r/mLrLMVLhvXDXXu+hRpa5X0FyVsdtN+g3rTxLa8IJv+LUy0f8G9JH4Tv sDHtyf8iyiv76Z5qsZ59vWeOoVFabsuQct8dLWvDVE6sL9etroaTPtuEwLZUVltyiPH4 4+ADSjzNxQfN3HcNuveim9l6fk/OfUJ5pxovcbe2RMeaAsmLc07QEHjZAitiiOOYX67/ H/GQkokDlelrDW22yyd72N8COs9FvvD4r202CFVeX9gjorSH4j4mnNB3kl6vYfYCQSuS qK8dW+hI8ajM3FwQFX9RUzLcDTMhgn6LnNoAD1Pk9Q+QpdWX7XggIxKjeiALCZ7SWAeR UrdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=NWszhBlTWMiwkXqgF1w4h8oNmYkV0xe9wPBMJvnXBgI=; fh=rOC7q8UJisRayejF6PsoKdRfRTtXVZOwgDCXOG0B/ws=; b=KMn1nnRPA6l0a1VubrJ93MEZcZrQ8xMSBQqSsv/NNojp/d5B/V51dqrb7jkFjdYObO SoelGdAxQcRS49OWmYJOruLeTl0+ovyjm2/59sYjdxg911w84CEcbkWiY3tpFsZbbycc BmGGp+xAQa6M4YSYEW3WP58vwkDwFq/bWgI3ztjUDK1c9BuKelQLCyny26De1sH68fbA lPcDxvH2phjk09BKF+xak9rdDaBJi1TRZ+y0kR/K4LK6qnh2j4SQzh8+qA9LlDb5beEz niLr/JLhMLGVicjikR5ehPRoCYVOzrhgUcIW3zuaTV2DL7RgXtjZ28Lu7AU6brdnpJx4 u18g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b=gGR9Ph21; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id cf4-20020a056a02084400b005661e3f6b0dsi2697757pgb.329.2023.09.21.18.57.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 18:57:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b=gGR9Ph21; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 5BDC58057DB6; Thu, 21 Sep 2023 13:12:34 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231152AbjIUUMV (ORCPT + 28 others); Thu, 21 Sep 2023 16:12:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230204AbjIUULz (ORCPT ); Thu, 21 Sep 2023 16:11:55 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 634B5561ED for ; Thu, 21 Sep 2023 10:17:50 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-5334f9a56f6so784143a12.3 for ; Thu, 21 Sep 2023 10:17:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1695316669; x=1695921469; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NWszhBlTWMiwkXqgF1w4h8oNmYkV0xe9wPBMJvnXBgI=; b=gGR9Ph21fAE+az4hS0gxgRHlY8bXY/GswP7AjtctrxJJIQzHJvSEqU+yW5eWlQi9rk vlQZmPOu4fM29G7+lE6+DC83crxuHW2xV3nFcgX45kDO3CuC/iDlHUt38EYPJ2/AtfOp Fa7na4vIVAIE3w3fZo8N3fRNvyxdRuyZOhnRLmmESpinoGKoz8JQgLx8VjpW/N2KTGlf anwn/M+U636gNd83CnJPHwA4toR0LE3oQHGA6SHc0TjKiF9XsdviUK//0i/7hA3HfV9T PqJ3R1/lT0hoO67nRgce1Vs/ao3flGEmIv8vDpGd91tKChnVKb4Gw8IIJvXhaep5/lgr 8weA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695316669; x=1695921469; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NWszhBlTWMiwkXqgF1w4h8oNmYkV0xe9wPBMJvnXBgI=; b=SgKJ6/riiHg2Az0XBTLGuOnZlsdaJuuExnhYiKSVvpi+jssmyaCRkOEec4ml0Qb0Go 96EUuQTs2L1xjYxDBdTKU3uYp2hpIFlLwr3yrdvi5hK5hjLiAgBVsEDmt8SImr3O/YpO UL6pm0fJsnzsvloHODqLF+8X8e0LdRnVd97Y/7f21Zi0rgiacOsiB+BIcOtncbLqxtq3 +2fl3hzgLNG73kfMRwhqPZFnKAuj0+ThPIMI+pSiYQioPy8hG8st5RsvQybbyRVpL//0 s0hKk/1BtXNRw237bngYOtVf70I+zOY1YFRQ22wp1iXbqhzQyi0FOYQlAoLsjj1s5wmv fk2w== X-Gm-Message-State: AOJu0YzwhHyEE93C9NJk9KbL+Nyin7KIprkVyps2OfkPkbQ/l0+gOJ/j RU1+HRtA7VqPguu/bnkz5wamb8FA8pkpVQWbc6wq1DaU X-Received: by 2002:a5d:4a82:0:b0:31f:ec91:39a7 with SMTP id o2-20020a5d4a82000000b0031fec9139a7mr5419502wrq.14.1695306154592; Thu, 21 Sep 2023 07:22:34 -0700 (PDT) Received: from localhost.localdomain (abordeaux-655-1-129-86.w90-5.abo.wanadoo.fr. [90.5.10.86]) by smtp.gmail.com with ESMTPSA id n11-20020a5d4c4b000000b0031fbbe347ebsm1901426wrt.22.2023.09.21.07.22.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 07:22:34 -0700 (PDT) From: David Lechner To: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-staging@lists.linux.dev Cc: linux-kernel@vger.kernel.org, Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Hennerich , =?utf-8?q?Nuno_S=C3=A1?= , Axel Haslam , Philip Molloy , David Lechner Subject: [v2 03/19] staging: iio: resolver: ad2s1210: fix ad2s1210_show_fault Date: Thu, 21 Sep 2023 09:19:31 -0500 Message-Id: <20230921141947.57784-6-dlechner@baylibre.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230921141947.57784-1-dlechner@baylibre.com> References: <20230921141947.57784-1-dlechner@baylibre.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 21 Sep 2023 13:12:34 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777701059762418723 X-GMAIL-MSGID: 1777701059762418723 When reading the fault attribute, an empty string was printed if the fault register value was non-zero. This is fixed by checking that the return value is less than zero instead of not zero. Also always print two hex digits while we are touching this line. Signed-off-by: David Lechner --- drivers/staging/iio/resolver/ad2s1210.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c index 06de5823eb8e..84743e31261a 100644 --- a/drivers/staging/iio/resolver/ad2s1210.c +++ b/drivers/staging/iio/resolver/ad2s1210.c @@ -393,7 +393,7 @@ static ssize_t ad2s1210_show_fault(struct device *dev, ret = ad2s1210_config_read(st, AD2S1210_REG_FAULT); mutex_unlock(&st->lock); - return ret ? ret : sprintf(buf, "0x%x\n", ret); + return (ret < 0) ? ret : sprintf(buf, "0x%02x\n", ret); } static ssize_t ad2s1210_clear_fault(struct device *dev,