From patchwork Thu Sep 21 14:19:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 143082 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp5267852vqi; Thu, 21 Sep 2023 19:05:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE0Dx94s3hhY09YO2LQcN1KLnMSRGNal1nlXgd80IcfzsoSpVbvEBV61iS0htze/nWxVTQy X-Received: by 2002:a25:b910:0:b0:d7b:57dc:2b9d with SMTP id x16-20020a25b910000000b00d7b57dc2b9dmr7076612ybj.14.1695348327150; Thu, 21 Sep 2023 19:05:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695348327; cv=none; d=google.com; s=arc-20160816; b=P8Xxp/Zpvfuvua1rSv/YqMFOZl0isLRfL54WPbTwE1Al5DR15/Ss6ibTxzFFe2jpAX N5ql+FlWkCTJ1xp7Gaae4eSHPuaRdLdxpnzrJSYNOmmXsSd3uUxt0bmnoewO7NZ49HwC N3GbFXXWOuTZw2AezgCoPBOcEXYkg7QXmFYiTBLeprs9es80H3TXk2Y/+7f3u6QMpmCn hZoF93t7oqkWuVkLKED3Y5XiDVEyt/2as09xrcUjeKXs4EE+48k0zON5Zpwv4OlKfh22 AC+LIl776DVRjVDm0X35sFiQdZz2yJN2wBRbVzSvcVlPflbI1lYJx25lXAYSUKv4m0xi znIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=T9WVKxDU/WCTxqQ52/M5ua8wasfSRRcZpI1eeblkSC8=; fh=rOC7q8UJisRayejF6PsoKdRfRTtXVZOwgDCXOG0B/ws=; b=hCQTlEipe24Dai9rEBdMP3zg0W+CYVZ8pZNuPu4e9dvpBKe6cYQBk0CLn5PQUBBT8F 2rxPc5wwCd233X8dnLg/reudEVo9t0yZDqeIFf0bTRe0jQb3GejqR39u4+tIZyw/dWD2 1yM//xJ6zkTJ3cJkHoAVrB/whb/H2O5DPCAgodAN8VCzyGmNRMZYOwd4pGmJLxoQ8SdW /zAAN5gaHAkiz62D3xl5rw7uNQu3x13Hw1G4uln4iZSpgM0KPsXJSzmuEIZzEb2xs6N9 qhY7e6HbLawlhvExNa10SWLI/bu5elkClfec0xFY+qAdclK0Knirq6SYjDrLHv6fRuyF Ta6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b=0AA6CHTO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id t23-20020a656097000000b0057ab7f46c8csi2143037pgu.151.2023.09.21.19.05.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 19:05:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20230601.gappssmtp.com header.s=20230601 header.b=0AA6CHTO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 196908315072; Thu, 21 Sep 2023 11:35:58 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230010AbjIUSfe (ORCPT + 29 others); Thu, 21 Sep 2023 14:35:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229902AbjIUSfU (ORCPT ); Thu, 21 Sep 2023 14:35:20 -0400 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A63A37BF3 for ; Thu, 21 Sep 2023 10:24:50 -0700 (PDT) Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-4053c6f0d55so410915e9.0 for ; Thu, 21 Sep 2023 10:24:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1695317086; x=1695921886; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=T9WVKxDU/WCTxqQ52/M5ua8wasfSRRcZpI1eeblkSC8=; b=0AA6CHTOlyn5DcYdQm82Wdh8HrYy77CMizme03XzsnhPkGK49AriWCJXP/I1UmiqUE 0BrIdNXR7UytEoX5+pParh+pZbvAaxIoLmqVL23DoQuoj3+RpnqMMWshRsK/mK66il0P TZ8UMhVNKF4nYOEQ6oytCAxyth8aUhnsQSDIv1DNPtsFyw4//yY/Gr5YIQtkImSgr2J2 JV4t3v0ORKWp8ta22c6KxZClme39ij2zihMqKJnzyl5+pSr6SbaQvsii202YwgyaDjOu /RJ2ENfZQH6RPd970i0VC0cEFo/DVmMZNKEg5z/2wiAdEv8X5vEvxpkwc3kTByDRNStp oc0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695317086; x=1695921886; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T9WVKxDU/WCTxqQ52/M5ua8wasfSRRcZpI1eeblkSC8=; b=SZZG0SZMJNBrqNCfmtJX5dsTSs/mD0UBCdvTwgifrW5w+i0sEOsRci88n+ljcKoiwu ghbVAYnQcap3blN5y1PPemBReZnDtfWx2jO4RN5Vc/ZIHCMwmeh5MTt6wddr7j04IXbz qZC+lZs/1PZ+BfeAkeLeDwp/gqWUhKcPiYQmGOy4qnayvSWAQJtyoHfgzYRfJnWm3wRe 7NCD7kuSAVc+2aUcc5meLCNOJuVyEJyVFGXEWm5wDGadAiTNyjtIHMvxNjJPTCsGA7Ne 2iKuY54QwYXx9M3xoa7L+AK8SoB6qG+xy41GZE34IUrsxBG2FeFoyDRLA5avKHR+PP0F ADKA== X-Gm-Message-State: AOJu0YxPJhZP2BD4Bj8jso/J92YaA7ZxCyfo2hYJDkDEZnn9UTgkHy28 tdhnLe6iJl/4Z5M8Oi8K9/f21ypDr14HSltC5GAUljEr X-Received: by 2002:a05:600c:1d1d:b0:405:336b:8307 with SMTP id l29-20020a05600c1d1d00b00405336b8307mr1536343wms.7.1695306162032; Thu, 21 Sep 2023 07:22:42 -0700 (PDT) Received: from localhost.localdomain (abordeaux-655-1-129-86.w90-5.abo.wanadoo.fr. [90.5.10.86]) by smtp.gmail.com with ESMTPSA id n11-20020a5d4c4b000000b0031fbbe347ebsm1901426wrt.22.2023.09.21.07.22.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 07:22:41 -0700 (PDT) From: David Lechner To: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-staging@lists.linux.dev Cc: linux-kernel@vger.kernel.org, Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Hennerich , =?utf-8?q?Nuno_S=C3=A1?= , Axel Haslam , Philip Molloy , David Lechner Subject: [v2 11/19] staging: iio: resolver: ad2s1210: remove config attribute Date: Thu, 21 Sep 2023 09:19:39 -0500 Message-Id: <20230921141947.57784-14-dlechner@baylibre.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230921141947.57784-1-dlechner@baylibre.com> References: <20230921141947.57784-1-dlechner@baylibre.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 21 Sep 2023 11:35:58 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777701567489845989 X-GMAIL-MSGID: 1777701567489845989 This removes the config register sysfs attribute. Writing to the config register directly can be dangerous and userspace should not need to have to know the register layout. This register can still be accessed though debugfs if needed. We can add new attributes to set specific flags in the config register in the future if needed (e.g. `enable_hysterisis` and `phase_lock_range`). Signed-off-by: David Lechner --- drivers/staging/iio/resolver/ad2s1210.c | 47 ------------------------- 1 file changed, 47 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c index b99928394e3f..223cc4702188 100644 --- a/drivers/staging/iio/resolver/ad2s1210.c +++ b/drivers/staging/iio/resolver/ad2s1210.c @@ -269,50 +269,6 @@ static ssize_t ad2s1210_store_fexcit(struct device *dev, return ret < 0 ? ret : len; } -static ssize_t ad2s1210_show_control(struct device *dev, - struct device_attribute *attr, - char *buf) -{ - struct ad2s1210_state *st = iio_priv(dev_to_iio_dev(dev)); - unsigned int value; - int ret; - - mutex_lock(&st->lock); - ret = regmap_read(st->regmap, AD2S1210_REG_CONTROL, &value); - mutex_unlock(&st->lock); - return ret < 0 ? ret : sprintf(buf, "0x%x\n", value); -} - -static ssize_t ad2s1210_store_control(struct device *dev, - struct device_attribute *attr, - const char *buf, size_t len) -{ - struct ad2s1210_state *st = iio_priv(dev_to_iio_dev(dev)); - unsigned char udata; - unsigned char data; - int ret; - - ret = kstrtou8(buf, 16, &udata); - if (ret) - return -EINVAL; - - mutex_lock(&st->lock); - data = udata & ~AD2S1210_ADDRESS_DATA; - ret = regmap_write(st->regmap, AD2S1210_REG_CONTROL, data); - if (ret < 0) - goto error_ret; - - st->resolution = - ad2s1210_resolution_value[data & AD2S1210_SET_RES]; - ad2s1210_set_resolution_pin(st); - ret = len; - st->hysteresis = !!(data & AD2S1210_ENABLE_HYSTERESIS); - -error_ret: - mutex_unlock(&st->lock); - return ret; -} - static ssize_t ad2s1210_show_resolution(struct device *dev, struct device_attribute *attr, char *buf) @@ -519,8 +475,6 @@ static int ad2s1210_read_raw(struct iio_dev *indio_dev, static IIO_DEVICE_ATTR(fexcit, 0644, ad2s1210_show_fexcit, ad2s1210_store_fexcit, 0); -static IIO_DEVICE_ATTR(control, 0644, - ad2s1210_show_control, ad2s1210_store_control, 0); static IIO_DEVICE_ATTR(bits, 0644, ad2s1210_show_resolution, ad2s1210_store_resolution, 0); static IIO_DEVICE_ATTR(fault, 0644, @@ -566,7 +520,6 @@ static const struct iio_chan_spec ad2s1210_channels[] = { static struct attribute *ad2s1210_attributes[] = { &iio_dev_attr_fexcit.dev_attr.attr, - &iio_dev_attr_control.dev_attr.attr, &iio_dev_attr_bits.dev_attr.attr, &iio_dev_attr_fault.dev_attr.attr, &iio_dev_attr_los_thrd.dev_attr.attr,