From patchwork Thu Sep 21 08:40:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 143040 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp5236044vqi; Thu, 21 Sep 2023 17:42:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGN2puI8wflegn9fThrvhQvkYXbUGCzrrjTqW0JxSQzXWnXSbpGXUCCP9bPtZgy/yE5dG1/ X-Received: by 2002:a05:6a00:2441:b0:68f:e810:e87e with SMTP id d1-20020a056a00244100b0068fe810e87emr6888795pfj.31.1695343335194; Thu, 21 Sep 2023 17:42:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695343335; cv=none; d=google.com; s=arc-20160816; b=bwCbejpk4Wq831dKRo0kJNF/SB0FRxrXI70l19p0jSnAjksSknON25oB94lVRGnOTk l2lvXBHBHb8iYuEC/yqhvCxIeU5+Cd2FdsDMoRUgUZ1djjQQFG68wiAj9LZRTmPGSkLV oIwdsQwjOLS4q1Yt9ynA0UBfTg+vwMruvANp3P/K+l9eQE1MSga2iNBY1SJTt6ixnlk4 ePy7OA/g+T6Cn/Yh15wtauBoMPRN96KsIl6TEqiR9uXGDScBnYwvexReFV0Y0maeeI9H CsprNO7nFrbth5DFELp7rDPcu/3KeLcthOJLASTuwY3ELItBtWgm57Wb5bPXGI9ekXs1 AW0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=BWoG3Cv+9NwMSjOxgnt6dDveNegqs9pWvhh6JaU1+sY=; fh=SI4MpgnZhVszCIVLQChNDV4yLpDBLQK/2RpOrOURj14=; b=REf/OjWIdjOlFSbi3O7FeQrtrrNE9sD3EMlb4akt6TTNjaklTp5l0N9DBv2fzEQF3U q+SS0NPCLhvrpPoXlf69as34Ex1AjkVOIytPUupLHOczusGE5A/aVzG0EcZKr2M7ElxJ F/LmF65PoNJ2rfI2yTRJ5BqIw/zeAqH6hlq3na4gB9XzV/5aV6Lgk2A/gX0/+X9rKWFw l6TKSZHEv6ZjOSAOqyD5PveUVV6NNL+jzfmiSxtyyXy2yaeUA9WKiuq+tgw/aYDZNWI1 uRSHj013a7hj48ACoLcwSSZHukkLZmMhhBxYIx4AU9ghNRfgxFL4uJ7qDPvNimpQ74b5 Rl7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sang-engineering.com header.s=k1 header.b=mYqT33MO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id cw10-20020a056a00450a00b0068c0042d3c9si2528401pfb.239.2023.09.21.17.42.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 17:42:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@sang-engineering.com header.s=k1 header.b=mYqT33MO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id BD142835A3AC; Thu, 21 Sep 2023 11:51:42 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230307AbjIUSvC (ORCPT + 28 others); Thu, 21 Sep 2023 14:51:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229866AbjIUSur (ORCPT ); Thu, 21 Sep 2023 14:50:47 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 162D28A20B for ; Thu, 21 Sep 2023 10:40:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; s=k1; bh=BWoG3Cv+9NwMSj Oxgnt6dDveNegqs9pWvhh6JaU1+sY=; b=mYqT33MOiLshEtmkWv7E5tZ4gsTQaw Z49u0NRmMm7GEcTGxlUoayfUctiKXbquROc53D9gXlY0InY8Su3uIlmtDRC2jTW4 vKQFJgzOFiT2juQoCzjcBkNNlp6PcTNT637JoA5ZbEGEwCUALC6LoOhMN3V842P3 +vrbuSU683OydILnh5UaJrY1a7rKMDJNOA2xKbLAIa2E20EcUs2OaEPSjV/AofvV XUtOu9yw+S9aqV+Gxu8HEq75iNFOgWglql3nCB56Dmd2QNMVEE3COtGYNphnXxWt YyWjwpgVh8120C/ZEPKDolV0UBRAbp/VnXp6Rc0kiS4iOUiHSmDNBCWw== Received: (qmail 881727 invoked from network); 21 Sep 2023 10:40:29 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 21 Sep 2023 10:40:29 +0200 X-UD-Smtp-Session: l3s3148p1@xoK6cdoFk1YuciSu From: Wolfram Sang To: linux-renesas-soc@vger.kernel.org Cc: Wolfram Sang , Minjie Du , Andi Shyti , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] i2c: gpio: remove error checks with debugfs Date: Thu, 21 Sep 2023 10:40:15 +0200 Message-Id: <20230921084016.3434-1-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 21 Sep 2023 11:51:42 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777691380130603226 X-GMAIL-MSGID: 1777696333283699986 debugfs can handle error pointers in subsequent calls. So, remove the error checks as suggested by kerneldoc of this function. Reported-by: Minjie Du Signed-off-by: Wolfram Sang Reviewed-by: Geert Uytterhoeven --- drivers/i2c/busses/i2c-gpio.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/i2c/busses/i2c-gpio.c b/drivers/i2c/busses/i2c-gpio.c index e5a5b9e8bf2c..fb35a75fe0e3 100644 --- a/drivers/i2c/busses/i2c-gpio.c +++ b/drivers/i2c/busses/i2c-gpio.c @@ -263,15 +263,10 @@ static void i2c_gpio_fault_injector_init(struct platform_device *pdev) * 'fault-injector' dir there. Until then, we have a global dir with * all adapters as subdirs. */ - if (!i2c_gpio_debug_dir) { + if (!i2c_gpio_debug_dir) i2c_gpio_debug_dir = debugfs_create_dir("i2c-fault-injector", NULL); - if (!i2c_gpio_debug_dir) - return; - } priv->debug_dir = debugfs_create_dir(pdev->name, i2c_gpio_debug_dir); - if (!priv->debug_dir) - return; init_completion(&priv->scl_irq_completion);