From patchwork Wed Sep 20 10:51:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fedor Pchelkin X-Patchwork-Id: 142568 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp4377810vqi; Wed, 20 Sep 2023 12:33:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGLU5baJ/Z4WMarMWWq5VYTZWvV5NqasXNc1uaGkK/o8dwta6UnI7qCvcq1NOVonEstEiLw X-Received: by 2002:a05:6a00:1587:b0:690:1720:aaa5 with SMTP id u7-20020a056a00158700b006901720aaa5mr3861182pfk.9.1695238428034; Wed, 20 Sep 2023 12:33:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695238428; cv=none; d=google.com; s=arc-20160816; b=g/uAMy+Zk7JNmR+zjOzAZPwvqkf271pENP0cCricylhdSDQI2RNP4RoLAv31il2sDI xq7aMJznAyNV8nmsF38aSgXHG4tcJ+WHDtJeH7oivexNZRIEljZTHIgWq4nGfCsurUJB PMZMz6BDqq7O2X8XXd5oQ3kVEzPYqBefG19Vae7pti2O6SIuqKx2zm3zEjQaXFVNd7Cf UTdxhNAglM3gMU2htPDbLh7HjuxyRN4BE+i4KkBlRLhX62eNgHeLp/+K7WWMd99tioF3 kfeCev7lzX/K92loJVUFX7FSUgvSb8+yViVpJq+p0jYl3/JYIcPRx3ajH/Ihf4bHZEnm tGWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature:dkim-filter; bh=bH6qdMnm7rw9N28xMlf+P+4+Ai14NUr7R3xOVTfyoRw=; fh=8KgDxrjBscg8EPufhBPSQhFRnnWFcIwnM/DT1lq3MqM=; b=ARSkfj94MQLsi0WUtyzeBDoPsjiHPwCNplcnoMiyseVSe3sd5/eSS7AEoUvEDG3Nn2 RP5wbh59V/iBSnrkHLdOyPoh8l+Gn05xddD76nlwAt0Lv6juSTCO4ehxvpSzXdT7Fo1D UShNGLvVzLN6izYgENimAI5xP90pImzds8GNw+TcdTJ8hf2ST4L2+6YcLD+tV6auH8Bo tgV241lKrzy2WkkjmEuygeOaNzIn57rKRArSlnGy7HVIZEoPc7+4YifD+KrRyEmn4uKd KTc931A3kTrbDaPSbdkzwYEXp4wp48wnmdwW4Y1PzOKm8pFr29/f+y4eiRLD1Ot55EcB gqCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ispras.ru header.s=default header.b=ZYAqjy04; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id s67-20020a632c46000000b00577690ac177si12162520pgs.78.2023.09.20.12.33.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Sep 2023 12:33:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@ispras.ru header.s=default header.b=ZYAqjy04; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 18AE682CD626; Wed, 20 Sep 2023 03:52:20 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234306AbjITKwQ (ORCPT + 26 others); Wed, 20 Sep 2023 06:52:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234218AbjITKwP (ORCPT ); Wed, 20 Sep 2023 06:52:15 -0400 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6664B97; Wed, 20 Sep 2023 03:52:09 -0700 (PDT) Received: from localhost.ispras.ru (unknown [10.10.165.14]) by mail.ispras.ru (Postfix) with ESMTPSA id 8B4CD40F1DF9; Wed, 20 Sep 2023 10:52:05 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru 8B4CD40F1DF9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1695207125; bh=bH6qdMnm7rw9N28xMlf+P+4+Ai14NUr7R3xOVTfyoRw=; h=From:To:Cc:Subject:Date:From; b=ZYAqjy04bTpqLkPvFGAYzOTJxHFfOEx1hyzAATWxCHqFXI7mZ/kmYSLl/BZr6Sans 915xbHPTdFIJDZBD9Vakc5EYjc0eafMG5Q/bhzfsFlV6mlWUXvp827lPY0dMPJbaA9 RsOYaxAZuZCHKB8FqMi+vrlIuK2XcTcPZzNVG8ZQ= From: Fedor Pchelkin To: Mike Snitzer Cc: Fedor Pchelkin , Alasdair Kergon , dm-devel@redhat.com, Hannes Reinecke , linux-kernel@vger.kernel.org, Alexey Khoroshilov , lvc-project@linuxtesting.org, stable@vger.kernel.org Subject: [PATCH] dm-zoned: free dmz->ddev array in dmz_put_zoned_device Date: Wed, 20 Sep 2023 13:51:16 +0300 Message-ID: <20230920105119.21276-1-pchelkin@ispras.ru> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 20 Sep 2023 03:52:20 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777580902884825991 X-GMAIL-MSGID: 1777586329709728765 Commit 4dba12881f88 ("dm zoned: support arbitrary number of devices") made the pointers to additional zoned devices to be stored in a dynamically allocated dmz->ddev array. However, this array is not freed. Free it when cleaning up zoned device information inside dmz_put_zoned_device(). Assigning NULL to dmz->ddev elements doesn't make sense there as they are not supposed to be reused later and the whole dmz target structure is being cleaned anyway. Found by Linux Verification Center (linuxtesting.org). Fixes: 4dba12881f88 ("dm zoned: support arbitrary number of devices") Cc: stable@vger.kernel.org Signed-off-by: Fedor Pchelkin --- drivers/md/dm-zoned-target.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/md/dm-zoned-target.c b/drivers/md/dm-zoned-target.c index ad8e670a2f9b..e25cd9db6275 100644 --- a/drivers/md/dm-zoned-target.c +++ b/drivers/md/dm-zoned-target.c @@ -753,12 +753,10 @@ static void dmz_put_zoned_device(struct dm_target *ti) struct dmz_target *dmz = ti->private; int i; - for (i = 0; i < dmz->nr_ddevs; i++) { - if (dmz->ddev[i]) { + for (i = 0; i < dmz->nr_ddevs; i++) + if (dmz->ddev[i]) dm_put_device(ti, dmz->ddev[i]); - dmz->ddev[i] = NULL; - } - } + kfree(dmz->ddev); } static int dmz_fixup_devices(struct dm_target *ti)