diff mbox series

[net-next] net: sfp: add quirk for Fiberstone GPON-ONU-34-20BI

Message ID 20230919124720.8210-1-ansuelsmth@gmail.com
State New
Headers
Series [net-next] net: sfp: add quirk for Fiberstone GPON-ONU-34-20BI |

Commit Message

Christian Marangi Sept. 19, 2023, 12:47 p.m. UTC 
  Fiberstone GPON-ONU-34-20B can operate at 2500base-X, but report 1.2GBd
NRZ in their EEPROM.

The module also require the ignore tx fault fixup similar to Huawei MA5671A
as it gets disabled on error messages with serial redirection enabled.

Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
 drivers/net/phy/sfp.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Paolo Abeni Sept. 21, 2023, 2:40 p.m. UTC | #1 
Hi Russel,

On Tue, 2023-09-19 at 14:40 +0100, Russell King (Oracle) wrote:
> On Tue, Sep 19, 2023 at 02:47:20PM +0200, Christian Marangi wrote:
> > Fiberstone GPON-ONU-34-20B can operate at 2500base-X, but report 1.2GBd
> > NRZ in their EEPROM.
> > 
> > The module also require the ignore tx fault fixup similar to Huawei MA5671A
> > as it gets disabled on error messages with serial redirection enabled.
> 
> I'll send you shortly a different approach for the "ignore tx fault"
> thing that I'd like you to test please.

Said patch is not blocking this one, am I correct?

Thanks,

Paolo
Russell King (Oracle) Sept. 27, 2023, 9:51 a.m. UTC | #2 
On Thu, Sep 21, 2023 at 04:40:45PM +0200, Paolo Abeni wrote:
> Hi Russel,
> 
> On Tue, 2023-09-19 at 14:40 +0100, Russell King (Oracle) wrote:
> > On Tue, Sep 19, 2023 at 02:47:20PM +0200, Christian Marangi wrote:
> > > Fiberstone GPON-ONU-34-20B can operate at 2500base-X, but report 1.2GBd
> > > NRZ in their EEPROM.
> > > 
> > > The module also require the ignore tx fault fixup similar to Huawei MA5671A
> > > as it gets disabled on error messages with serial redirection enabled.
> > 
> > I'll send you shortly a different approach for the "ignore tx fault"
> > thing that I'd like you to test please.
> 
> Said patch is not blocking this one, am I correct?

Correct, but Christian has not responded in any way despite me sending
him the patch that I'd like tested, which is very disappointing.

This is what I fear - that merging his patch removes the incentive to
test my patch. Oh well, I guess I will just send my patch that I can't
test to be merged anyway, and to hell with it. If it breaks this and
other modules, I'm sure someone will eventually send a report about
that.
Christian Marangi Sept. 27, 2023, 9:55 a.m. UTC | #3 
On Wed, Sep 27, 2023 at 10:51:17AM +0100, Russell King (Oracle) wrote:
> On Thu, Sep 21, 2023 at 04:40:45PM +0200, Paolo Abeni wrote:
> > Hi Russel,
> > 
> > On Tue, 2023-09-19 at 14:40 +0100, Russell King (Oracle) wrote:
> > > On Tue, Sep 19, 2023 at 02:47:20PM +0200, Christian Marangi wrote:
> > > > Fiberstone GPON-ONU-34-20B can operate at 2500base-X, but report 1.2GBd
> > > > NRZ in their EEPROM.
> > > > 
> > > > The module also require the ignore tx fault fixup similar to Huawei MA5671A
> > > > as it gets disabled on error messages with serial redirection enabled.
> > > 
> > > I'll send you shortly a different approach for the "ignore tx fault"
> > > thing that I'd like you to test please.
> > 
> > Said patch is not blocking this one, am I correct?
> 
> Correct, but Christian has not responded in any way despite me sending
> him the patch that I'd like tested, which is very disappointing.
>

I'm with you with the disappointment... I was helping a guy adding
support for this upstream and then magically disappeared... Tried to
send private email asking to test your followup patch but still no
response... Sorry for not answering your email, was hoping to have a
response and just give you a positive feedback but I think this won't
come...

> This is what I fear - that merging his patch removes the incentive to
> test my patch. Oh well, I guess I will just send my patch that I can't
> test to be merged anyway, and to hell with it. If it breaks this and
> other modules, I'm sure someone will eventually send a report about
> that.
Russell King (Oracle) Sept. 27, 2023, 10:06 a.m. UTC | #4 
On Wed, Sep 27, 2023 at 11:55:32AM +0200, Christian Marangi wrote:
> On Wed, Sep 27, 2023 at 10:51:17AM +0100, Russell King (Oracle) wrote:
> > On Thu, Sep 21, 2023 at 04:40:45PM +0200, Paolo Abeni wrote:
> > > Hi Russel,
> > > 
> > > On Tue, 2023-09-19 at 14:40 +0100, Russell King (Oracle) wrote:
> > > > On Tue, Sep 19, 2023 at 02:47:20PM +0200, Christian Marangi wrote:
> > > > > Fiberstone GPON-ONU-34-20B can operate at 2500base-X, but report 1.2GBd
> > > > > NRZ in their EEPROM.
> > > > > 
> > > > > The module also require the ignore tx fault fixup similar to Huawei MA5671A
> > > > > as it gets disabled on error messages with serial redirection enabled.
> > > > 
> > > > I'll send you shortly a different approach for the "ignore tx fault"
> > > > thing that I'd like you to test please.
> > > 
> > > Said patch is not blocking this one, am I correct?
> > 
> > Correct, but Christian has not responded in any way despite me sending
> > him the patch that I'd like tested, which is very disappointing.
> >
> 
> I'm with you with the disappointment... I was helping a guy adding
> support for this upstream and then magically disappeared... Tried to
> send private email asking to test your followup patch but still no
> response... Sorry for not answering your email, was hoping to have a
> response and just give you a positive feedback but I think this won't
> come...

In my experience, unfortunately, this is what happens in circumstances
like this. There are some cases where it doesn't happen but inevitably
when it's someone who's popped up with a problem, that's all they care
about. After a while one gets jaded over it.

Thanks for trying anyway.
patchwork-bot+netdevbpf@kernel.org Sept. 28, 2023, 7:40 a.m. UTC | #5 
Hello:

This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Tue, 19 Sep 2023 14:47:20 +0200 you wrote:
> Fiberstone GPON-ONU-34-20B can operate at 2500base-X, but report 1.2GBd
> NRZ in their EEPROM.
> 
> The module also require the ignore tx fault fixup similar to Huawei MA5671A
> as it gets disabled on error messages with serial redirection enabled.
> 
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> 
> [...]

Here is the summary with links:
  - [net-next] net: sfp: add quirk for Fiberstone GPON-ONU-34-20BI
    https://git.kernel.org/netdev/net-next/c/d387e34fec40

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
index 4ecfac227865..a50038a45250 100644
--- a/drivers/net/phy/sfp.c
+++ b/drivers/net/phy/sfp.c
@@ -452,6 +452,11 @@  static const struct sfp_quirk sfp_quirks[] = {
 	// Rollball protocol to talk to the PHY.
 	SFP_QUIRK_F("FS", "SFP-10G-T", sfp_fixup_fs_10gt),
 
+	// Fiberstore GPON-ONU-34-20BI can operate at 2500base-X, but report 1.2GBd
+	// NRZ in their EEPROM
+	SFP_QUIRK("FS", "GPON-ONU-34-20BI", sfp_quirk_2500basex,
+		  sfp_fixup_ignore_tx_fault),
+
 	SFP_QUIRK_F("HALNy", "HL-GSFP", sfp_fixup_halny_gsfp),
 
 	// HG MXPD-483II-F 2.5G supports 2500Base-X, but incorrectly reports