| Message ID | 20230919094021.24699-1-colin.i.king@gmail.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp3683164vqi;
Tue, 19 Sep 2023 14:12:20 -0700 (PDT)
X-Google-Smtp-Source:
AGHT+IG77PVS+eLtYQKNdAbt/mu/vBSi0ShYQq+0VZadR4ZKJ0P6CnNqwXs6wImY8QiHHSXQu4mi
X-Received: by 2002:a05:6a21:788a:b0:126:42ce:bd44 with SMTP id
bf10-20020a056a21788a00b0012642cebd44mr4473876pzc.17.1695157939637;
Tue, 19 Sep 2023 14:12:19 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1695157939; cv=none;
d=google.com; s=arc-20160816;
b=uWggfQ2GC+ZUv5FTPA7pkzMV5QRakIZ7FnLf541OTAJZvgPF5InYz0XGrlypSsc+aB
WDmei9r/2CoXS26CZjmVYJLuthb2AKbap/21EPWaruPxqqTCdSdwz3O0ed9Sbj3EVKX5
Jolsc7BEg05ZnWOENS3KIgvYSvJ4OjAfeHTaie7mXfJbWEklGbYqE+Bk7H6r+ZAmPiCp
kcRV9r2+DpW0YtpC0NsgmYZhp0jEMRRqgOFyK6+eLRJwEJ55aTEF6Av5G43u1LXDPXhO
+Uz1uT/Pm3Kdi5HBaIjfW4p+IYmUxiFXjW1Ox5oFtLLSEcmyyXT2WF+XqiiNCbA2VpVJ
7lWg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=xTBOgApdCZqtXfBGdHJ8Yj4aJ1bsJAJH5MGuBHuHFVE=;
fh=3NOo/exttGgf2RsbLpCFpxbvKdPCS5uAzyGVWYU9xXU=;
b=XFABx2/1th3NkG/lu+IYpE1dgCiC/+q/HlklW03L4BdOZWXi4OkTftqojbc2l+t2Wj
1wW/n2zDOAUmnZtm6KC6Cy5LICW/WBJyw56W4gjWXYl0EvNO6MNvCzA9rvrWZ27uS0Kf
Aj1W6ahTDg5hLMFeqCoqbmPhrh2qJx8BpU3+soISThLelogswG9aAfrgq3GuxM4mz1Wt
s9sZCXxboBG+cEYaP3fROV+c0xaBfMMqunoH2FWzvQGD2YwXFFzdyHFbcP6BYZAeuMGn
nG0SXCR7otaTGrFrDx3NS/ekajic/26fB08Jeyer30LRlURbJ72ycihKFmGYMLLpmnGO
oZCA==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@gmail.com header.s=20230601 header.b=JC5QLZor;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:8 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8])
by mx.google.com with ESMTPS id
a35-20020a631a63000000b00564bcae8b64si10252057pgm.846.2023.09.19.14.12.19
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 19 Sep 2023 14:12:19 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:8 as permitted sender)
client-ip=2620:137:e000::3:8;
Authentication-Results: mx.google.com;
dkim=pass header.i=@gmail.com header.s=20230601 header.b=JC5QLZor;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:8 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0])
by fry.vger.email (Postfix) with ESMTP id 0AB748094D40;
Tue, 19 Sep 2023 02:40:57 -0700 (PDT)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S231465AbjISJkj (ORCPT <rfc822;toshivichauhan@gmail.com>
+ 26 others); Tue, 19 Sep 2023 05:40:39 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45558 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S231633AbjISJkb (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Tue, 19 Sep 2023 05:40:31 -0400
Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com
[IPv6:2a00:1450:4864:20::430])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE9CBE5;
Tue, 19 Sep 2023 02:40:24 -0700 (PDT)
Received: by mail-wr1-x430.google.com with SMTP id
ffacd0b85a97d-3216ba1b01eso187051f8f.2;
Tue, 19 Sep 2023 02:40:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1695116423; x=1695721223;
darn=vger.kernel.org;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=xTBOgApdCZqtXfBGdHJ8Yj4aJ1bsJAJH5MGuBHuHFVE=;
b=JC5QLZork8Hz0Vfboei41o5ODZlYjVAcXAxN0Rya119hZI8nPubLu3bpZSOVIsf7iF
hABK6bAvDdZVgx+UWp7uLlBfCVWI8GE/VLC352B5DgufWDsB1UEFNYMBS5dQyXnRvEVR
rntDevLqDZu6oZekgtnpkI7unwzULgXNobMXTvQDZsTHxA6vIglM1ATiBmDVhupbRdx6
zgtl4bcnPmEcJ5apdJeU7uAOBe+50lZMANt+b05yeVzRMnxQwcEvovVEz/sNtmkxf7Au
0zNj1YUPssOWMahdmsm1JWYI+yNmPv3PjkdGaP9E3lS2EdkG8cghT9BPrcj8IJtQjXNy
npPA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1695116423; x=1695721223;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=xTBOgApdCZqtXfBGdHJ8Yj4aJ1bsJAJH5MGuBHuHFVE=;
b=ihQbSfshgaweDt/RNuN81IteDk68QxrJZoUfSafP4M69nM1slNdsptlH/fszVarAc7
sLav2okbWAPdf4tpXxMnrkZVIE1kREjlEWdiBldmJR9PCvSGWYVqzDVEOGJSvzyadGbZ
3dGGUR7w2yeT10Gdvent4Am3xezfHCZtunEEqm/Witr9aTrObj6s1i7zRVmHqCl7jjRr
dwQXT28y/YpbfftoWQu6F3+6zLsaPHfih/e6i9fnS8CVIOy0jQPulywDRjIMdXbbvuEh
FZNHYHkbEpaOPO2u6WW3Y/A1tTVIhqG+E7yC7UUk6Wk14rkcJHJTSURBQUZbOB2p9j+c
dkHA==
X-Gm-Message-State: AOJu0Yy8eGWHqkpn7ypmJXJsHmkAoVuqyyW/u4Fv3LY837UoDxBIULM1
UWWsBgKumnKFT+I3xeLRgPg=
X-Received: by 2002:a05:6000:22b:b0:31f:f982:5395 with SMTP id
l11-20020a056000022b00b0031ff9825395mr8563350wrz.35.1695116422875;
Tue, 19 Sep 2023 02:40:22 -0700 (PDT)
Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net.
[80.193.200.194])
by smtp.gmail.com with ESMTPSA id
v17-20020a5d4b11000000b00319779ee691sm15014885wrq.28.2023.09.19.02.40.22
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 19 Sep 2023 02:40:22 -0700 (PDT)
From: Colin Ian King <colin.i.king@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH][next] net: dsa: mv88e6xxx: make const read-only array lanes
static
Date: Tue, 19 Sep 2023 10:40:21 +0100
Message-Id: <20230919094021.24699-1-colin.i.king@gmail.com>
X-Mailer: git-send-email 2.39.2
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,
HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test,
not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]);
Tue, 19 Sep 2023 02:40:57 -0700 (PDT)
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1777501931632118103
X-GMAIL-MSGID: 1777501931632118103
|
| Series |
[next] net: dsa: mv88e6xxx: make const read-only array lanes static
|
|
Commit Message
Colin Ian King
Sept. 19, 2023, 9:40 a.m. UTC
Don't populate the const read-only array lanes on the stack, instead make
it static.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/net/dsa/mv88e6xxx/pcs-639x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Tue, Sep 19, 2023 at 10:40:21AM +0100, Colin Ian King wrote: > Don't populate the const read-only array lanes on the stack, instead make > it static. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Tue, 19 Sep 2023 10:40:21 +0100 you wrote: > Don't populate the const read-only array lanes on the stack, instead make > it static. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > --- > drivers/net/dsa/mv88e6xxx/pcs-639x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [next] net: dsa: mv88e6xxx: make const read-only array lanes static https://git.kernel.org/netdev/net-next/c/ccd663caffc7 You are awesome, thank you!
diff --git a/drivers/net/dsa/mv88e6xxx/pcs-639x.c b/drivers/net/dsa/mv88e6xxx/pcs-639x.c index ba373656bfe1..9a8429f5d09c 100644 --- a/drivers/net/dsa/mv88e6xxx/pcs-639x.c +++ b/drivers/net/dsa/mv88e6xxx/pcs-639x.c @@ -208,7 +208,7 @@ static void mv88e639x_sgmii_pcs_pre_config(struct phylink_pcs *pcs, static int mv88e6390_erratum_3_14(struct mv88e639x_pcs *mpcs) { - const int lanes[] = { MV88E6390_PORT9_LANE0, MV88E6390_PORT9_LANE1, + static const int lanes[] = { MV88E6390_PORT9_LANE0, MV88E6390_PORT9_LANE1, MV88E6390_PORT9_LANE2, MV88E6390_PORT9_LANE3, MV88E6390_PORT10_LANE0, MV88E6390_PORT10_LANE1, MV88E6390_PORT10_LANE2, MV88E6390_PORT10_LANE3 };