From patchwork Mon Sep 18 19:50:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 141542 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp2914922vqi; Mon, 18 Sep 2023 12:55:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEnOmmzqTiXWQuiCcjAdGjBu6wjaPRn7rdCxLlpBNJrS7l9bS4P4eOz+5h2CQifi2j0ESAF X-Received: by 2002:a05:6a20:7483:b0:158:1387:6a95 with SMTP id p3-20020a056a20748300b0015813876a95mr10157307pzd.19.1695066945677; Mon, 18 Sep 2023 12:55:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695066945; cv=none; d=google.com; s=arc-20160816; b=V9hUnVbG8CNi/ibfSkAHkeeosOSWlZt5S5ia1Rmk9cn50/YD3+N/j1nisFp+0Ut3vP x6d2Zjw4UCxj5yLGQN5NJwAYyDZ44NsBgvbNNKG7hpmYISiM1MY3MzF7Ejr5zNhT6fIs m506FbOLRfstVYo4hUYZWzQmaJLxWS3+fFDB7Uiww5Bn7Sv3wpSHi9fAudavU7jidcnA i+suhoOp3T24nmO3AiUTMc4oaXuj8ePDaK75A9YsX344UnY81yQGKuROXEJkAvuixzBG fECtrGpzdPzDK0MxZxaOHPnisA86n00M1GYdeGW+7S9F0RCooPBfqv5R4Ec2OddXtOjn N1zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=zHhBcFN9+9Al4FocXipS/rOCwpRWZx7m5H3DRuOmBok=; fh=2LoUldgIftbCGGYNlIKiEffIWCdRcQL9EB8MUfMGcWk=; b=ppGKpngvHIJm81mXPmRnwrr1OL9mOAomofxDAqwGMH0R3zKF93AsCcQUfh1/mqR+nd q7aYJXZGmk4dz9kiB6rhy5qje44faLJxY5pVgH+4lQ6cr03/NjVNke1lZjDpzO09ThLT m2Z8WWq/oR4mwrXOGcLBDuq3bEBxsafbpUCB9/7SmUoIpsNfj0zsA7ZRqZ9Xquu19gUo nif5ytYKhL/vNd8bgk9XpiyhEY714HEqyYFscIlH8xesWgwLlt0244zK9TjaX6JIRRCd 1qBdddYhX6gjbFsqPrUN8v+01cFG5I30yqCnPyeThSNUe0pLzgaGJYGmzMiAbiBn4GhT PDmw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id j190-20020a638bc7000000b0057795a17f4asi8537996pge.177.2023.09.18.12.55.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 12:55:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 6959981FEC53; Mon, 18 Sep 2023 12:53:29 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230052AbjIRTwK (ORCPT + 25 others); Mon, 18 Sep 2023 15:52:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229771AbjIRTvm (ORCPT ); Mon, 18 Sep 2023 15:51:42 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64B89137 for ; Mon, 18 Sep 2023 12:51:36 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qiKH8-0003kZ-Tz; Mon, 18 Sep 2023 21:51:18 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qiKH8-007I8f-Gf; Mon, 18 Sep 2023 21:51:18 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qiKH8-002mCM-6z; Mon, 18 Sep 2023 21:51:18 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Andrew Lunn , Heiner Kallweit Cc: Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 06/19] net: mdio: ipq4019: Convert to platform remove callback returning void Date: Mon, 18 Sep 2023 21:50:49 +0200 Message-Id: <20230918195102.1302746-7-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230918195102.1302746-1-u.kleine-koenig@pengutronix.de> References: <20230918195102.1302746-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1770; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=53bQT0brWvmojLGsSw5tHyo9YgNKA/khjFsSsXxipzQ=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlCKoGR0bUSJIrhX5xYRQRyvkwUi0NYN0zO0Ope erjMwwMe0iJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZQiqBgAKCRCPgPtYfRL+ Tu67CACdG5bLLV7eYrWGT4121uBTVyyV7xYiIROvhUFh3GM7WkkB0slPoUmP5BwLp3EbT7NHEL9 A/AbC6K8ZWU8dixOBt/RQnaXiMENdoLzL1Iw41fHQkEpQUnjA/qY4A2dNTOR2FyIzO4aTxkRJJq TBGykg/j3vqkTk+B2gnyL1zcYXivhJvKyVzJxOBcYEs+d3t4++L5XA+lj9muKQymm7OHp8RXMhc /dNU7DGF/cjQbr3ez+iPCzk2pAbhvg+P61lqMrp8tQKLDAQ3mvvJiLL/LhmnEGPev2l6aYMU0xN hebULZjHkGh41EtRutuCyk4JWOye7SuRijRE01DI4tc8iW5P X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 18 Sep 2023 12:53:29 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777406517595198342 X-GMAIL-MSGID: 1777406517595198342 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() is renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/net/mdio/mdio-ipq4019.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/mdio/mdio-ipq4019.c b/drivers/net/mdio/mdio-ipq4019.c index 78b93de636f5..abd8b508ec16 100644 --- a/drivers/net/mdio/mdio-ipq4019.c +++ b/drivers/net/mdio/mdio-ipq4019.c @@ -278,13 +278,11 @@ static int ipq4019_mdio_probe(struct platform_device *pdev) return 0; } -static int ipq4019_mdio_remove(struct platform_device *pdev) +static void ipq4019_mdio_remove(struct platform_device *pdev) { struct mii_bus *bus = platform_get_drvdata(pdev); mdiobus_unregister(bus); - - return 0; } static const struct of_device_id ipq4019_mdio_dt_ids[] = { @@ -296,7 +294,7 @@ MODULE_DEVICE_TABLE(of, ipq4019_mdio_dt_ids); static struct platform_driver ipq4019_mdio_driver = { .probe = ipq4019_mdio_probe, - .remove = ipq4019_mdio_remove, + .remove_new = ipq4019_mdio_remove, .driver = { .name = "ipq4019-mdio", .of_match_table = ipq4019_mdio_dt_ids,