From patchwork Mon Sep 18 19:50:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 141555 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp2921588vqi; Mon, 18 Sep 2023 13:06:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF9vIv2sFCY890/lvMJrk1vsEoP06oVvJOAjN8IE2SvXC30JlvHbL0MddGxY0AU7zCAWoWQ X-Received: by 2002:a17:902:db09:b0:1c4:4a4d:cc6 with SMTP id m9-20020a170902db0900b001c44a4d0cc6mr830081plx.19.1695067581181; Mon, 18 Sep 2023 13:06:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695067581; cv=none; d=google.com; s=arc-20160816; b=wi0MHvqeTgDHRSdpdDdfqGTJ+geTkh5OtX/mt++wpP9EngWFuNXLcH3akr1niiwd5b CDEejmUrZ5Zzq0HXnCBQkjkmbWV/2i38yz2+AncTisy7e7hEv5f6oqn8PigwQld3U1+x 2HAWrjB/I52zkIu3EfqKKsgCPvyvFgxlTSUC3/6jnj74lPIMkouW1r9xn3PXfxJeSO4X d2SEoDIQkew6m1j9IYxNDAhnkabzh3Wsf69D/35i8fiGUzEAegvDGNPWhVAu4zQu6vo9 habOB/8lXwVT499v+pzaBZDfkZ3X2go6z3wr/E7ckijMWN3yTScTv8vAuLuOXVIsANNq FVmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=WGI9phaUF3kfEvo6N5Dh4AKVLel/sladJI5HIKqwEQY=; fh=2LoUldgIftbCGGYNlIKiEffIWCdRcQL9EB8MUfMGcWk=; b=Df0lnXmgviHQex4WZStBt3/e6cDoRtbzzS3U3rnUwACCbMUvQGvwm+wZO+VwCtqCGF TYHyBhFp05FbvDexoBRgSNywDNBgQuGlj87sJJYdQJ+XUt2cb/1cYB6pdpb8Uos8Hwve uzLFHspp601bLpcOCfke7HJN1MN2u+GlSTDvsdCdORczl2LPU79kHbVAPQ2TxR5+Qg6O ZsDkg7jo5ia0o3++rT2Igw2T2c+t3H962g7vmEfNkSPOAQwLipYrSIt4dA6bLJm4pGJk i9td1ojcl+O4S09QqaGx9/aD1I0gpmJKtJowSKEyn8ETYZRBJ1K0FfpipW0oCrD9EOsF 6z3g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id t22-20020a63eb16000000b00573ff1f360bsi8335510pgh.479.2023.09.18.13.06.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 13:06:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 0750881B93D6; Mon, 18 Sep 2023 12:52:05 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229937AbjIRTwC (ORCPT + 25 others); Mon, 18 Sep 2023 15:52:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229686AbjIRTvl (ORCPT ); Mon, 18 Sep 2023 15:51:41 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB96B128 for ; Mon, 18 Sep 2023 12:51:34 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qiKH8-0003kT-N6; Mon, 18 Sep 2023 21:51:18 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qiKH8-007I8c-9v; Mon, 18 Sep 2023 21:51:18 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qiKH8-002mCH-0K; Mon, 18 Sep 2023 21:51:18 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Andrew Lunn , Heiner Kallweit Cc: Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 05/19] net: mdio: hisi-femac: Convert to platform remove callback returning void Date: Mon, 18 Sep 2023 21:50:48 +0200 Message-Id: <20230918195102.1302746-6-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230918195102.1302746-1-u.kleine-koenig@pengutronix.de> References: <20230918195102.1302746-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2009; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=HQon30rRgBBgFtnAN7jXNVSSzpSUENvH/4/wmd2IRT4=; b=owGbwMvMwMXY3/A7olbonx/jabUkhlSOVSy9rSkl6fWq2v7mOcFFEQmKorExfe9VJxXa2Zw0z 8rl8uxkNGZhYORikBVTZLFvXJNpVSUX2bn232WYQaxMIFMYuDgFYCKb73IwdAekO1m9W6DqI/T+ 442fxw1kj2lseLrhzpell+dZV905WnyzVH6tyYfpgf9Us655T3SXk95RMbd7fpKO0AtNsVjVi9+ 4xTyT2D49DI1bpOD6TzjpU2TS79Bkr3KXtxMPJi3/8OOn9j/hK7oTyr++P/DU6Yq2pV54YzHD4W ul6iwVPxkjLrGZGoXu+qGfeSP59LT+KUtLttd8FvTyMwnwtRQ9Kntsz67rT/PEzHKjmq9IvIquC 65jepHZ87f7b9GsiTsLqu6XbfaSuKLSXhw741Ry7rWe/3PTpfW3m3VPE43+b3aqx+a/vopBctiS u+wfQhQzAjUZT6ldf65yeQOf7MdIncl3bTyW7NPifx4NAA== X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 18 Sep 2023 12:52:05 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777407183821895751 X-GMAIL-MSGID: 1777407183821895751 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() is renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/net/mdio/mdio-hisi-femac.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/mdio/mdio-hisi-femac.c b/drivers/net/mdio/mdio-hisi-femac.c index f231c2fbb1de..6703f626ee83 100644 --- a/drivers/net/mdio/mdio-hisi-femac.c +++ b/drivers/net/mdio/mdio-hisi-femac.c @@ -118,7 +118,7 @@ static int hisi_femac_mdio_probe(struct platform_device *pdev) return ret; } -static int hisi_femac_mdio_remove(struct platform_device *pdev) +static void hisi_femac_mdio_remove(struct platform_device *pdev) { struct mii_bus *bus = platform_get_drvdata(pdev); struct hisi_femac_mdio_data *data = bus->priv; @@ -126,8 +126,6 @@ static int hisi_femac_mdio_remove(struct platform_device *pdev) mdiobus_unregister(bus); clk_disable_unprepare(data->clk); mdiobus_free(bus); - - return 0; } static const struct of_device_id hisi_femac_mdio_dt_ids[] = { @@ -138,7 +136,7 @@ MODULE_DEVICE_TABLE(of, hisi_femac_mdio_dt_ids); static struct platform_driver hisi_femac_mdio_driver = { .probe = hisi_femac_mdio_probe, - .remove = hisi_femac_mdio_remove, + .remove_new = hisi_femac_mdio_remove, .driver = { .name = "hisi-femac-mdio", .of_match_table = hisi_femac_mdio_dt_ids,