From patchwork Mon Sep 18 19:51:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 141544 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp2916086vqi; Mon, 18 Sep 2023 12:58:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFllna/p3pUyXRVztSvRbX6HapakRQEawmBMGMWV4CW4HNtr7KlZDeUWDMcGXWtVzbLcvPX X-Received: by 2002:a17:902:d4d0:b0:1bb:9c45:130f with SMTP id o16-20020a170902d4d000b001bb9c45130fmr11941395plg.69.1695067097508; Mon, 18 Sep 2023 12:58:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695067097; cv=none; d=google.com; s=arc-20160816; b=NNKTihHOwYPhtphxA9oRSk885dreOTKmfVZaOSOnxi8dOY3OHHWFH/oZmhrriZ7vd5 4WgI6ZauvDS9ohzAxLkjosXSISsQ+bZ6iFVZ1qbTxh2Ds1YJWzIg91m4kpl+JpcrBsJe 7brSgKazydQMgVuLxaVIWLUx+r5vC5INTIkMbYG/pHQ4HUTMgIaaGPScuxr/1utOlemG TR59L/U+XNLR4prfAMxCCVY8ojOt+r0yOzgbysVffetsCf6JbXcrR73RaD3JZnZMeea4 +slP1KrVmC8gkXx6BSdowoI4F0ZQtNMmXxOH9gYx3ajjkH70rnC5MAWPHRw469Hk9Sz/ JCUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=+wmlsC8cQQnUD+IQPsTuDlloyQg89J9HIZGpjDSA+Uc=; fh=Mpq8JQcdAeUDY+nJx2fwp08sYbwq0jpH6D3eLSAGGIQ=; b=f8ZbjIN75gFubo/+f9ghjRgOi9uW9ayIdcRm/b1MMHLqNgbkU1tdgONUZIKjJF/Sga VyIHgmjIPEa2H9wujPw7MQU0yo12tCi7mkn+yyNJQUeKhZyKhi6WXCIwFVbMDuNFI8e/ Lewz9TvDP1RhC85lY/vkkwWans6Tgfdl7GNV6CWWtJDMJ7pWG383r01QyZAFvho06pqj +eWG+kcDtoR5x2W0SO8F1a2Hb9/UWPg5HfcBJ8oRgD9jS6HG3KqJ9MdUnRhoB0OLHnNL ZtIFGyh0CRzdBlXrH/9QJGIVqgbBMO69HDNndAb15u9pNHNmstR8wsjhOBL79uZzkcvf 20xg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id u11-20020a170902e80b00b001bdc9c55295si9064703plg.593.2023.09.18.12.58.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 12:58:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 0B7D0803EE25; Mon, 18 Sep 2023 12:53:10 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230114AbjIRTwZ (ORCPT + 25 others); Mon, 18 Sep 2023 15:52:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229881AbjIRTvt (ORCPT ); Mon, 18 Sep 2023 15:51:49 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21CB4197 for ; Mon, 18 Sep 2023 12:51:41 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qiKHC-0003v0-1P; Mon, 18 Sep 2023 21:51:22 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qiKHB-007I9Y-Hh; Mon, 18 Sep 2023 21:51:21 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qiKHB-002mDB-7z; Mon, 18 Sep 2023 21:51:21 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Andrew Lunn , Heiner Kallweit Cc: Iyappan Subramanian , Keyur Chudgar , Quan Nguyen , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 19/19] net: mdio: xgene: Convert to platform remove callback returning void Date: Mon, 18 Sep 2023 21:51:02 +0200 Message-Id: <20230918195102.1302746-20-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230918195102.1302746-1-u.kleine-koenig@pengutronix.de> References: <20230918195102.1302746-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1888; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=+lRpMpTPOqtxkBsIhgMJZMmhqpybzGn51IpnndXHe20=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlCKoVxIes308o6YqvuoA1oRizRNhw4eywBhr9t iUjxlYbnGaJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZQiqFQAKCRCPgPtYfRL+ TmxCB/4/Kgd4hHK5avDIvbMAescmiI8fyE6w2FIEs0ibcV7oQkt20IzJE0kJVpEr6iarQJ0MhDM FXMPcHgHiqhnkz/JvfVz8xVGfy1PMyCv69MMZrD5g62mbrfIQKjx10WtjEh+AA6SQgYvSd4LnZj 1SZ0cWAs3nLYYxzlleFvhT1ulbRemLTAyQZYXTX9sfyM/r9iGYCwnok69zoJ1cOw8enpQexgKjV uxqdu+65O5XnO7BAqkpPeEEG5wcI4USfDPJx7cRmdKYZjCYr77tcfyXdlw5qh8p3YeK7oqqlX5E rTqWpH7erqc4dcDwSMxpEkUflHlA6Y2V4n/OJ8OkJS/AY+8J X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 18 Sep 2023 12:53:10 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777406676720005531 X-GMAIL-MSGID: 1777406676720005531 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() is renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/net/mdio/mdio-xgene.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/mdio/mdio-xgene.c b/drivers/net/mdio/mdio-xgene.c index 1190a793555a..7909d7caf45c 100644 --- a/drivers/net/mdio/mdio-xgene.c +++ b/drivers/net/mdio/mdio-xgene.c @@ -432,7 +432,7 @@ static int xgene_mdio_probe(struct platform_device *pdev) return ret; } -static int xgene_mdio_remove(struct platform_device *pdev) +static void xgene_mdio_remove(struct platform_device *pdev) { struct xgene_mdio_pdata *pdata = platform_get_drvdata(pdev); struct mii_bus *mdio_bus = pdata->mdio_bus; @@ -443,8 +443,6 @@ static int xgene_mdio_remove(struct platform_device *pdev) if (dev->of_node) clk_disable_unprepare(pdata->clk); - - return 0; } static struct platform_driver xgene_mdio_driver = { @@ -454,7 +452,7 @@ static struct platform_driver xgene_mdio_driver = { .acpi_match_table = ACPI_PTR(xgene_mdio_acpi_match), }, .probe = xgene_mdio_probe, - .remove = xgene_mdio_remove, + .remove_new = xgene_mdio_remove, }; module_platform_driver(xgene_mdio_driver);