From patchwork Mon Sep 18 19:50:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 141553 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp2921513vqi; Mon, 18 Sep 2023 13:06:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGw2ZY22hJZIgnH0NjqJh+KmRLj9aZg26vzQAhtF6wxwunpTOoIyVt6qNdGs1kHtfsW4GmD X-Received: by 2002:a05:6a00:1ac6:b0:690:45cc:bd37 with SMTP id f6-20020a056a001ac600b0069045ccbd37mr10263165pfv.18.1695067573435; Mon, 18 Sep 2023 13:06:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695067573; cv=none; d=google.com; s=arc-20160816; b=Z2/bt3sLSPWHi1CU5H03XMH5A+7WL0Qh/rbK2g5ypy8DK53AF4d1HfWPD1peb32F9w kihMwr2St+bWR/lVNECTfcvhZ8sa4kXmEGt9zR8CFH7FhMQAf8CbuV47f/f2ZF99ZxX4 EpKACoyzGUoVZQhRJ4lChWikUVlZ7L53hIWujE3LvklnzI+hCne18sS4nFok2klSjayI 3053Zs9NCsMJsVC0Mh7p9WtnSE+u324pqrXc7zaIcOyipegtptUDue/scvgVTNynvNO4 Lt+mkNbWsN0h7PbCP4CEzvvlmbwIvOjOycU1NiCuQSKXIonQ98P/66ftO0gbvYUQsNvc jGlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=uGluRPa0tx6/HQsPOnatD0dUn1jagiimi5Nyl5RyVmA=; fh=2LoUldgIftbCGGYNlIKiEffIWCdRcQL9EB8MUfMGcWk=; b=k3ZAhNhhu+QAXj9t66SCmrT/8VNVPBNpOJ6+HjT50qU5oArWf7rqtcB7rLsxXbEAKk qAJDHTK6otUuexpyR/Tf4gIzebtCv4dLlLTzyW5zMMInaSgLsHc7yHz3/qfLIrA3C3JH aTPFMQ+PAD/PbK8DTdn7Svz91o0pgdT8QpplaaOteBvy2rlwm89O3uSii+mQOFlNAQ0b DTQhzB3u0k8n/4Y13XStBe2bsTyakU4CXbsfYW1TfSl0tbq01ukwpJJa08ajXI9Lt9J2 uBQGDVLmbjJvbk+AiYILQGuBeap+meu7ZGIOsxJXg8IllfUsnrn/NJFMfwL1Ly4Xz29f f+/g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id fb20-20020a056a002d9400b00686e01db946si8694190pfb.64.2023.09.18.13.06.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 13:06:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 52A1E81B8958; Mon, 18 Sep 2023 12:51:53 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229938AbjIRTvw (ORCPT + 25 others); Mon, 18 Sep 2023 15:51:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229623AbjIRTvh (ORCPT ); Mon, 18 Sep 2023 15:51:37 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DE0C109 for ; Mon, 18 Sep 2023 12:51:31 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qiKHA-0003tL-C7; Mon, 18 Sep 2023 21:51:20 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qiKH9-007I95-VJ; Mon, 18 Sep 2023 21:51:19 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qiKH9-002mCk-M5; Mon, 18 Sep 2023 21:51:19 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Andrew Lunn , Heiner Kallweit Cc: Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 12/19] net: mdio: mux-gpio: Convert to platform remove callback returning void Date: Mon, 18 Sep 2023 21:50:55 +0200 Message-Id: <20230918195102.1302746-13-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230918195102.1302746-1-u.kleine-koenig@pengutronix.de> References: <20230918195102.1302746-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1760; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=hQqRNV8NsCd4cBul46DdSDBZQJNVvAuFrQayXN//utY=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlCKoOwxkwQFWAkwvVquicdsXySMLhBTb7umS07 Os3/QW54DyJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZQiqDgAKCRCPgPtYfRL+ ThfrB/4gxxOgjOJ8EtCV/RM63KVb5TugxUI10+z/PiyrPUM8rYtn4wjMlFImlITihxAAhNu0sqq v2DeaR0GE/EI9Vx84zkgyLVOmYFWa+FT5VN1Fm8EkqNZFfnj/ND3NAF2zxo4R4h5ds+avN12Ts1 VGhtQ+uSTyzpOQ4Hrro7wiEk9cq+LD2ydfHoCmBbNtylbx7DoZi30X5eEMIfuwL29JCZlVRwBD0 Cwz5EQpmQLAESKhhJHBdrpwHxKyNX9iCfYTth12y5vBBiLwis/D0wBMeBm+d1RhYQlq0InXJVNH n1t0SC9Ph1DGBstl0aBnKOmlYS4zV7SmxKsrvNyWnwGkDDVU X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 18 Sep 2023 12:51:53 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777407176082042584 X-GMAIL-MSGID: 1777407176082042584 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() is renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/net/mdio/mdio-mux-gpio.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/mdio/mdio-mux-gpio.c b/drivers/net/mdio/mdio-mux-gpio.c index 3c7f16f06b45..38fb031f8979 100644 --- a/drivers/net/mdio/mdio-mux-gpio.c +++ b/drivers/net/mdio/mdio-mux-gpio.c @@ -62,11 +62,10 @@ static int mdio_mux_gpio_probe(struct platform_device *pdev) return 0; } -static int mdio_mux_gpio_remove(struct platform_device *pdev) +static void mdio_mux_gpio_remove(struct platform_device *pdev) { struct mdio_mux_gpio_state *s = dev_get_platdata(&pdev->dev); mdio_mux_uninit(s->mux_handle); - return 0; } static const struct of_device_id mdio_mux_gpio_match[] = { @@ -87,7 +86,7 @@ static struct platform_driver mdio_mux_gpio_driver = { .of_match_table = mdio_mux_gpio_match, }, .probe = mdio_mux_gpio_probe, - .remove = mdio_mux_gpio_remove, + .remove_new = mdio_mux_gpio_remove, }; module_platform_driver(mdio_mux_gpio_driver);