From patchwork Mon Sep 18 19:50:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 141548 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp2921226vqi; Mon, 18 Sep 2023 13:05:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGecgMkulx6F5uVDUlemfXEIJbpmOXPT9podPuakUkr/wA82V7veJA660tCgz+G1tmftFW9 X-Received: by 2002:a17:90a:c4f:b0:267:70a8:abff with SMTP id u15-20020a17090a0c4f00b0026770a8abffmr8532510pje.29.1695067548627; Mon, 18 Sep 2023 13:05:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695067548; cv=none; d=google.com; s=arc-20160816; b=ogDDHIK0sWK6CFkb0fgc6547zRPtihoxfTfkPiOjGTChNzMw9PW5M+Tl8HLUyBtE52 EWjxoKAi3iIyoiGGlznCLQcvomMdhGjkJuIJcIrB6UfhqK/oLK1L2yomnBp5f5ZknImL x9W8cxJSCEBICtAsJ2UIhAXdA2taSIlQTFBoa/oS1O5gZ5nyQj5VEl8/jhdujwspFWMD RtW0WfbDCcO8KxdqiQBJOfwmw+tmE4cinywGIzPXti9G0Eu6uxps4HtyUJs0FY2dQxNZ P0HMDSN1HeZZgHGzhsXjVTJu8b4694gq+dX+NKpwGPK62cHvj9kwErKL0vyotnY7TVo7 gBUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=oH+T2XuhA9i+z2wbZ72nF9rrswTXO71txadIKb7Df+I=; fh=3w/gWP9AjeP35Yt+9ETEM//9CZFAojrIL8kNXmM6h8U=; b=N51WiROEEle4/kEJMn3MKFuugglIjYMFmWfunUHkeb1OExvcKRyozzCf0v3XwqzEhF GVmnDIjHxkZTvL+HDUP/gtfgytxSp+qyKhcslTXRGOFoox0nZj5VnR4xjhmuhluXJ5Nu DXmaHtb5pqKRTA619xjIjPQ/g1vVQ5NbVtyUQF/OaygoA0G0TxWaQafMPC3qosKcIW9o u3wTZbKMMtQD50nyb5+gYSna7HFOrOoWwD+dOf61qDqdFzHCnxcwGJ9J2uspbB/c46UY daRFlYZYBEuJR8NCCcWISvVR2qYTtRRL5sj+uV/eQFDY3iZji8xwjvnOjpaMtuaP/Y6I UlnA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id n5-20020a17090a9f0500b0025bdc2a0b15si10617015pjp.135.2023.09.18.13.05.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 13:05:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 77304822CB21; Mon, 18 Sep 2023 12:52:36 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229985AbjIRTv6 (ORCPT + 25 others); Mon, 18 Sep 2023 15:51:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229605AbjIRTvj (ORCPT ); Mon, 18 Sep 2023 15:51:39 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8779E10F for ; Mon, 18 Sep 2023 12:51:33 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qiKH9-0003og-Uw; Mon, 18 Sep 2023 21:51:19 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qiKH9-007I8x-GU; Mon, 18 Sep 2023 21:51:19 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qiKH9-002mCc-5i; Mon, 18 Sep 2023 21:51:19 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Andrew Lunn , Heiner Kallweit Cc: Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ray Jui , Scott Branden , Broadcom internal kernel review list , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 10/19] net: mdio: mux-bcm-iproc: Convert to platform remove callback returning void Date: Mon, 18 Sep 2023 21:50:53 +0200 Message-Id: <20230918195102.1302746-11-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230918195102.1302746-1-u.kleine-koenig@pengutronix.de> References: <20230918195102.1302746-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1834; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=M52LgWHkFZ/4d48b6ksHEiG2E1+/CV6YxGBCzg5tYiU=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlCKoL1nUgsydk6XQA+RbH/xkc34Zk0EDvzUx2w +VD7AMY/YqJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZQiqCwAKCRCPgPtYfRL+ TiPIB/9kGsTktZ5XGR76AWUBluoKx4ggJTt+L92ib8tyoU82m553O0Ah2JdARGVnCmMaA781hN3 ro4SnJWwnRzKoxVqLiep+XhI4svyu6mXqsTjAihRf4JTdb0KKrPL2B0yemtzs330yJyiW6v7u2Y MH/z9yB/CGM3dzsMuxWMTPVnxdaJraa4cmQBLgsW6ie2LMn9Uhv7QemRA0p1g1TNHXwXhID5Utt SLfuYnqNXEiRr/dftP3gvZaaYGEeC7B+6XsGIRwouJgSDYH81cmy4HerpdYA98XuLUcmYzWdo2i 4HY3GNXxp+lrRO1E7qVdb+qk0To6Oz3EBUTEwI/T6XNlhGV5 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 18 Sep 2023 12:52:36 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777407149526056429 X-GMAIL-MSGID: 1777407149526056429 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() is renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Florian Fainelli --- drivers/net/mdio/mdio-mux-bcm-iproc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/mdio/mdio-mux-bcm-iproc.c b/drivers/net/mdio/mdio-mux-bcm-iproc.c index 956d54846b62..a750bd4c77a0 100644 --- a/drivers/net/mdio/mdio-mux-bcm-iproc.c +++ b/drivers/net/mdio/mdio-mux-bcm-iproc.c @@ -287,15 +287,13 @@ static int mdio_mux_iproc_probe(struct platform_device *pdev) return rc; } -static int mdio_mux_iproc_remove(struct platform_device *pdev) +static void mdio_mux_iproc_remove(struct platform_device *pdev) { struct iproc_mdiomux_desc *md = platform_get_drvdata(pdev); mdio_mux_uninit(md->mux_handle); mdiobus_unregister(md->mii_bus); clk_disable_unprepare(md->core_clk); - - return 0; } #ifdef CONFIG_PM_SLEEP @@ -342,7 +340,7 @@ static struct platform_driver mdiomux_iproc_driver = { .pm = &mdio_mux_iproc_pm_ops, }, .probe = mdio_mux_iproc_probe, - .remove = mdio_mux_iproc_remove, + .remove_new = mdio_mux_iproc_remove, }; module_platform_driver(mdiomux_iproc_driver);